-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated tests #684
base: main-enterprise
Are you sure you want to change the base?
Updated tests #684
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f534c6e - Browse repository at this point
Copy the full SHA f534c6eView commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 04434a2 - Browse repository at this point
Copy the full SHA 04434a2View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 775b7ca - Browse repository at this point
Copy the full SHA 775b7caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87b8a95 - Browse repository at this point
Copy the full SHA 87b8a95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60f8fd3 - Browse repository at this point
Copy the full SHA 60f8fd3View commit details
Commits on Oct 5, 2024
-
These were added as part of understanding the code, commiting in case they might be useful for others as well.
Configuration menu - View commit details
-
Copy full SHA for 336d739 - Browse repository at this point
Copy the full SHA 336d739View commit details -
Configuration menu - View commit details
-
Copy full SHA for e826f40 - Browse repository at this point
Copy the full SHA e826f40View commit details -
add missing owner.login property in push.settings.json
This is what probot actually uses to identify the org, so it should probably be there in the fixture.
Configuration menu - View commit details
-
Copy full SHA for 2b90f8b - Browse repository at this point
Copy the full SHA 2b90f8bView commit details -
change sender type in repository.edited.json
When `sender.type` is bot, the change is skipped. This led to the test checking for changes on this event failing.
Configuration menu - View commit details
-
Copy full SHA for f94f6e4 - Browse repository at this point
Copy the full SHA f94f6e4View commit details -
use standard probot logger in index.test.js
This seems to me to be the best way for logs to show up in a useful fashion when running tests.
Configuration menu - View commit details
-
Copy full SHA for 520f6e8 - Browse repository at this point
Copy the full SHA 520f6e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6eff20c - Browse repository at this point
Copy the full SHA 6eff20cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 585c7da - Browse repository at this point
Copy the full SHA 585c7daView commit details -
return data when updating branch protection
This is needed for the test to be able to check that it was called.
Configuration menu - View commit details
-
Copy full SHA for 8bc6886 - Browse repository at this point
Copy the full SHA 8bc6886View commit details -
Configuration menu - View commit details
-
Copy full SHA for 489546b - Browse repository at this point
Copy the full SHA 489546bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bb2713 - Browse repository at this point
Copy the full SHA 0bb2713View commit details -
Also adds support for ovveriding the filter list in `Diffable.sync`. This is needed for milestones to work correctly. However, it should be tested well to ensure it does not break anything else.
Configuration menu - View commit details
-
Copy full SHA for 5178080 - Browse repository at this point
Copy the full SHA 5178080View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16925d6 - Browse repository at this point
Copy the full SHA 16925d6View commit details -
refact: changed to async/await and removed some returns
I believe this change makes the logic easier to follow, especially not returning data that does not need to be returned.
Configuration menu - View commit details
-
Copy full SHA for 996af69 - Browse repository at this point
Copy the full SHA 996af69View commit details -
refact: avoid repeating code in
updateRepos
This change should give the exact same result, except moving the `else`-block within the try/catch (and I don't see why that is bad). The refactor makes it easier to understand the difference in logic with and without a present `repoConfig` by only having the actual alternate action within the if/else and keeping the bit that always happen outside the if/else.
Configuration menu - View commit details
-
Copy full SHA for cb401ec - Browse repository at this point
Copy the full SHA cb401ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for cac9b84 - Browse repository at this point
Copy the full SHA cac9b84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b0c66b - Browse repository at this point
Copy the full SHA 9b0c66bView commit details -
fix: update eslint ecmaVersion to 13
Linting failed in deploymentConfig.js due to the static fields. Eslint supports this from ecmaVersion 13.
Configuration menu - View commit details
-
Copy full SHA for 444cefe - Browse repository at this point
Copy the full SHA 444cefeView commit details -
reapply eslint to tests, still supporting jest
The full test suite failed because it tried to lint the tests, while the running linter did not do the same. Enabling linting gave errors due to jest having undef stuff, but overriding these files for jest env keeps the linting without these errors.
Configuration menu - View commit details
-
Copy full SHA for b4ea065 - Browse repository at this point
Copy the full SHA b4ea065View commit details