Safe Settings doesn't run with just repos

[bheemvennapureddy]

safesettings doesn't run with just using the repo/*.yml which means removing settings.yml and deployment-settings.yml

[bheemvennapureddy]

@svg153 @decyjphr am i doing anything wrong ?

[bheemvennapureddy]

[decyjphr]

It is coded to expect the settings.yml so it probably ends up as an error.

[bheemvennapureddy]

@decyjphr so we can't just rely on the repo's configuration and ignore the org config ?

[svg153]

@decyjphr so we can't just rely on the repo's configuration and ignore the org config ?

It might be interesting to have a feature flag. Aren't you interested in having general configurations that apply to all repositories? or what is the reason? to know, curiosity

[bheemvennapureddy]

each team has different reasons to have diff policies but i should be able to manage repo level policies

[bheemvennapureddy]

What ever we have in the precedence order should be able to maintain them independently

[bheemvennapureddy]

Looks like i also always need base branch protection rule without that i see this error

t;,"x-ratelimit-reset":"1702965036","x-ratelimit-resource":"core","x-ratelimit-used":"443","x-xss-protection":"0"},"data":{"message":"Invalid request.\\n\\nNo subschema in \\"anyOf\\" matched.\\nNo subschema in \\"oneOf\\" matched.\\nNot all subschemas of \\"allOf\\" matched.\\nFor 'anyOf/1', {\\"contexts\\"=>[\\"build\\", \\"codecov/patch\\", \\"validate_work_item\\", \\"actions\\"]} is not a null

[bheemvennapureddy]

@svg153 @decyjphr any thoughts here ?

[svg153]

Looks like i also always need base branch protection rule without that i see this error

t;,"x-ratelimit-reset":"1702965036","x-ratelimit-resource":"core","x-ratelimit-used":"443","x-xss-protection":"0"},"data":{"message":"Invalid request.\\n\\nNo subschema in \\"anyOf\\" matched.\\nNo subschema in \\"oneOf\\" matched.\\nNot all subschemas of \\"allOf\\" matched.\\nFor 'anyOf/1', {\\"contexts\\"=>[\\"build\\", \\"codecov/patch\\", \\"validate_work_item\\", \\"actions\\"]} is not a null

I do not have any protect rule in my test org and works correctly: https://github.com/svg153-org/admin/blob/main/.github/settings.yml

[decyjphr]

@svg153 @decyjphr any thoughts here ?

I tried to run a test without the settings.yml and I see that this line throws an error TypeError: Cannot read properties of undefined (reading 'data') at ConfigManager.loadYaml (/Users/decyjphr/projects/node/probot/safe-settings-oct-31/lib/configManager.js:28:34) at async syncSettings (/Users/decyjphr/projects/node/probot/safe-settings-oct-31/index.js:72:29) at async Promise.all (index 0) at async Promise.all (index 0) at async middleware (/Users/decyjphr/projects/node/probot/safe-settings-oct-31/node_modules/@octokit/webhooks/dist-node/index.js:355:5) {stack: 'TypeError: Cannot read properties of undefine…s/@octokit/webhooks/dist-node/index.js:355:5)', message: 'Cannot read properties of undefined (reading 'data')'}

I am guessing that we'll need to fix this piece of code to ignore the file not being there and provide a empty object there.

Would you be able to modify this code? Or I can take a look at this later this week.

[bheemvennapureddy]

@svg153 @decyjphr any thoughts here ?

I tried to run a test without the settings.yml and I see that this line throws an error TypeError: Cannot read properties of undefined (reading 'data') at ConfigManager.loadYaml (/Users/decyjphr/projects/node/probot/safe-settings-oct-31/lib/configManager.js:28:34) at async syncSettings (/Users/decyjphr/projects/node/probot/safe-settings-oct-31/index.js:72:29) at async Promise.all (index 0) at async Promise.all (index 0) at async middleware (/Users/decyjphr/projects/node/probot/safe-settings-oct-31/node_modules/@octokit/webhooks/dist-node/index.js:355:5) {stack: 'TypeError: Cannot read properties of undefine…s/@octokit/webhooks/dist-node/index.js:355:5)', message: 'Cannot read properties of undefined (reading 'data')'}

I am guessing that we'll need to fix this piece of code to ignore the file not being there and provide a empty object there.

Would you be able to modify this code? Or I can take a look at this later this week.

#576 is this what you mean ?