Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema documentation error for consumed-licenses #2842

Closed
1 task done
google-admin opened this issue Aug 3, 2023 · 5 comments
Closed
1 task done

Schema documentation error for consumed-licenses #2842

google-admin opened this issue Aug 3, 2023 · 5 comments

Comments

@google-admin
Copy link

google-admin commented Aug 3, 2023

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/enterprise-cloud@latest/rest/enterprise-admin/license?apiVersion=2022-11-28#list-enterprise-consumed-licenses

What part(s) of the article would you like to see updated?

The example response for /enterprises/{enterprise}/consumed-licenses has an inconsistency, namely that one user has enterprise_server_primary_emails but the second has enterprise_server_emails.

{
  // ...
  "users": [
    {
      "github_com_login": "monalisa",
      // ...
      "enterprise_server_primary_emails": [
        "[email protected]"
      ],
      // ...
    },
    {
      "github_com_login": "",
      // ...
      "enterprise_server_emails": [
        "[email protected]"
      ],
      // ...
    }
  ]
}

The Response schema indicates that it should be the latter:

"enterprise_server_emails": {
  "type": "array",
  "items": {
    "type": "string"
  }
},

However, that has no results searching on this repo whereas the former is mentioned elsewhere.

Making a live API call returns enterprise_server_primary_emails as well. Could the docs be updated to match the source of truth? Thanks!

Additional information

No response

@welcome
Copy link

welcome bot commented Aug 3, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@cmwilson21
Copy link

@google-admin Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@docs-bot
Copy link
Collaborator

docs-bot commented Aug 6, 2023

Thank you for opening this issue! Changes to the REST API schema can be requested in github/rest-api-description. I will transfer your issue over to that open source repo.

1 similar comment
@docs-bot
Copy link
Collaborator

docs-bot commented Aug 8, 2023

Thank you for opening this issue! Changes to the REST API schema can be requested in github/rest-api-description. I will transfer your issue over to that open source repo.

@docs-bot docs-bot transferred this issue from github/docs Aug 8, 2023
@izuzak izuzak self-assigned this Sep 4, 2023
@izuzak
Copy link
Member

izuzak commented Sep 18, 2023

Thanks for reporting this -- this should be fixed now 🙇 🍰

@izuzak izuzak closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@izuzak @google-admin @vgrl @cmwilson21 @docs-bot and others