[aw] PR Code Quality Reviewer failed

[github-actions]

Workflow Failure

Workflow: PR Code Quality Reviewer
Branch: copilot/aw-fix-linter-miner-failure
Run: https://github.com/github/gh-aw/actions/runs/30770509772
Pull Request: #49862

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

{"type":"tool.execution_complete","timestamp":"2026-08-02T22:43:44.730Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"{\"additions\":215,\"body\":\"The Linter Miner workflow identified `Flush()` return-value discarding as an undetected error class — `errcheck` is disabled repo-wide and no existing linter covered it. Two live violations existed in `pkg/cli/logs_format_compact.go`.\\n\\n## New analyzer: `uncheckedflushreturn`\\n\\nFlags `Flush()` method calls where the `error` return is silently discarded. Uses type info to confirm the method signature is `func() error`, avoiding false positives on `Flush` methods that don't return errors.\\n\\nDetected patterns:\\n```go\\ntw.Flush()       // bare expression — flagged\\n_ = tw.Flush()   // explicit discard — flagged\\n\\nif err := tw.Flush(); err != nil { ... }  // ok\\n```\\n\\n## Fixes\\n\\n- **`pkg/cli/logs_format_compact.go`** — two `tabwriter.Writer.Flush()` calls now check and log the error via the package logger.\\n\\n## Registration\\n\\n- Added to `pkg/linters/registry.go` (`allAnalyzers`)\\n- `doc.go` count updated 61 → 62, bullet added\\n- `README.md` bullet list, subpackages table, and import list updated\\n- `spec_test.go` import, `documentedAnalyzers()` entry, and count comment updated\\n\\n<!-- START COPILOT CODING AGENT SUFFIX -->\\n\\n- Fixes #49821\",\"changedFiles\":9,\"deletions\":5,\"files\":[{\"path\":\"linters\",\"additions\":0,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/cli/logs_format_compact.go\",\"additions\":6,\"deletions\":2,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/README.md\",\"additions\":3,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/doc.go\",\"additions\":2,\"deletions\":1,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/registry.go\",\"additions\":2,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/spec_test.go\",\"additions\":4,\"deletions\":2,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/uncheckedflushreturn/testdata/src/uncheckedflushreturn/uncheckedflushreturn.go\",\"additions\":46,\"deletions\":0,\"changeType\":\"ADDED\"},{\"path\":\"pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go\",\"additions\":136,\"deletions\":0,\"changeType\":\"ADDED\"},{\"path\":\"pkg/linters/uncheckedflushreturn/uncheckedflushreturn_test.go\",\"additions\":16,\"deletions\":0,\"changeType\":\"ADDED\"}],\"headRefName\":\"copilot/aw-fix-linter-miner-failure\",\"headRefOid\":\"68fbfeeb4d24fe0bb062888787e97f381c4f476a\",\"number\":49862,\"title\":\"feat(linters): add uncheckedflushreturn analyzer + fix existing violations\"}\n---\n344 /tmp/gh-aw/agent/pr-diff.patch\n---\n[]\n<shellId: 10 completed with exit code 0>","detailedContent":"{\"additions\":215,\"body\":\"The Linter Miner workflow identified `Flush()` return-value discarding as an undetected error class — `errcheck` is disabled repo-wide and no existing linter covered it. Two live violations existed in `pkg/cli/logs_format_compact.go`.\\n\\n## New analyzer: `uncheckedflushreturn`\\n\\nFlags `Flush()` method calls where the `error` return is silently discarded. Uses type info to confirm the method signature is `func() error`, avoiding false positives on `Flush` methods that don't return errors.\\n\\nDetected patterns:\\n```go\\ntw.Flush()       // bare expression — flagged\\n_ = tw.Flush()   // explicit discard — flagged\\n\\nif err := tw.Flush(); err != nil { ... }  // ok\\n```\\n\\n## Fixes\\n\\n- **`pkg/cli/logs_format_compact.go`** — two `tabwriter.Writer.Flush()` calls now check and log the error via the package logger.\\n\\n## Registration\\n\\n- Added to `pkg/linters/registry.go` (`allAnalyzers`)\\n- `doc.go` count updated 61 → 62, bullet added\\n- `README.md` bullet list, subpackages table, and import list updated\\n- `spec_test.go` import, `documentedAnalyzers()` entry, and count comment updated\\n\\n<!-- START COPILOT CODING AGENT SUFFIX -->\\n\\n- Fixes #49821\",\"changedFiles\":9,\"deletions\":5,\"files\":[{\"path\":\"linters\",\"additions\":0,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/cli/logs_format_compact.go\",\"additions\":6,\"deletions\":2,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/README.md\",\"additions\":3,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/doc.go\",\"additions\":2,\"deletions\":1,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/registry.go\",\"additions\":2,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/spec_test.go\",\"additions\":4,\"deletions\":2,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/linters/uncheckedflushreturn/testdata/src/uncheckedflushreturn/uncheckedflushreturn.go\",\"additions\":46,\"deletions\":0,\"changeType\":\"ADDED\"},{\"path\":\"pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go\",\"additions\":136,\"deletions\":0,\"changeType\":\"ADDED\"},{\"path\":\"pkg/linters/uncheckedflushreturn/uncheckedflushreturn_test.go\",\"additions\":16,\"deletions\":0,\"changeType\":\"ADDED\"}],\"headRefName\":\"copilot/aw-fix-linter-miner-failure\",\"headRefOid\":\"68fbfeeb4d24fe0bb062888787e97f381c4f476a\",\"number\":49862,\"title\":\"feat(linters): add uncheckedflushreturn analyzer + fix existing violations\"}\n---\n344 /tmp/gh-aw/agent/pr-diff.patch\n---\n[]\n<shellId: 10 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-02T22:43:46.750Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-02T22:43:46.752Z","data":{"toolName":"bash","mcpServerName":"","command":"cat /tmp/gh-aw/agent/pr-diff.patch"}}
{"type":"tool.execution_complete","timestamp":"2026-08-02T22:43:46.825Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"diff --git a/linters b/linters\nindex d920e6a6151..5725ab9455a 100755\nBinary files a/linters and b/linters differ\ndiff --git a/pkg/cli/logs_format_compact.go b/pkg/cli/logs_format_compact.go\nindex ae0dac8f09d..05ba00a8012 100644\n--- a/pkg/cli/logs_format_compact.go\n+++ b/pkg/cli/logs_format_compact.go\n@@ -137,7 +137,9 @@ func renderLogsCompactToWriter(w io.Writer, data LogsData) {\n \t\t\tr.TokenUsage, formatCompactAIC(r.AIC), r.Turns, r.ErrorCount,\n \t\t\tr.Event, actor, branch)\n \t}\n-\ttw.Flush()\n+\tif err := tw.Flush(); err != nil {\n+\t\tlogsCompactLog.Printf(\"flush error: %v\", err)\n+\t}\n \n \t// [errors] — aggregated error/warning messages\n \tif len(data.ErrorsAndWarnings) > 0 {\n@@ -317,7 +319,9 @@ func renderLogsCompactVerboseToWriter(w io.Writer, data LogsData) {\n \t\t\tr.Event, actor, tbt, classification,\n \t\t\tr.CreatedAt.Format(\"01-02 15:04\"), r.Branch)\n \t}\n-\ttw.Flush()\n+\tif err := tw.Flush(); err != nil {\n+\t\tlogsCompactLog.Printf(\"flush error: %v\", err)\n+\t}\n \n \t// [errors]\n \tif len(data.ErrorsAndWarnings) > 0 {diff --git a/pkg/linters/README.md b/pkg/linters/README.md\nindex 6ee1ea8b056..836eb89dfdb 100644\n--- a/pkg/linters/README.md\n+++ b/pkg/linters/README.md\n@@ -64,6 +64,7 @@ This package currently provides custom Go analyzers in the following subpackages\n - `tolowerequalfold` — reports case-insensitive string comparisons using `strings.ToLower`/`ToUpper` that should use `strings.EqualFold`.\n - `trimleftright` — reports `strings.TrimLeft`/`TrimRight` calls with a multi-character literal cutset where `TrimPrefix`/`TrimSuffix` was likely intended.\n - `uncheckedtypeassertion` — reports single-value type assertions where unchecked panics are possible.\n+- `uncheckedflushreturn` — reports `Flush()` method calls where the error return is discarded, which silently drops buffered data on failure.\n - `wgdonenotdeferred` — reports non-deferred `sync.WaitGroup.Done()` calls that can deadlock on panics or early returns.\n - `writebytestring` — reports `w.Write([]byte(s))` calls where `s` is a string, which can be replaced with `io.WriteString` to avoid an unnecessary `[]byte` allocation.\n - `internal` — shared helper packages for analyzers (file checks and `nolint` handling).\n@@ -132,6 +133,7 @@ This package currently provides custom Go analyzers in the following subpackages\n | `tolowerequalfold` | Custom `go/analysis` analyzer that flags case-insensitive comparisons via `strings.ToLower`/`ToUpper` that should use `strings.EqualFold` |\n | `trimleftright` | Custom `go/analysis` analyzer that flags `strings.TrimLeft`/`TrimRight` calls with a multi-character literal cutset where `TrimPrefix`/`TrimSuffix` was likely intended |\n | `uncheckedtypeassertion` | Custom `go/analysis` analyzer that flags unchecked single-value type assertions |\n+| `uncheckedflushreturn` | Custom `go/analysis` analyzer that flags `Flush()` method calls where the error return is discarded |\n | `walkfuncerrshadow` | Custom `go/analysis` analyzer that flags `filepath.Walk`/`filepath.WalkDir` callbacks whose `err` parameter shadows an outer `err` variable assigned from the walk call |\n | `wgdonenotdeferred` | Custom `go/analysis` analyzer that flags non-deferred `sync.WaitGroup.Done()` calls |\n | `writebytestring` | Custom `go/analysis` analyzer that flags `w.Write([]byte(s))` calls where `s` is a string that can be replaced with `io.WriteString` |\n@@ -262,6 +264,7 @@ _ = trimleftright.Analyzer\n - `github.com/github/gh-aw/pkg/linters/tolowerequalfold` — to-lower-equal-fold analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/trimleftright` — trim-left-right analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/uncheckedtypeassertion` — unchecked-type-assertion analyzer subpackage\n+- `github.com/github/gh-aw/pkg/linters/uncheckedflushreturn` — unchecked-flush-return analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/walkfuncerrshadow` — walk-func-err-shadow analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/wgdonenotdeferred` — wg-done-not-deferred analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/writebytestring` — write-byte-string analyzer subpackagediff --git a/pkg/linters/doc.go b/pkg/linters/doc.go\nindex 53ef264705b..3a0f83c8de4 100644\n--- a/pkg/linters/doc.go\n+++ b/pkg/linters/doc.go\n@@ -1,6 +1,6 @@\n // Package linters is a namespace for gh-aw's custom Go analysis linters.\n //\n-// All 61 active analyzers:\n+// All 62 active analyzers:\n //\n //   - appendbytestring — flags append(b, []byte(s)...) calls where s is a string that can be simplified to append(b, s...)\n //   - appendoneelement — flags append(s, []T{x}...) calls where a single-element slice literal is spread and can be simplified to append(s, x)\n@@ -60,6 +60,7 @@\n //   - tolowerequalfold — flags case-insensitive comparisons via ToLower/ToUpper that should use EqualFold\n //   - trimleftright — flags strings.TrimLeft/TrimRight calls with a multi-character literal cutset where TrimPrefix/TrimSuffix was likely intended\n //   - uncheckedtypeassertion — flags unchecked single-value type assertions\n+//   - uncheckedflushreturn — flags Flush() method calls where the error return is discarded\n //   - walkfuncerrshadow — flags filepath.Walk/WalkDir callbacks whose err parameter shadows an outer err variable assigned from the walk call\n //   - wgdonenotdeferred — flags non-deferred sync.WaitGroup.Done() calls\n //   - writebytestring — flags w.Write([]byte(s)) calls where s is a string that can be replaced with io.WriteString(w, s)diff --git a/pkg/linters/registry.go b/pkg/linters/registry.go\nindex f20b15e227d..af0285ac238 100644\n--- a/pkg/linters/registry.go\n+++ b/pkg/linters/registry.go\n@@ -60,6 +60,7 @@ import (\n \t\"github.com/github/gh-aw/pkg/linters/timesleepnocontext\"\n \t\"github.com/github/gh-aw/pkg/linters/tolowerequalfold\"\n \t\"github.com/github/gh-aw/pkg/linters/trimleftright\"\n+\t\"github.com/github/gh-aw/pkg/linters/uncheckedflushreturn\"\n \t\"github.com/github/gh-aw/pkg/linters/uncheckedtypeassertion\"\n \t\"github.com/github/gh-aw/pkg/linters/walkfuncerrshadow\"\n \t\"github.com/github/gh-aw/pkg/linters/wgdonenotdeferred\"\n@@ -134,6 +135,7 @@ var allAnalyzers = []*analysis.Analyzer{\n \ttolowerequalfold.Analyzer,\n \ttrimleftright.Analyzer,\n \tuncheckedtypeassertion.Analyzer,\n+\tuncheckedflushreturn.Analyzer,\n \twalkfuncerrshadow.Analyzer,\n \twgdonenotdeferred.Analyzer,\n \twritebytestring.Analyzer,diff --git a/pkg/linters/spec_test.go b/pkg/linters/spec_test.go\nindex ccac35b7ad2..394b634d283 100644\n--- a/pkg/linters/spec_test.go\n+++ b/pkg/linters/spec_test.go\n@@ -68,6 +68,7 @@ import (\n \t\"github.com/github/gh-aw/pkg/linters/timesleepnocontext\"\n \t\"github.com/github/gh-aw/pkg/linters/tolowerequalfold\"\n \t\"github.com/github/gh-aw/pkg/linters/trimleftright\"\n+\t\"github.com/github/gh-aw/pkg/linters/uncheckedflushreturn\"\n \t\"github.com/github/gh-aw/pkg/linters/uncheckedtypeassertion\"\n \t\"github.com/github/gh-aw/pkg/linters/walkfuncerrshadow\"\n \t\"github.com/github/gh-aw/pkg/linters/wgdonenotdeferred\"\n@@ -87,7 +88,7 @@ type docAnalyzer struct {\n }\n \n // documentedAnalyzers returns the analyzer subpackages documented in the README\n-// \"Public API > Subpackages\" table. The README documents 61 analyzers\n+// \"Public API > Subpackages\" table. The README documents 62 analyzers\n // subpackages (the non-analyzer `internal` helper subpackage is excluded because\n // it exposes no Analyzer).\n //\n@@ -99,7 +100,7 @@ type docAnalyzer struct {\n //\tlogfatallibrary, manualmutexunlock, mapclearloop, mapdeletecheck, nilctxpassed, osexitinlibrary, osgetenvlibrary, ossetenvlibrary, panic-in-library-code, rawloginlib,\n //\tregexpcompileinfunction, seenmapbool, sortslice, sprintferrdot, sprintferrorsnew, sprintfbool, sprintfint, ssljson,\n //\tstrconvparseignorederror, stringbytesroundtrip, stringreplaceminusone, stringsconcatloop, stringscountcontains, stringsindexcontains, stringsindexhasprefix, stringsjoinone, timeafterleak, timesleepnocontext, timenowsub,\n-//\ttolowerequalfold, trimleftright, uncheckedtypeassertion, walkfuncerrshadow, wgdonenotdeferred, writebytestring\n+//\ttolowerequalfold, trimleftright, uncheckedflushreturn, uncheckedtypeassertion, walkfuncerrshadow, wgdonenotdeferred, writebytestring\n func documentedAnalyzers() []docAnalyzer {\n \treturn []docAnalyzer{\n \t\t{\"appendbytestring\", appendbytestring.Analyzer},\n@@ -160,6 +161,7 @@ func documentedAnalyzers() []docAnalyzer {\n \t\t{\"tolowerequalfold\", tolowerequalfold.Analyzer},\n \t\t{\"trimleftright\", trimleftright.Analyzer},\n \t\t{\"uncheckedtypeassertion\", uncheckedtypeassertion.Analyzer},\n+\t\t{\"uncheckedflushreturn\", uncheckedflushreturn.Analyzer},\n \t\t{\"walkfuncerrshadow\", walkfuncerrshadow.Analyzer},\n \t\t{\"wgdonenotdeferred\", wgdonenotdeferred.Analyzer},\n \t\t{\"writebytestring\", writebytestring.Analyzer},diff --git a/pkg/linters/uncheckedflushreturn/testdata/src/uncheckedflushreturn/uncheckedflushreturn.go b/pkg/linters/uncheckedflushreturn/testdata/src/uncheckedflushreturn/uncheckedflushreturn.go\nnew file mode 100644\nindex 00000000000..dc6ff53e2a6\n--- /dev/null\n+++ b/pkg/linters/uncheckedflushreturn/testdata/src/uncheckedflushreturn/uncheckedflushreturn.go\n@@ -0,0 +1,46 @@\n+package uncheckedflushreturn\n+\n+import (\n+\t\"bufio\"\n+\t\"strings\"\n+\t\"text/tabwriter\"\n+)\n+\n+func bad() {\n+\tvar sb strings.Builder\n+\tbw := bufio.NewWriter(&sb)\n+\tbw.Flush() // want `error return from Flush\\(\\) is discarded`\n+\n+\ttw := tabwriter.NewWriter(&sb, 0, 0, 1, ' ', 0)\n+\ttw.Flush() // want `error return from Flush\\(\\) is discarded`\n+}\n+\n+func badBlankAssign() {\n+\tvar sb strings.Builder\n+\tbw := bufio.NewWriter(&sb)\n+\t_ = bw.Flush() // want `error return from Flush\\(\\) is discarded`\n+}\n+\n+func good() {\n+\tvar sb strings.Builder\n+\tbw := bufio.NewWriter(&sb)\n+\tif err := bw.Flush(); err != nil {\n+\t\t_ = err\n+\t}\n+\n+\ttw := tabwriter.NewWriter(&sb, 0, 0, 1, ' ', 0)\n+\terr := tw.Flush()\n+\tif err != nil {\n+\t\t_ = err\n+\t}\n+}\n+\n+func suppressed() {\n+\tvar sb strings.Builder\n+\tbw := bufio.NewWriter(&sb)\n+\t//nolint:uncheckedflushreturn\n+\tbw.Flush()\n+\n+\ttw := tabwriter.NewWriter(&sb, 0, 0, 1, ' ', 0)\n+\ttw.Flush() //nolint:uncheckedflushreturn\n+}diff --git a/pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go\nnew file mode 100644\nindex 00000000000..4d40b4460a3\n--- /dev/null\n+++ b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go\n@@ -0,0 +1,136 @@\n+// Package uncheckedflushreturn implements a Go analysis linter that flags\n+// Flush() method calls where the error return is discarded.\n+package uncheckedflushreturn\n+\n+import (\n+\t\"go/ast\"\n+\t\"go/types\"\n+\n+\t\"golang.org/x/tools/go/analysis\"\n+\t\"golang.org/x/tools/go/analysis/passes/inspect\"\n+\n+\t\"github.com/github/gh-aw/pkg/linters/internal/astutil\"\n+\t\"github.com/github/gh-aw/pkg/linters/internal/filecheck\"\n+\t\"github.com/github/gh-aw/pkg/linters/internal/nolint\"\n+\t\"github.com/github/gh-aw/pkg/logger\"\n+)\n+\n+var pkgLog = logger.New(\"linters:uncheckedflushreturn\")\n+\n+// Analyzer is the unchecked-flush-return analysis pass.\n+var Analyzer = &analysis.Analyzer{\n+\tName:     \"uncheckedflushreturn\",\n+\tDoc:      \"reports Flush() method calls where the error return is discarded\",\n+\tURL:      \"https://github.com/github/gh-aw/tree/main/pkg/linters/uncheckedflushreturn\",\n+\tRequires: []*analysis.Analyzer{inspect.Analyzer, nolint.Analyzer, filecheck.Analyzer},\n+\tRun:      run,\n+}\n+\n+func run(pass *analysis.Pass) (any, error) {\n+\tpkgLog.Printf(\"analyzing package %s\", pass.Pkg.Path())\n+\n+\tinsp, err := astutil.Inspector(pass)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tnoLintIndex, err := nolint.Index(pass)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tgeneratedFiles, err := filecheck.Index(pass)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\tnodeFilter := []ast.Node{(*ast.ExprStmt)(nil), (*ast.AssignStmt)(nil)}\n+\tinsp.Preorder(nodeFilter, func(n ast.Node) {\n+\t\tswitch stmt := n.(type) {\n+\t\tcase *ast.ExprStmt:\n+\t\t\tposition := pass.Fset.PositionFor(stmt.Pos(), false)\n+\t\t\tif filecheck.ShouldSkipFilename(position.Filename, generatedFiles) {\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\tcheckDiscardedFlushExpr(pass, stmt, noLintIndex)\n+\t\tcase *ast.AssignStmt:\n+\t\t\tposition := pass.Fset.PositionFor(stmt.Pos(), false)\n+\t\t\tif filecheck.ShouldSkipFilename(position.Filename, generatedFiles) {\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\tcheckDiscardedFlushAssign(pass, stmt, noLintIndex)\n+\t\t}\n+\t})\n+\treturn nil, nil\n+}\n+\n+// checkDiscardedFlushExpr flags Flush() used as a bare expression statement,\n+// where the error return is silently discarded.\n+func checkDiscardedFlushExpr(pass *analysis.Pass, stmt *ast.ExprStmt, noLintIndex nolint.DirectiveIndex) {\n+\tcall, ok := stmt.X.(*ast.CallExpr)\n+\tif !ok {\n+\t\treturn\n+\t}\n+\tif !isFlushCallReturningError(pass, call) {\n+\t\treturn\n+\t}\n+\treportUncheckedFlush(pass, call, noLintIndex)\n+}\n+\n+// checkDiscardedFlushAssign flags _ = x.Flush() assignments where the error\n+// is explicitly thrown away with a blank identifier.\n+func checkDiscardedFlushAssign(pass *analysis.Pass, assign *ast.AssignStmt, noLintIndex nolint.DirectiveIndex) {\n+\tif len(assign.Lhs) != 1 || len(assign.Rhs) != 1 {\n+\t\treturn\n+\t}\n+\tblank, ok := assign.Lhs[0].(*ast.Ident)\n+\tif !ok || blank.Name != \"_\" {\n+\t\treturn\n+\t}\n+\tcall, ok := assign.Rhs[0].(*ast.CallExpr)\n+\tif !ok {\n+\t\treturn\n+\t}\n+\tif !isFlushCallReturningError(pass, call) {\n+\t\treturn\n+\t}\n+\treportUncheckedFlush(pass, call, noLintIndex)\n+}\n+\n+func reportUncheckedFlush(pass *analysis.Pass, call *ast.CallExpr, noLintIndex nolint.DirectiveIndex) {\n+\tposition := pass.Fset.PositionFor(call.Pos(), false)\n+\tif nolint.HasDirectiveForLinter(position, noLintIndex, \"uncheckedflushreturn\") {\n+\t\treturn\n+\t}\n+\tpkgLog.Printf(\"flagging unchecked Flush() error at %s:%d\", position.Filename, position.Line)\n+\tpass.ReportRangef(call, \"error return from Flush() is discarded; flush failures silently drop buffered data\")\n+}\n+\n+// isFlushCallReturningError returns true when call is a method named Flush\n+// that takes no arguments and returns a single error value.\n+func isFlushCallReturningError(pass *analysis.Pass, call *ast.CallExpr) bool {\n+\tsel, ok := call.Fun.(*ast.SelectorExpr)\n+\tif !ok {\n+\t\treturn false\n+\t}\n+\tif sel.Sel.Name != \"Flush\" {\n+\t\treturn false\n+\t}\n+\tif len(call.Args) != 0 {\n+\t\treturn false\n+\t}\n+\tsig, ok := pass.TypesInfo.TypeOf(call.Fun).(*types.Signature)\n+\tif !ok {\n+\t\treturn false\n+\t}\n+\tres := sig.Results()\n+\tif res.Len() != 1 {\n+\t\treturn false\n+\t}\n+\t_, isErr := res.At(0).Type().Underlying().(*types.Interface)\n+\treturn isErr && types.Implements(res.At(0).Type(), errorInterface)\n+}\n+\n+// errorInterface is the built-in error interface type.\n+var errorInterface = func() *types.Interface {\n+\terrorType := types.Universe.Lookup(\"error\").Type()\n+\treturn errorType.Underlying().(*types.Interface)\n+}()diff --git a/pkg/linters/uncheckedflushreturn/uncheckedflushreturn_test.go b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn_test.go\nnew file mode 100644\nindex 00000000000..1298bbc341a\n--- /dev/null\n+++ b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn_test.go\n@@ -0,0 +1,16 @@\n+//go:build !integration\n+\n+package uncheckedflushreturn_test\n+\n+import (\n+\t\"testing\"\n+\n+\t\"golang.org/x/tools/go/analysis/analysistest\"\n+\n+\t\"github.com/github/gh-aw/pkg/linters/uncheckedflushreturn\"\n+)\n+\n+func TestAnalyzer(t *testing.T) {\n+\ttestdata := analysistest.TestData()\n+\tanalysistest.Run(t, testdata, uncheckedflushreturn.Analyzer, \"uncheckedflushreturn\")\n+}\n<shellId: 11 completed with exit code 0>","detailedContent":"diff --git a/linters b/linters\nindex d920e6a6151..5725ab9455a 100755\nBinary files a/linters and b/linters differ\ndiff --git a/pkg/cli/logs_format_compact.go b/pkg/cli/logs_format_compact.go\nindex ae0dac8f09d..05ba00a8012 100644\n--- a/pkg/cli/logs_format_compact.go\n+++ b/pkg/cli/logs_format_compact.go\n@@ -137,7 +137,9 @@ func renderLogsCompactToWriter(w io.Writer, data LogsData) {\n \t\t\tr.TokenUsage, formatCompactAIC(r.AIC), r.Turns, r.ErrorCount,\n \t\t\tr.Event, actor, branch)\n \t}\n-\ttw.Flush()\n+\tif err := tw.Flush(); err != nil {\n+\t\tlogsCompactLog.Printf(\"flush error: %v\", err)\n+\t}\n \n \t// [errors] — aggregated error/warning messages\n \tif len(data.ErrorsAndWarnings) > 0 {\n@@ -317,7 +319,9 @@ func renderLogsCompactVerboseToWriter(w io.Writer, data LogsData) {\n \t\t\tr.Event, actor, tbt, classification,\n \t\t\tr.CreatedAt.Format(\"01-02 15:04\"), r.Branch)\n \t}\n-\ttw.Flush()\n+\tif err := tw.Flush(); err != nil {\n+\t\tlogsCompactLog.Printf(\"flush error: %v\", err)\n+\t}\n \n \t// [errors]\n \tif len(data.ErrorsAndWarnings) > 0 {diff --git a/pkg/linters/README.md b/pkg/linters/README.md\nindex 6ee1ea8b056..836eb89dfdb 100644\n--- a/pkg/linters/README.md\n+++ b/pkg/linters/README.md\n@@ -64,6 +64,7 @@ This package currently provides custom Go analyzers in the following subpackages\n - `tolowerequalfold` — reports case-insensitive string comparisons using `strings.ToLower`/`ToUpper` that should use `strings.EqualFold`.\n - `trimleftright` — reports `strings.TrimLeft`/`TrimRight` calls with a multi-character literal cutset where `TrimPrefix`/`TrimSuffix` was likely intended.\n - `uncheckedtypeassertion` — reports single-value type assertions where unchecked panics are possible.\n+- `uncheckedflushreturn` — reports `Flush()` method calls where the error return is discarded, which silently drops buffered data on failure.\n - `wgdonenotdeferred` — reports non-deferred `sync.WaitGroup.Done()` calls that can deadlock on panics or early returns.\n - `writebytestring` — reports `w.Write([]byte(s))` calls where `s` is a string, which can be replaced with `io.WriteString` to avoid an unnecessary `[]byte` allocation.\n - `internal` — shared helper packages for analyzers (file checks and `nolint` handling).\n@@ -132,6 +133,7 @@ This package currently provides custom Go analyzers in the following subpackages\n | `tolowerequalfold` | Custom `go/analysis` analyzer that flags case-insensitive comparisons via `strings.ToLower`/`ToUpper` that should use `strings.EqualFold` |\n | `trimleftright` | Custom `go/analysis` analyzer that flags `strings.TrimLeft`/`TrimRight` calls with a multi-character literal cutset where `TrimPrefix`/`TrimSuffix` was likely intended |\n | `uncheckedtypeassertion` | Custom `go/analysis` analyzer that flags unchecked single-value type assertions |\n+| `uncheckedflushreturn` | Custom `go/analysis` analyzer that flags `Flush()` method calls where the error return is discarded |\n | `walkfuncerrshadow` | Custom `go/analysis` analyzer that flags `filepath.Walk`/`filepath.WalkDir` callbacks whose `err` parameter shadows an outer `err` variable assigned from the walk call |\n | `wgdonenotdeferred` | Custom `go/analysis` analyzer that flags non-deferred `sync.WaitGroup.Done()` calls |\n | `writebytestring` | Custom `go/analysis` analyzer that flags `w.Write([]byte(s))` calls where `s` is a string that can be replaced with `io.WriteString` |\n@@ -262,6 +264,7 @@ _ = trimleftright.Analyzer\n - `github.com/github/gh-aw/pkg/linters/tolowerequalfold` — to-lower-equal-fold analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/trimleftright` — trim-left-right analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/uncheckedtypeassertion` — unchecked-type-assertion analyzer subpackage\n+- `github.com/github/gh-aw/pkg/linters/uncheckedflushreturn` — unchecked-flush-return analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/walkfuncerrshadow` — walk-func-err-shadow analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/wgdonenotdeferred` — wg-done-not-deferred analyzer subpackage\n - `github.com/github/gh-aw/pkg/linters/writebytestring` — write-byte-string analyzer subpackagediff --git a/pkg/linters/doc.go b/pkg/linters/doc.go\nindex 53ef264705b..3a0f83c8de4 100644\n--- a/pkg/linters/doc.go\n+++ b/pkg/linters/doc.go\n@@ -1,6 +1,6 @@\n // Package linters is a namespace for gh-aw's custom Go analysis linters.\n //\n-// All 61 active analyzers:\n+// All 62 active analyzers:\n //\n //   - appendbytestring — flags append(b, []byte(s)...) calls where s is a string that can be simplified to append(b, s...)\n //   - appendoneelement — flags append(s, []T{x}...) calls where a single-element slice literal is spread and can be simplified to append(s, x)\n@@ -60,6 +60,7 @@\n //   - tolowerequalfold — flags case-insensitive comparisons via ToLower/ToUpper that should use EqualFold\n //   - trimleftright — flags strings.TrimLeft/TrimRight calls with a multi-character literal cutset where TrimPrefix/TrimSuffix was likely intended\n //   - uncheckedtypeassertion — flags unchecked single-value type assertions\n+//   - uncheckedflushreturn — flags Flush() method calls where the error return is discarded\n //   - walkfuncerrshadow — flags filepath.Walk/WalkDir callbacks whose err parameter shadows an outer err variable assigned from the walk call\n //   - wgdonenotdeferred — flags non-deferred sync.WaitGroup.Done() calls\n //   - writebytestring — flags w.Write([]byte(s)) calls where s is a string that can be replaced with io.WriteString(w, s)diff --git a/pkg/linters/registry.go b/pkg/linters/registry.go\nindex f20b15e227d..af0285ac238 100644\n--- a/pkg/linters/registry.go\n+++ b/pkg/linters/registry.go\n@@ -60,6 +60,7 @@ import (\n \t\"github.com/github/gh-aw/pkg/linters/timesleepnocontext\"\n \t\"github.com/github/gh-aw/pkg/linters/tolowerequalfold\"\n \t\"github.com/github/gh-aw/pkg/linters/trimleftright\"\n+\t\"github.com/github/gh-aw/pkg/linters/uncheckedflushreturn\"\n \t\"github.com/github/gh-aw/pkg/linters/uncheckedtypeassertion\"\n \t\"github.com/github/gh-aw/pkg/linters/walkfuncerrshadow\"\n \t\"github.com/github/gh-aw/pkg/linters/wgdonenotdeferred\"\n@@ -134,6 +135,7 @@ var allAnalyzers = []*analysis.Analyzer{\n \ttolowerequalfold.Analyzer,\n \ttrimleftright.Analyzer,\n \tuncheckedtypeassertion.Analyzer,\n+\tuncheckedflushreturn.Analyzer,\n \twalkfuncerrshadow.Analyzer,\n \twgdonenotdeferred.Analyzer,\n \twritebytestring.Analyzer,diff --git a/pkg/linters/spec_test.go b/pkg/linters/spec_test.go\nindex ccac35b7ad2..394b634d283 100644\n--- a/pkg/linters/spec_test.go\n+++ b/pkg/linters/spec_test.go\n@@ -68,6 +68,7 @@ import (\n \t\"github.com/github/gh-aw/pkg/linters/timesleepnocontext\"\n \t\"github.com/github/gh-aw/pkg/linters/tolowerequalfold\"\n \t\"github.com/github/gh-aw/pkg/linters/trimleftright\"\n+\t\"github.com/github/gh-aw/pkg/linters/uncheckedflushreturn\"\n \t\"github.com/github/gh-aw/pkg/linters/uncheckedtypeassertion\"\n \t\"github.com/github/gh-aw/pkg/linters/walkfuncerrshadow\"\n \t\"github.com/github/gh-aw/pkg/linters/wgdonenotdeferred\"\n@@ -87,7 +88,7 @@ type docAnalyzer struct {\n }\n \n // documentedAnalyzers returns the analyzer subpackages documented in the README\n-// \"Public API > Subpackages\" table. The README documents 61 analyzers\n+// \"Public API > Subpackages\" table. The README documents 62 analyzers\n // subpackages (the non-analyzer `internal` helper subpackage is excluded because\n // it exposes no Analyzer).\n //\n@@ -99,7 +100,7 @@ type docAnalyzer struct {\n //\tlogfatallibrary, manualmutexunlock, mapclearloop, mapdeletecheck, nilctxpassed, osexitinlibrary, osgetenvlibrary, ossetenvlibrary, panic-in-library-code, rawloginlib,\n //\tregexpcompileinfunction, seenmapbool, sortslice, sprintferrdot, sprintferrorsnew, sprintfbool, sprintfint, ssljson,\n //\tstrconvparseignorederror, stringbytesroundtrip, stringreplaceminusone, stringsconcatloop, stringscountcontains, stringsindexcontains, stringsindexhasprefix, stringsjoinone, timeafterleak, timesleepnocontext, timenowsub,\n-//\ttolowerequalfold, trimleftright, uncheckedtypeassertion, walkfuncerrshadow, wgdonenotdeferred, writebytestring\n+//\ttolowerequalfold, trimleftright, uncheckedflushreturn, uncheckedtypeassertion, walkfuncerrshadow, wgdonenotdeferred, writebytestring\n func documentedAnalyzers() []docAnalyzer {\n \treturn []docAnalyzer{\n \t\t{\"appendbytestring\", appendbytestring.Analyzer},\n@@ -160,6 +161,7 @@ func documentedAnalyzers() []docAnalyzer {\n \t\t{\"tolowerequalfold\", tolowerequalfold.Analyzer},\n \t\t{\"trimleftright\", trimleftright.Analyzer},\n \t\t{\"uncheckedtypeassertion\", uncheckedtypeassertion.Analyzer},\n+\t\t{\"uncheckedflushreturn\", uncheckedflushreturn.Analyzer},\n \t\t{\"walkfuncerrshadow\", walkfuncerrshadow.Analyzer},\n \t\t{\"wgdonenotdeferred\", wgdonenotdeferred.Analyzer},\n \t\t{\"writebytestring\", writebytestring.Analyzer},diff --git a/pkg/linters/uncheckedflushreturn/testdata/src/uncheckedflushreturn/uncheckedflushreturn.go b/pkg/linters/uncheckedflushreturn/testdata/src/uncheckedflushreturn/uncheckedflushreturn.go\nnew file mode 100644\nindex 00000000000..dc6ff53e2a6\n--- /dev/null\n+++ b/pkg/linters/uncheckedflushreturn/testdata/src/uncheckedflushreturn/uncheckedflushreturn.go\n@@ -0,0 +1,46 @@\n+package uncheckedflushreturn\n+\n+import (\n+\t\"bufio\"\n+\t\"strings\"\n+\t\"text/tabwriter\"\n+)\n+\n+func bad() {\n+\tvar sb strings.Builder\n+\tbw := bufio.NewWriter(&sb)\n+\tbw.Flush() // want `error return from Flush\\(\\) is discarded`\n+\n+\ttw := tabwriter.NewWriter(&sb, 0, 0, 1, ' ', 0)\n+\ttw.Flush() // want `error return from Flush\\(\\) is discarded`\n+}\n+\n+func badBlankAssign() {\n+\tvar sb strings.Builder\n+\tbw := bufio.NewWriter(&sb)\n+\t_ = bw.Flush() // want `error return from Flush\\(\\) is discarded`\n+}\n+\n+func good() {\n+\tvar sb strings.Builder\n+\tbw := bufio.NewWriter(&sb)\n+\tif err := bw.Flush(); err != nil {\n+\t\t_ = err\n+\t}\n+\n+\ttw := tabwriter.NewWriter(&sb, 0, 0, 1, ' ', 0)\n+\terr := tw.Flush()\n+\tif err != nil {\n+\t\t_ = err\n+\t}\n+}\n+\n+func suppressed() {\n+\tvar sb strings.Builder\n+\tbw := bufio.NewWriter(&sb)\n+\t//nolint:uncheckedflushreturn\n+\tbw.Flush()\n+\n+\ttw := tabwriter.NewWriter(&sb, 0, 0, 1, ' ', 0)\n+\ttw.Flush() //nolint:uncheckedflushreturn\n+}diff --git a/pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go\nnew file mode 100644\nindex 00000000000..4d40b4460a3\n--- /dev/null\n+++ b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go\n@@ -0,0 +1,136 @@\n+// Package uncheckedflushreturn implements a Go analysis linter that flags\n+// Flush() method calls where the error return is discarded.\n+package uncheckedflushreturn\n+\n+import (\n+\t\"go/ast\"\n+\t\"go/types\"\n+\n+\t\"golang.org/x/tools/go/analysis\"\n+\t\"golang.org/x/tools/go/analysis/passes/inspect\"\n+\n+\t\"github.com/github/gh-aw/pkg/linters/internal/astutil\"\n+\t\"github.com/github/gh-aw/pkg/linters/internal/filecheck\"\n+\t\"github.com/github/gh-aw/pkg/linters/internal/nolint\"\n+\t\"github.com/github/gh-aw/pkg/logger\"\n+)\n+\n+var pkgLog = logger.New(\"linters:uncheckedflushreturn\")\n+\n+// Analyzer is the unchecked-flush-return analysis pass.\n+var Analyzer = &analysis.Analyzer{\n+\tName:     \"uncheckedflushreturn\",\n+\tDoc:      \"reports Flush() method calls where the error return is discarded\",\n+\tURL:      \"https://github.com/github/gh-aw/tree/main/pkg/linters/uncheckedflushreturn\",\n+\tRequires: []*analysis.Analyzer{inspect.Analyzer, nolint.Analyzer, filecheck.Analyzer},\n+\tRun:      run,\n+}\n+\n+func run(pass *analysis.Pass) (any, error) {\n+\tpkgLog.Printf(\"analyzing package %s\", pass.Pkg.Path())\n+\n+\tinsp, err := astutil.Inspector(pass)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tnoLintIndex, err := nolint.Index(pass)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tgeneratedFiles, err := filecheck.Index(pass)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\tnodeFilter := []ast.Node{(*ast.ExprStmt)(nil), (*ast.AssignStmt)(nil)}\n+\tinsp.Preorder(nodeFilter, func(n ast.Node) {\n+\t\tswitch stmt := n.(type) {\n+\t\tcase *ast.ExprStmt:\n+\t\t\tposition := pass.Fset.PositionFor(stmt.Pos(), false)\n+\t\t\tif filecheck.ShouldSkipFilename(position.Filename, generatedFiles) {\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\tcheckDiscardedFlushExpr(pass, stmt, noLintIndex)\n+\t\tcase *ast.AssignStmt:\n+\t\t\tposition := pass.Fset.PositionFor(stmt.Pos(), false)\n+\t\t\tif filecheck.ShouldSkipFilename(position.Filename, generatedFiles) {\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\tcheckDiscardedFlushAssign(pass, stmt, noLintIndex)\n+\t\t}\n+\t})\n+\treturn nil, nil\n+}\n+\n+// checkDiscardedFlushExpr flags Flush() used as a bare expression statement,\n+// where the error return is silently discarded.\n+func checkDiscardedFlushExpr(pass *analysis.Pass, stmt *ast.ExprStmt, noLintIndex nolint.DirectiveIndex) {\n+\tcall, ok := stmt.X.(*ast.CallExpr)\n+\tif !ok {\n+\t\treturn\n+\t}\n+\tif !isFlushCallReturningError(pass, call) {\n+\t\treturn\n+\t}\n+\treportUncheckedFlush(pass, call, noLintIndex)\n+}\n+\n+// checkDiscardedFlushAssign flags _ = x.Flush() assignments where the error\n+// is explicitly thrown away with a blank identifier.\n+func checkDiscardedFlushAssign(pass *analysis.Pass, assign *ast.AssignStmt, noLintIndex nolint.DirectiveIndex) {\n+\tif len(assign.Lhs) != 1 || len(assign.Rhs) != 1 {\n+\t\treturn\n+\t}\n+\tblank, ok := assign.Lhs[0].(*ast.Ident)\n+\tif !ok || blank.Name != \"_\" {\n+\t\treturn\n+\t}\n+\tcall, ok := assign.Rhs[0].(*ast.CallExpr)\n+\tif !ok {\n+\t\treturn\n+\t}\n+\tif !isFlushCallReturningError(pass, call) {\n+\t\treturn\n+\t}\n+\treportUncheckedFlush(pass, call, noLintIndex)\n+}\n+\n+func reportUncheckedFlush(pass *analysis.Pass, call *ast.CallExpr, noLintIndex nolint.DirectiveIndex) {\n+\tposition := pass.Fset.PositionFor(call.Pos(), false)\n+\tif nolint.HasDirectiveForLinter(position, noLintIndex, \"uncheckedflushreturn\") {\n+\t\treturn\n+\t}\n+\tpkgLog.Printf(\"flagging unchecked Flush() error at %s:%d\", position.Filename, position.Line)\n+\tpass.ReportRangef(call, \"error return from Flush() is discarded; flush failures silently drop buffered data\")\n+}\n+\n+// isFlushCallReturningError returns true when call is a method named Flush\n+// that takes no arguments and returns a single error value.\n+func isFlushCallReturningError(pass *analysis.Pass, call *ast.CallExpr) bool {\n+\tsel, ok := call.Fun.(*ast.SelectorExpr)\n+\tif !ok {\n+\t\treturn false\n+\t}\n+\tif sel.Sel.Name != \"Flush\" {\n+\t\treturn false\n+\t}\n+\tif len(call.Args) != 0 {\n+\t\treturn false\n+\t}\n+\tsig, ok := pass.TypesInfo.TypeOf(call.Fun).(*types.Signature)\n+\tif !ok {\n+\t\treturn false\n+\t}\n+\tres := sig.Results()\n+\tif res.Len() != 1 {\n+\t\treturn false\n+\t}\n+\t_, isErr := res.At(0).Type().Underlying().(*types.Interface)\n+\treturn isErr && types.Implements(res.At(0).Type(), errorInterface)\n+}\n+\n+// errorInterface is the built-in error interface type.\n+var errorInterface = func() *types.Interface {\n+\terrorType := types.Universe.Lookup(\"error\").Type()\n+\treturn errorType.Underlying().(*types.Interface)\n+}()diff --git a/pkg/linters/uncheckedflushreturn/uncheckedflushreturn_test.go b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn_test.go\nnew file mode 100644\nindex 00000000000..1298bbc341a\n--- /dev/null\n+++ b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn_test.go\n@@ -0,0 +1,16 @@\n+//go:build !integration\n+\n+package uncheckedflushreturn_test\n+\n+import (\n+\t\"testing\"\n+\n+\t\"golang.org/x/tools/go/analysis/analysistest\"\n+\n+\t\"github.com/github/gh-aw/pkg/linters/uncheckedflushreturn\"\n+)\n+\n+func TestAnalyzer(t *testing.T) {\n+\ttestdata := analysistest.TestData()\n+\tanalysistest.Run(t, testdata, uncheckedflushreturn.Analyzer, \"uncheckedflushreturn\")\n+}\n<shellId: 11 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-02T22:44:25.847Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-02T22:44:25.850Z","data":{"toolName":"task","mcpServerName":""}}
{"type":"subagent.started","timestamp":"2026-08-02T22:44:25.861Z","data":{"agentName":"general-purpose","agentDisplayName":"General Purpose Agent","toolCallId":"toolu_01JvJ94nm9o6LvnS5URp4WHc"}}
{"type":"tool.execution_complete","timestamp":"2026-08-02T22:44:25.869Z","data":{"toolName":"task","mcpServerName":"","success":true,"result":{"content":"Agent started in background with agent_id: grumpy-coder-3. You'll be notified when it completes. Tell the user you're waiting and end your response, or continue unrelated work until notified. The agent supports multi-turn conversations — use write_agent to send follow-up messages.","detailedContent":"Prompt to general-purpose agent (grumpy-coder-3):\nYou are a extremely critical, grumpy senior Go code reviewer doing first-pass issue mining on a pull request diff. Do NOT be nice. Find every plausible correctness bug, missed edge case, false negative/false positive in a static analyzer, concurrency issue, performance issue, or maintainability issue in the following diff. Only comment on lines that are actually changed/added in the diff (ignore unchanged context lines and binary file changes).\n\nThe PR adds a new go/analysis linter `uncheckedflushreturn` that flags `Flush()` calls whose `error` return is discarded, and fixes two call sites in pkg/cli/logs_format_compact.go.\n\nOutput STRICT JSONL only — one JSON object per line, no markdown, no prose before/after. Each line must have exactly these fields:\n{\"file\": \"<path>\", \"line\": <int line number in the new file version>, \"severity\": \"critical|high|medium|low\", \"issue\": \"<short title>\", \"explanation\": \"<why it matters>\"}\n\nHere is the full diff:\n\n```diff\ndiff --git a/pkg/cli/logs_format_compact.go b/pkg/cli/logs_format_compact.go\nindex ae0dac8f09d..05ba00a8012 100644\n--- a/pkg/cli/logs_format_compact.go\n+++ b/pkg/cli/logs_format_compact.go\n@@ -137,7 +137,9 @@ func renderLogsCompactToWriter(w io.Writer, data LogsData) {\n \t\t\tr.TokenUsage, formatCompactAIC(r.AIC), r.Turns, r.ErrorCount,\n \t\t\tr.Event, actor, branch)\n \t}\n-\ttw.Flush()\n+\tif err := tw.Flush(); err != nil {\n+\t\tlogsCompactLog.Printf(\"flush error: %v\", err)\n+\t}\n \n \t// [errors] — aggregated error/warning messages\n \tif len(data.ErrorsAndWarnings) > 0 {\n@@ -317,7 +319,9 @@ func renderLogsCompactVerboseToWriter(w io.Writer, data LogsData) {\n \t\t\tr.Event, actor, tbt, classification,\n \t\t\tr.CreatedAt.Format(\"01-02 15:04\"), r.Branch)\n \t}\n-\ttw.Flush()\n+\tif err := tw.Flush(); err != nil {\n+\t\tlogsCompactLog.Printf(\"flush error: %v\", err)\n+\t}\n \n \t// [errors]\n \tif len(data.ErrorsAndWarnings) > 0 {\ndiff --git a/pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go\nnew file mode 100644\nindex 00000000000..4d40b4460a3\n--- /dev/null\n+++ b/pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go\n@@ -0,0 +1,136 @@\n+// Package uncheckedflushreturn implements a Go analysis linter that flags\n+// Flush() method calls where the error return is discarded.\n+package uncheckedflushreturn\n+\n+import (\n+\t\"go/ast\"\n+\t\"go/types\"\n+\n+\t\"golang.org/x/tools/go/analysis\"\n+\t\"golang.org/x/tools/go/analysis/passes/inspect\"\n+\n+\t\"github.com/github/gh-aw/pkg/linters/internal/astutil\"\n+\t\"github.com/github/gh-aw/pkg/linters/internal/filecheck\"\n+\t\"github.com/github/gh-aw/pkg/linters/internal/nolint\"\n+\t\"github.com/github/gh-aw/pkg/logger\"\n+)\n+\n+var pkgLog = logger.New(\"linters:uncheckedflushreturn\")\n+\n+// Analyzer is the unchecked-flush-return analysis pass.\n+var Analyzer = &analysis.Analyzer{\n+\tName:     \"uncheckedflushreturn\",\n+\tDoc:      \"reports Flush() method calls where the error return is discarded\",\n+\tURL:      \"https://github.com/github/gh-aw/tree/main/pkg/linters/uncheckedflushreturn\",\n+\tRequires: []*analysis.Analyzer{inspect.Analyzer, nolint.Analyzer, filecheck.Analyzer},\n+\tRun:      run,\n+}\n+\n+func run(pass *analysis.Pass) (any, error) {\n+\tpkgLog.Printf(\"analyzing package %s\", pass.Pkg.Path())\n+\n+\tinsp, err := astutil.Inspector(pass)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tnoLintIndex, err := nolint.Index(pass)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tgeneratedFiles, err := filecheck.Index(pass)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\tnodeFilter := []ast.Node{(*ast.ExprStmt)(nil), (*ast.AssignStmt)(nil)}\n+\tinsp.Preorder(nodeFilter, func(n ast.Node) {\n+\t\tswitch stmt := n.(type) {\n+\t\tcase *ast.ExprStmt:\n+\t\t\tposition := pass.Fset.PositionFor(stmt.Pos(), false)\n+\t\t\tif filecheck.ShouldSkipFilename(position.Filename, generatedFiles) {\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\tcheckDiscardedFlushExpr(pass, stmt, noLintIndex)\n+\t\tcase *ast.AssignStmt:\n+\t\t\tposition := pass.Fset.PositionFor(stmt.Pos(), false)\n+\t\t\tif filecheck.ShouldSkipFilename(position.Filename, generatedFiles) {\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\tcheckDiscardedFlushAssign(pass, stmt, noLintIndex)\n+\t\t}\n+\t})\n+\treturn nil, nil\n+}\n+\n+// checkDiscardedFlushExpr flags Flush() used as a bare expression statement,\n+// where the error return is silently discarded.\n+func checkDiscardedFlushExpr(pass *analysis.Pass, stmt *ast.ExprStmt, noLintIndex nolint.DirectiveIndex) {\n+\tcall, ok := stmt.X.(*ast.CallExpr)\n+\tif !ok {\n+\t\treturn\n+\t}\n+\tif !isFlushCallReturningError(pass, call) {\n+\t\treturn\n+\t}\n+\treportUncheckedFlush(pass, call, noLintIndex)\n+}\n+\n+// checkDiscardedFlushAssign flags _ = x.Flush() assignments where the error\n+// is explicitly thrown away with a blank identifier.\n+func checkDiscardedFlushAssign(pass *analysis.Pass, assign *ast.AssignStmt, noLintIndex nolint.DirectiveIndex) {\n+\tif len(assign.Lhs) != 1 || len(assign.Rhs) != 1 {\n+\t\treturn\n+\t}\n+\tblank, ok := assign.Lhs[0].(*ast.Ident)\n+\tif !ok || blank.Name != \"_\" {\n+\t\treturn\n+\t}\n+\tcall, ok := assign.Rhs[0].(*ast.CallExpr)\n+\tif !ok {\n+\t\treturn\n+\t}\n+\tif !isFlushCallReturningError(pass, call) {\n+\t\treturn\n+\t}\n+\treportUncheckedFlush(pass, call, noLintIndex)\n+}\n+\n+func reportUncheckedFlush(pass *analysis.Pass, call *ast.CallExpr, noLintIndex nolint.DirectiveIndex) {\n+\tposition := pass.Fset.PositionFor(call.Pos(), false)\n+\tif nolint.HasDirectiveForLinter(position, noLintIndex, \"uncheckedflushreturn\") {\n+\t\treturn\n+\t}\n+\tpkgLog.Printf(\"flagging unchecked Flush() error at %s:%d\", position.Filename, position.Line)\n+\tpass.ReportRangef(call, \"error return from Flush() is discarded; flush failures silently drop buffered data\")\n+}\n+\n+// isFlushCallReturningError returns true when call is a method named Flush\n+// that takes no arguments and returns a single error value.\n+func isFlushCallReturningError(pass *analysis.Pass, call *ast.CallExpr) bool {\n+\tsel, ok := call.Fun.(*ast.SelectorExpr)\n+\tif !ok {\n+\t\treturn false\n+\t}\n+\tif sel.Sel.Name != \"Flush\" {\n+\t\treturn false\n+\t}\n+\tif len(call.Args) != 0 {\n+\t\treturn false\n+\t}\n+\tsig, ok := pass.TypesInfo.TypeOf(call.Fun).(*types.Signature)\n+\tif !ok {\n+\t\treturn false\n+\t}\n+\tres := sig.Results()\n+\tif res.Len() != 1 {\n+\t\treturn false\n+\t}\n+\t_, isErr := res.At(0).Type().Underlying().(*types.Interface)\n+\treturn isErr && types.Implements(res.At(0).Type(), errorInterface)\n+}\n+\n+// errorInterface is the built-in error interface type.\n+var errorInterface = func() *types.Interface {\n+\terrorType := types.Universe.Lookup(\"error\").Type()\n+\treturn errorType.Underlying().(*types.Interface)\n+}()\n```\n\nNote the analyzer only registers a node filter for `*ast.ExprStmt` and `*ast.AssignStmt` — think hard about whether `defer tw.Flush()`, goroutine `go tw.Flush()`, or Flush calls inside `select`/other statement forms are handled or missed, and whether that's a meaningful false-negative gap given Flush-in-defer is an extremely common real-world pattern. Also scrutinize the `isFlushCallReturningError` type-checking logic for correctness, and the error-handling additions in logs_format_compact.go (e.g., is logging sufficient, is there a risk the error is silently swallowed in a way that matters, is the variable name `logsCompactLog` correct/consistent). Report every issue you find, even minor ones — output nothing except the JSONL lines described above."}}}
[copilot-sdk-driver] [sdk-driver] error: Execution failed: Error: No model available. Check policy enablement under GitHub Settings > Copilot
{"type":"subagent.completed","timestamp":"2026-08-02T22:44:25.920Z","data":{"agentName":"general-purpose","toolCallId":"toolu_01JvJ94nm9o6LvnS5URp4WHc"}}

Action Required

Assign this issue to an agent to debug and fix the issue.

Debug with any coding agent

Use this prompt with any coding agent (GitHub Copilot, Claude, Gemini, etc.):

Debug the agentic workflow failure using https://raw.githubusercontent.com/github/gh-aw/main/debug.md

The failed workflow run is at https://github.com/github/gh-aw/actions/runs/30770509772

Manually invoke the agent

Debug this workflow failure using your favorite Agent CLI and the agentic-workflows prompt.

• Start your agent
• Load the agentic-workflows skill from .github/skills/agentic-workflows/SKILL.md or https://github.com/github/gh-aw/blob/main/.github/skills/agentic-workflows/SKILL.md
• Type debug the agentic workflow pr-code-quality-reviewer failure in https://github.com/github/gh-aw/actions/runs/30770509772

Tip

Stop reporting this workflow as a failure

To stop a workflow from creating failure issues, set report-failure-as-issue: false in its frontmatter:

safe-outputs:
  report-failure-as-issue: false

Generated from PR Code Quality Reviewer · 64.7 AIC · ◷

• expires on Aug 3, 2026, 10:47 AM UTC

[github-actions]

Agent job 30770949091 failed.

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

{"type":"tool.execution_complete","timestamp":"2026-08-02T22:56:52.083Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"134:\t\treturn strings.Contains(content, fmt.Sprintf(\"needs.%s.\", jobName))\n135-\t})\n136-\tsort.Strings(refs)\n<shellId: 18 completed with exit code 0>","detailedContent":"134:\t\treturn strings.Contains(content, fmt.Sprintf(\"needs.%s.\", jobName))\n135-\t})\n136-\tsort.Strings(refs)\n<shellId: 18 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-02T22:57:03.511Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-02T22:57:03.514Z","data":{"toolName":"bash","mcpServerName":"","command":"cd /home/runner/work/gh-aw/gh-aw && go build ./... 2>&1 | head -50 && go test ./pkg/workflow/ -run 'TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences|TestGetCustomJobsDependingOnPreActivation' -v 2>&1 | tail -80"}}
{"type":"tool.execution_complete","timestamp":"2026-08-02T22:57:55.365Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"go: downloading go1.26.5 (linux/amd64)\ngo: downloading golang.org/x/tools v0.48.0\ngo: downloading github.com/spf13/cobra v1.10.2\ngo: downloading github.com/charmbracelet/colorprofile v0.4.3\ngo: downloading github.com/cli/go-gh/v2 v2.13.0\ngo: downloading charm.land/bubbles/v2 v2.1.1\ngo: downloading charm.land/bubbletea/v2 v2.0.8\ngo: downloading charm.land/huh/v2 v2.0.3\ngo: downloading charm.land/lipgloss/v2 v2.0.5\ngo: downloading golang.org/x/mod v0.38.0\ngo: downloading github.com/charmbracelet/x/term v0.2.2\ngo: downloading golang.org/x/term v0.45.0\ngo: downloading github.com/goccy/go-yaml v1.19.2\ngo: downloading github.com/modelcontextprotocol/go-sdk v1.7.0\ngo: downloading github.com/santhosh-tekuri/jsonschema/v6 v6.0.2\ngo: downloading golang.org/x/sync v0.22.0\ngo: downloading github.com/fsnotify/fsnotify v1.10.1\ngo: downloading github.com/google/jsonschema-go v0.4.3\ngo: downloading github.com/sourcegraph/conc v0.3.0\ngo: downloading golang.org/x/crypto v0.54.0\ngo: downloading gopkg.in/yaml.v3 v3.0.1\ngo: downloading github.com/charmbracelet/x/ansi v0.11.7\ngo: downloading github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e\ngo: downloading github.com/cli/shurcooL-graphql v0.0.4\ngo: downloading github.com/henvic/httpretty v0.1.4\ngo: downloading github.com/thlib/go-timezone-local v0.0.7\ngo: downloading golang.org/x/text v0.40.0\ngo: downloading github.com/spf13/pflag v1.0.10\ngo: downloading github.com/charmbracelet/ultraviolet v0.0.0-20260703014108-f5a850f9c2b7\ngo: downloading github.com/lucasb-eyer/go-colorful v1.4.0\ngo: downloading github.com/muesli/cancelreader v0.2.2\ngo: downloading golang.org/x/sys v0.47.0\ngo: downloading github.com/catppuccin/go v0.3.0\ngo: downloading github.com/charmbracelet/x/exp/ordered v0.1.0\ngo: downloading github.com/charmbracelet/x/exp/strings v0.0.0-20251106172358-54469c29c2bc\ngo: downloading github.com/mitchellh/hashstructure/v2 v2.0.2\ngo: downloading github.com/clipperhouse/displaywidth v0.11.0\ngo: downloading github.com/rivo/uniseg v0.4.7\ngo: downloading github.com/charmbracelet/harmonica v0.2.0\ngo: downloading github.com/yosida95/uritemplate/v3 v3.0.2\ngo: downloading golang.org/x/oauth2 v0.36.0\ngo: downloading golang.org/x/time v0.15.0\ngo: downloading github.com/cli/safeexec v1.0.1\ngo: downloading github.com/muesli/termenv v0.16.0\ngo: downloading github.com/clipperhouse/uax29/v2 v2.7.0\ngo: downloading github.com/mattn/go-runewidth v0.0.24\ngo: downloading github.com/charmbracelet/x/termios v0.1.1\ngo: downloading github.com/charmbracelet/x/windows v0.2.2\ngo: downloading github.com/dustin/go-humanize v1.0.1\ngo: downloading github.com/atotto/clipboard v0.1.4\ngo: downloading github.com/charmbracelet/x/exp/golden v0.0.0-20260727090823-41c9e6be3365\ngo: downloading github.com/stretchr/testify v1.11.1\ngo: downloading go.uber.org/goleak v1.3.0\ngo: downloading github.com/aymanbagabas/go-udiff v0.4.1\ngo: downloading github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc\ngo: downloading github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2\ngo: downloading github.com/aymanbagabas/go-osc52/v2 v2.0.1\ngo: downloading github.com/mattn/go-isatty v0.0.20\ngo: downloading github.com/segmentio/encoding v0.5.4\ngo: downloading github.com/segmentio/asm v1.1.3\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_adds_custom_job_to_activation_needs_without_pre_activation\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_with_case()_expression_adds_custom_job_to_activation_needs\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_adds_custom_job_to_activation_needs_with_pre_activation\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_with_no_needs_references_does_not_add_extra_deps\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_to_non-custom_(built-in)_job_is_not_added_to_activation_needs\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/nil_engine.env_does_not_panic\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/job_already_in_customJobsBeforeActivation_is_not_duplicated\n--- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences (0.01s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_adds_custom_job_to_activation_needs_without_pre_activation (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_with_case()_expression_adds_custom_job_to_activation_needs (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_adds_custom_job_to_activation_needs_with_pre_activation (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_with_no_needs_references_does_not_add_extra_deps (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_to_non-custom_(built-in)_job_is_not_added_to_activation_needs (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/nil_engine.env_does_not_panic (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/job_already_in_customJobsBeforeActivation_is_not_duplicated (0.00s)\n=== RUN   TestGetCustomJobsDependingOnPreActivationEdgeCases\n=== RUN   TestGetCustomJobsDependingOnPreActivationEdgeCases/job_with_invalid_config_type\n--- PASS: TestGetCustomJobsDependingOnPreActivationEdgeCases (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationEdgeCases/job_with_invalid_config_type (0.00s)\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_both_pre_activation_and_activation_is_excluded\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_only_pre_activation_is_included\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/mixed:_pre_activation-only_included,_pre_activation+activation_excluded\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_only_activation_dependency_is_excluded\n--- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_both_pre_activation_and_activation_is_excluded (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_only_pre_activation_is_included (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/mixed:_pre_activation-only_included,_pre_activation+activation_excluded (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_only_activation_dependency_is_excluded (0.00s)\n=== RUN   TestGetCustomJobsDependingOnPreActivation\n=== RUN   TestGetCustomJobsDependingOnPreActivation/nil_custom_jobs\n=== RUN   TestGetCustomJobsDependingOnPreActivation/empty_custom_jobs\n=== RUN   TestGetCustomJobsDependingOnPreActivation/job_with_needs_pre_activation_as_string\n=== RUN   TestGetCustomJobsDependingOnPreActivation/job_with_needs_pre_activation_in_array\n=== RUN   TestGetCustomJobsDependingOnPreActivation/job_without_needs_field\n=== RUN   TestGetCustomJobsDependingOnPreActivation/job_with_different_needs\n=== RUN   TestGetCustomJobsDependingOnPreActivation/multiple_jobs_mixed\n--- PASS: TestGetCustomJobsDependingOnPreActivation (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/nil_custom_jobs (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/empty_custom_jobs (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/job_with_needs_pre_activation_as_string (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/job_with_needs_pre_activation_in_array (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/job_without_needs_field (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/job_with_different_needs (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/multiple_jobs_mixed (0.00s)\nPASS\nok  \tgithub.com/github/gh-aw/pkg/workflow\t0.109s\n<shellId: 19 completed with exit code 0>","detailedContent":"go: downloading go1.26.5 (linux/amd64)\ngo: downloading golang.org/x/tools v0.48.0\ngo: downloading github.com/spf13/cobra v1.10.2\ngo: downloading github.com/charmbracelet/colorprofile v0.4.3\ngo: downloading github.com/cli/go-gh/v2 v2.13.0\ngo: downloading charm.land/bubbles/v2 v2.1.1\ngo: downloading charm.land/bubbletea/v2 v2.0.8\ngo: downloading charm.land/huh/v2 v2.0.3\ngo: downloading charm.land/lipgloss/v2 v2.0.5\ngo: downloading golang.org/x/mod v0.38.0\ngo: downloading github.com/charmbracelet/x/term v0.2.2\ngo: downloading golang.org/x/term v0.45.0\ngo: downloading github.com/goccy/go-yaml v1.19.2\ngo: downloading github.com/modelcontextprotocol/go-sdk v1.7.0\ngo: downloading github.com/santhosh-tekuri/jsonschema/v6 v6.0.2\ngo: downloading golang.org/x/sync v0.22.0\ngo: downloading github.com/fsnotify/fsnotify v1.10.1\ngo: downloading github.com/google/jsonschema-go v0.4.3\ngo: downloading github.com/sourcegraph/conc v0.3.0\ngo: downloading golang.org/x/crypto v0.54.0\ngo: downloading gopkg.in/yaml.v3 v3.0.1\ngo: downloading github.com/charmbracelet/x/ansi v0.11.7\ngo: downloading github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e\ngo: downloading github.com/cli/shurcooL-graphql v0.0.4\ngo: downloading github.com/henvic/httpretty v0.1.4\ngo: downloading github.com/thlib/go-timezone-local v0.0.7\ngo: downloading golang.org/x/text v0.40.0\ngo: downloading github.com/spf13/pflag v1.0.10\ngo: downloading github.com/charmbracelet/ultraviolet v0.0.0-20260703014108-f5a850f9c2b7\ngo: downloading github.com/lucasb-eyer/go-colorful v1.4.0\ngo: downloading github.com/muesli/cancelreader v0.2.2\ngo: downloading golang.org/x/sys v0.47.0\ngo: downloading github.com/catppuccin/go v0.3.0\ngo: downloading github.com/charmbracelet/x/exp/ordered v0.1.0\ngo: downloading github.com/charmbracelet/x/exp/strings v0.0.0-20251106172358-54469c29c2bc\ngo: downloading github.com/mitchellh/hashstructure/v2 v2.0.2\ngo: downloading github.com/clipperhouse/displaywidth v0.11.0\ngo: downloading github.com/rivo/uniseg v0.4.7\ngo: downloading github.com/charmbracelet/harmonica v0.2.0\ngo: downloading github.com/yosida95/uritemplate/v3 v3.0.2\ngo: downloading golang.org/x/oauth2 v0.36.0\ngo: downloading golang.org/x/time v0.15.0\ngo: downloading github.com/cli/safeexec v1.0.1\ngo: downloading github.com/muesli/termenv v0.16.0\ngo: downloading github.com/clipperhouse/uax29/v2 v2.7.0\ngo: downloading github.com/mattn/go-runewidth v0.0.24\ngo: downloading github.com/charmbracelet/x/termios v0.1.1\ngo: downloading github.com/charmbracelet/x/windows v0.2.2\ngo: downloading github.com/dustin/go-humanize v1.0.1\ngo: downloading github.com/atotto/clipboard v0.1.4\ngo: downloading github.com/charmbracelet/x/exp/golden v0.0.0-20260727090823-41c9e6be3365\ngo: downloading github.com/stretchr/testify v1.11.1\ngo: downloading go.uber.org/goleak v1.3.0\ngo: downloading github.com/aymanbagabas/go-udiff v0.4.1\ngo: downloading github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc\ngo: downloading github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2\ngo: downloading github.com/aymanbagabas/go-osc52/v2 v2.0.1\ngo: downloading github.com/mattn/go-isatty v0.0.20\ngo: downloading github.com/segmentio/encoding v0.5.4\ngo: downloading github.com/segmentio/asm v1.1.3\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_adds_custom_job_to_activation_needs_without_pre_activation\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_with_case()_expression_adds_custom_job_to_activation_needs\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_adds_custom_job_to_activation_needs_with_pre_activation\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_with_no_needs_references_does_not_add_extra_deps\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_to_non-custom_(built-in)_job_is_not_added_to_activation_needs\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/nil_engine.env_does_not_panic\n=== RUN   TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/job_already_in_customJobsBeforeActivation_is_not_duplicated\n--- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences (0.01s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_adds_custom_job_to_activation_needs_without_pre_activation (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_with_case()_expression_adds_custom_job_to_activation_needs (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_adds_custom_job_to_activation_needs_with_pre_activation (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_with_no_needs_references_does_not_add_extra_deps (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/engine.env_reference_to_non-custom_(built-in)_job_is_not_added_to_activation_needs (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/nil_engine.env_does_not_panic (0.00s)\n    --- PASS: TestConfigureActivationNeedsAndCondition_EngineEnvJobReferences/job_already_in_customJobsBeforeActivation_is_not_duplicated (0.00s)\n=== RUN   TestGetCustomJobsDependingOnPreActivationEdgeCases\n=== RUN   TestGetCustomJobsDependingOnPreActivationEdgeCases/job_with_invalid_config_type\n--- PASS: TestGetCustomJobsDependingOnPreActivationEdgeCases (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationEdgeCases/job_with_invalid_config_type (0.00s)\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_both_pre_activation_and_activation_is_excluded\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_only_pre_activation_is_included\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/mixed:_pre_activation-only_included,_pre_activation+activation_excluded\n=== RUN   TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_only_activation_dependency_is_excluded\n--- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_both_pre_activation_and_activation_is_excluded (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_only_pre_activation_is_included (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/mixed:_pre_activation-only_included,_pre_activation+activation_excluded (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivationExcludesActivationDependents/job_with_only_activation_dependency_is_excluded (0.00s)\n=== RUN   TestGetCustomJobsDependingOnPreActivation\n=== RUN   TestGetCustomJobsDependingOnPreActivation/nil_custom_jobs\n=== RUN   TestGetCustomJobsDependingOnPreActivation/empty_custom_jobs\n=== RUN   TestGetCustomJobsDependingOnPreActivation/job_with_needs_pre_activation_as_string\n=== RUN   TestGetCustomJobsDependingOnPreActivation/job_with_needs_pre_activation_in_array\n=== RUN   TestGetCustomJobsDependingOnPreActivation/job_without_needs_field\n=== RUN   TestGetCustomJobsDependingOnPreActivation/job_with_different_needs\n=== RUN   TestGetCustomJobsDependingOnPreActivation/multiple_jobs_mixed\n--- PASS: TestGetCustomJobsDependingOnPreActivation (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/nil_custom_jobs (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/empty_custom_jobs (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/job_with_needs_pre_activation_as_string (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/job_with_needs_pre_activation_in_array (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/job_without_needs_field (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/job_with_different_needs (0.00s)\n    --- PASS: TestGetCustomJobsDependingOnPreActivation/multiple_jobs_mixed (0.00s)\nPASS\nok  \tgithub.com/github/gh-aw/pkg/workflow\t0.109s\n<shellId: 19 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-02T22:58:23.412Z","data":{"content":"Build passes, tests pass. Now let me analyze for real issues."}}
{"type":"tool.execution_start","timestamp":"2026-08-02T22:58:23.414Z","data":{"toolName":"task","mcpServerName":""}}
{"type":"subagent.started","timestamp":"2026-08-02T22:58:23.430Z","data":{"agentName":"general-purpose","agentDisplayName":"General Purpose Agent","toolCallId":"toolu_01BWvV4qgez3FamqW2pPGCQH"}}
[copilot-sdk-driver] [sdk-driver] error: Execution failed: Error: No model available. Check policy enablement under GitHub Settings > Copilot
{"type":"subagent.completed","timestamp":"2026-08-02T22:58:23.506Z","data":{"agentName":"general-purpose","toolCallId":"toolu_01BWvV4qgez3FamqW2pPGCQH"}}
{"type":"tool.execution_complete","timestamp":"2026-08-02T22:58:23.542Z","data":{"toolName":"task","mcpServerName":"","success":false}}

Generated from PR Code Quality Reviewer · 79.2 AIC · ◷

[github-actions]

Agent job 30770891017 failed.

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

{"type":"tool.execution_complete","timestamp":"2026-08-02T22:59:04.508Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"diff --git a/pkg/workflow/frontmatter_extraction_yaml.go b/pkg/workflow/frontmatter_extraction_yaml.go\nindex 630dc2a396a..d43e6cdcf55 100644\n--- a/pkg/workflow/frontmatter_extraction_yaml.go\n+++ b/pkg/workflow/frontmatter_extraction_yaml.go\n@@ -57,6 +57,13 @@ func (c *Compiler) extractTopLevelYAMLSection(frontmatter map[string]any, key st\n \n \t// Check if value is a map that we should order alphabetically\n \tif valueMap, ok := value.(map[string]any); ok {\n+\t\t// For the \"on\" section, exclude gh-aw-specific keys that are processed\n+\t\t// separately and must not appear in the compiled GitHub Actions workflow.\n+\t\t// The \"needs\" key (on.needs) controls job dependency wiring and is invalid\n+\t\t// as a top-level on: trigger key in GitHub Actions.\n+\t\tif key == \"on\" {\n+\t\t\tvalueMap = excludeMapKeys(valueMap, \"needs\")\n+\t\t}\n \t\t// Use OrderMapFields for alphabetical sorting (empty priority list = all alphabetical)\n \t\torderedValue := OrderMapFields(valueMap, []string{})\n \t\t// Wrap the ordered value with the key using MapSlice\ndiff --git a/pkg/workflow/on_needs_integration_test.go b/pkg/workflow/on_needs_integration_test.go\nindex f6f8ad0962e..7e5554fb9d0 100644\n--- a/pkg/workflow/on_needs_integration_test.go\n+++ b/pkg/workflow/on_needs_integration_test.go\n@@ -5,6 +5,7 @@ package workflow\n import (\n \t\"os\"\n \t\"path/filepath\"\n+\t\"strings\"\n \t\"testing\"\n \n \t\"github.com/github/gh-aw/pkg/testutil\"\n@@ -52,6 +53,15 @@ Run with on.needs\n \tvar lock map[string]any\n \trequire.NoError(t, yaml.Unmarshal(lockBytes, &lock), \"compiled lock file should be valid YAML\")\n \n+\t// Verify on.needs is NOT emitted into the compiled on: section\n+\tonSection, ok := lock[\"on\"].(map[string]any)\n+\trequire.True(t, ok, \"compiled workflow should contain on section\")\n+\tassert.NotContains(t, onSection, \"needs\", \"on.needs must not appear as a key in the compiled on: section\")\n+\n+\t// Verify on.needs is not in the raw compiled text (even as a comment)\n+\tlockContent := string(lockBytes)\n+\tassert.False(t, containsNeedsInOnSection(lockContent), \"on.needs must not appear in the compiled on: section text\")\n+\n \tjobs, ok := lock[\"jobs\"].(map[string]any)\n \trequire.True(t, ok, \"compiled workflow should contain jobs map\")\n \n@@ -63,3 +73,26 @@ Run with on.needs\n \trequire.True(t, ok, \"compiled workflow should contain activation job\")\n \tassert.Contains(t, activation[\"needs\"], \"secrets_fetcher\", \"activation should depend on on.needs job\")\n }\n+\n+// containsNeedsInOnSection checks whether the \"needs:\" key appears in the \"on:\" section\n+// of a compiled workflow YAML string (as a non-comment, non-job-level line).\n+func containsNeedsInOnSection(yamlContent string) bool {\n+\tinOnSection := false\n+\tfor _, line := range strings.Split(yamlContent, \"\\n\") {\n+\t\ttrimmed := strings.TrimLeft(line, \" \\t\")\n+\t\t// Track when we enter/leave the on: section\n+\t\tif trimmed == \"on:\" || strings.HasPrefix(trimmed, `\"on\":`) {\n+\t\t\tinOnSection = true\n+\t\t\tcontinue\n+\t\t}\n+\t\t// Leave on: section when we hit a top-level key\n+\t\tif inOnSection && len(line) > 0 && line[0] != ' ' && line[0] != '\\t' && !strings.HasPrefix(trimmed, \"#\") {\n+\t\t\tinOnSection = false\n+\t\t}\n+\t\t// Check for needs: inside on: section (as a real key, not a job-level needs)\n+\t\tif inOnSection && strings.HasPrefix(trimmed, \"needs:\") && !strings.HasPrefix(trimmed, \"#\") {\n+\t\t\treturn true\n+\t\t}\n+\t}\n+\treturn false\n+}diff --git a/pkg/workflow/yaml_test.go b/pkg/workflow/yaml_test.go\nindex 651e13ff2a8..07834aa4526 100644\n--- a/pkg/workflow/yaml_test.go\n+++ b/pkg/workflow/yaml_test.go\n@@ -400,6 +400,34 @@ func TestMarshalWithFieldOrder_OrdersNestedEnvWithSecretsRecursively(t *testing.\n \tassertOrder(\"    ALPHA_STEP:\", \"    ZETA_STEP:\")\n }\n \n+func TestExtractTopLevelYAMLSectionExcludesOnNeeds(t *testing.T) {\n+\tcompiler := NewCompiler()\n+\n+\tfrontmatter := map[string]any{\n+\t\t\"on\": map[string]any{\n+\t\t\t\"needs\":             []any{\"custom_job\"},\n+\t\t\t\"workflow_dispatch\": nil,\n+\t\t},\n+\t}\n+\n+\tresult := compiler.extractTopLevelYAMLSection(frontmatter, \"on\")\n+\n+\tif strings.Contains(result, \"needs:\") {\n+\t\tt.Errorf(\"on.needs must not appear in compiled on: section, but found it in:\\n%s\", result)\n+\t}\n+\tif !strings.Contains(result, \"workflow_dispatch\") {\n+\t\tt.Errorf(\"workflow_dispatch should be present in the compiled on: section:\\n%s\", result)\n+\t}\n+\t// Verify the original frontmatter[\"on\"] map is not mutated\n+\tonMap, ok := frontmatter[\"on\"].(map[string]any)\n+\tif !ok {\n+\t\tt.Fatal(\"frontmatter[\\\"on\\\"] should remain a map[string]any\")\n+\t}\n+\tif _, hasNeeds := onMap[\"needs\"]; !hasNeeds {\n+\t\tt.Error(\"extractTopLevelYAMLSection must not mutate the original frontmatter[\\\"on\\\"] map\")\n+\t}\n+}\n+\n func TestExtractTopLevelYAMLSectionWithOrdering(t *testing.T) {\n \tcompiler := NewCompiler()\n<shellId: 36 completed with exit code 0>","detailedContent":"diff --git a/pkg/workflow/frontmatter_extraction_yaml.go b/pkg/workflow/frontmatter_extraction_yaml.go\nindex 630dc2a396a..d43e6cdcf55 100644\n--- a/pkg/workflow/frontmatter_extraction_yaml.go\n+++ b/pkg/workflow/frontmatter_extraction_yaml.go\n@@ -57,6 +57,13 @@ func (c *Compiler) extractTopLevelYAMLSection(frontmatter map[string]any, key st\n \n \t// Check if value is a map that we should order alphabetically\n \tif valueMap, ok := value.(map[string]any); ok {\n+\t\t// For the \"on\" section, exclude gh-aw-specific keys that are processed\n+\t\t// separately and must not appear in the compiled GitHub Actions workflow.\n+\t\t// The \"needs\" key (on.needs) controls job dependency wiring and is invalid\n+\t\t// as a top-level on: trigger key in GitHub Actions.\n+\t\tif key == \"on\" {\n+\t\t\tvalueMap = excludeMapKeys(valueMap, \"needs\")\n+\t\t}\n \t\t// Use OrderMapFields for alphabetical sorting (empty priority list = all alphabetical)\n \t\torderedValue := OrderMapFields(valueMap, []string{})\n \t\t// Wrap the ordered value with the key using MapSlice\ndiff --git a/pkg/workflow/on_needs_integration_test.go b/pkg/workflow/on_needs_integration_test.go\nindex f6f8ad0962e..7e5554fb9d0 100644\n--- a/pkg/workflow/on_needs_integration_test.go\n+++ b/pkg/workflow/on_needs_integration_test.go\n@@ -5,6 +5,7 @@ package workflow\n import (\n \t\"os\"\n \t\"path/filepath\"\n+\t\"strings\"\n \t\"testing\"\n \n \t\"github.com/github/gh-aw/pkg/testutil\"\n@@ -52,6 +53,15 @@ Run with on.needs\n \tvar lock map[string]any\n \trequire.NoError(t, yaml.Unmarshal(lockBytes, &lock), \"compiled lock file should be valid YAML\")\n \n+\t// Verify on.needs is NOT emitted into the compiled on: section\n+\tonSection, ok := lock[\"on\"].(map[string]any)\n+\trequire.True(t, ok, \"compiled workflow should contain on section\")\n+\tassert.NotContains(t, onSection, \"needs\", \"on.needs must not appear as a key in the compiled on: section\")\n+\n+\t// Verify on.needs is not in the raw compiled text (even as a comment)\n+\tlockContent := string(lockBytes)\n+\tassert.False(t, containsNeedsInOnSection(lockContent), \"on.needs must not appear in the compiled on: section text\")\n+\n \tjobs, ok := lock[\"jobs\"].(map[string]any)\n \trequire.True(t, ok, \"compiled workflow should contain jobs map\")\n \n@@ -63,3 +73,26 @@ Run with on.needs\n \trequire.True(t, ok, \"compiled workflow should contain activation job\")\n \tassert.Contains(t, activation[\"needs\"], \"secrets_fetcher\", \"activation should depend on on.needs job\")\n }\n+\n+// containsNeedsInOnSection checks whether the \"needs:\" key appears in the \"on:\" section\n+// of a compiled workflow YAML string (as a non-comment, non-job-level line).\n+func containsNeedsInOnSection(yamlContent string) bool {\n+\tinOnSection := false\n+\tfor _, line := range strings.Split(yamlContent, \"\\n\") {\n+\t\ttrimmed := strings.TrimLeft(line, \" \\t\")\n+\t\t// Track when we enter/leave the on: section\n+\t\tif trimmed == \"on:\" || strings.HasPrefix(trimmed, `\"on\":`) {\n+\t\t\tinOnSection = true\n+\t\t\tcontinue\n+\t\t}\n+\t\t// Leave on: section when we hit a top-level key\n+\t\tif inOnSection && len(line) > 0 && line[0] != ' ' && line[0] != '\\t' && !strings.HasPrefix(trimmed, \"#\") {\n+\t\t\tinOnSection = false\n+\t\t}\n+\t\t// Check for needs: inside on: section (as a real key, not a job-level needs)\n+\t\tif inOnSection && strings.HasPrefix(trimmed, \"needs:\") && !strings.HasPrefix(trimmed, \"#\") {\n+\t\t\treturn true\n+\t\t}\n+\t}\n+\treturn false\n+}diff --git a/pkg/workflow/yaml_test.go b/pkg/workflow/yaml_test.go\nindex 651e13ff2a8..07834aa4526 100644\n--- a/pkg/workflow/yaml_test.go\n+++ b/pkg/workflow/yaml_test.go\n@@ -400,6 +400,34 @@ func TestMarshalWithFieldOrder_OrdersNestedEnvWithSecretsRecursively(t *testing.\n \tassertOrder(\"    ALPHA_STEP:\", \"    ZETA_STEP:\")\n }\n \n+func TestExtractTopLevelYAMLSectionExcludesOnNeeds(t *testing.T) {\n+\tcompiler := NewCompiler()\n+\n+\tfrontmatter := map[string]any{\n+\t\t\"on\": map[string]any{\n+\t\t\t\"needs\":             []any{\"custom_job\"},\n+\t\t\t\"workflow_dispatch\": nil,\n+\t\t},\n+\t}\n+\n+\tresult := compiler.extractTopLevelYAMLSection(frontmatter, \"on\")\n+\n+\tif strings.Contains(result, \"needs:\") {\n+\t\tt.Errorf(\"on.needs must not appear in compiled on: section, but found it in:\\n%s\", result)\n+\t}\n+\tif !strings.Contains(result, \"workflow_dispatch\") {\n+\t\tt.Errorf(\"workflow_dispatch should be present in the compiled on: section:\\n%s\", result)\n+\t}\n+\t// Verify the original frontmatter[\"on\"] map is not mutated\n+\tonMap, ok := frontmatter[\"on\"].(map[string]any)\n+\tif !ok {\n+\t\tt.Fatal(\"frontmatter[\\\"on\\\"] should remain a map[string]any\")\n+\t}\n+\tif _, hasNeeds := onMap[\"needs\"]; !hasNeeds {\n+\t\tt.Error(\"extractTopLevelYAMLSection must not mutate the original frontmatter[\\\"on\\\"] map\")\n+\t}\n+}\n+\n func TestExtractTopLevelYAMLSectionWithOrdering(t *testing.T) {\n \tcompiler := NewCompiler()\n<shellId: 36 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-02T22:59:07.295Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-02T22:59:07.297Z","data":{"toolName":"bash","mcpServerName":"","command":"grep -rn \"func excludeMapKeys\" /home/runner/work/gh-aw/gh-aw/pkg/workflow/ -A 15"}}
{"type":"tool.execution_complete","timestamp":"2026-08-02T22:59:07.385Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go:43:func excludeMapKeys(original map[string]any, excludeKeys ...string) map[string]any {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-44-\tif mapHelpersLog.Enabled() {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-45-\t\tmapHelpersLog.Printf(\"excludeMapKeys: input=%d keys, excluding=%v\", len(original), excludeKeys)\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-46-\t}\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-47-\texcludeSet := make(map[string]struct {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-48-\t})\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-49-\tfor _, key := range excludeKeys {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-50-\t\texcludeSet[key] = struct {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-51-\t\t}{}\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-52-\t}\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-53-\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-54-\tresult := make(map[string]any)\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-55-\tfor key, value := range original {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-56-\t\tif !setutil.Contains(excludeSet, key) {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-57-\t\t\tresult[key] = value\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-58-\t\t}\n<shellId: 37 completed with exit code 0>","detailedContent":"/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go:43:func excludeMapKeys(original map[string]any, excludeKeys ...string) map[string]any {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-44-\tif mapHelpersLog.Enabled() {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-45-\t\tmapHelpersLog.Printf(\"excludeMapKeys: input=%d keys, excluding=%v\", len(original), excludeKeys)\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-46-\t}\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-47-\texcludeSet := make(map[string]struct {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-48-\t})\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-49-\tfor _, key := range excludeKeys {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-50-\t\texcludeSet[key] = struct {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-51-\t\t}{}\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-52-\t}\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-53-\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-54-\tresult := make(map[string]any)\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-55-\tfor key, value := range original {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-56-\t\tif !setutil.Contains(excludeSet, key) {\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-57-\t\t\tresult[key] = value\n/home/runner/work/gh-aw/gh-aw/pkg/workflow/map_helpers.go-58-\t\t}\n<shellId: 37 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-02T22:59:33.183Z","data":{"content":"Good - `excludeMapKeys` creates a new map (non-mutating), confirming correctness. Let me launch the grumpy-coder sub-agent and do my own pass in parallel."}}
{"type":"tool.execution_start","timestamp":"2026-08-02T22:59:33.184Z","data":{"toolName":"task","mcpServerName":""}}
{"type":"subagent.started","timestamp":"2026-08-02T22:59:33.196Z","data":{"agentName":"general-purpose","agentDisplayName":"General Purpose Agent","toolCallId":"toolu_015Bd1Vjnv8MVxkeb6xU7WcU"}}
{"type":"tool.execution_complete","timestamp":"2026-08-02T22:59:33.204Z","data":{"toolName":"task","mcpServerName":"","success":true,"result":{"content":"Agent started in background with agent_id: grumpy-coder-3. You'll be notified when it completes. Tell the user you're waiting and end your response, or continue unrelated work until notified. The agent supports multi-turn conversations — use write_agent to send follow-up messages.","detailedContent":"Prompt to general-purpose agent (grumpy-coder-3):\nYou are a grumpy, highly critical code reviewer performing first-pass issue mining on a small Go PR in the github/gh-aw repository. Output STRICT JSONL only — one JSON object per line, no prose, no markdown fences. Each line must have fields: file, line (best-effort line number in the new file version), severity (critical|high|medium|low), issue (short title), detail (1-2 sentence explanation). Only flag issues within the changed lines shown below (do not invent line numbers outside the diff). If you find nothing, output nothing.\n\nPR summary: Fixes a bug where `on.needs` in frontmatter was being serialized into the compiled GitHub Actions workflow's `on:` section (invalid YAML key). Fix: in `extractTopLevelYAMLSection`, when key==\"on\", call `excludeMapKeys(valueMap, \"needs\")` to get a filtered copy before marshaling. Also added tests.\n\nFull diff:\n```diff\ndiff --git a/pkg/workflow/frontmatter_extraction_yaml.go b/pkg/workflow/frontmatter_extraction_yaml.go\nindex 630dc2a396a..d43e6cdcf55 100644\n--- a/pkg/workflow/frontmatter_extraction_yaml.go\n+++ b/pkg/workflow/frontmatter_extraction_yaml.go\n@@ -57,6 +57,13 @@ func (c *Compiler) extractTopLevelYAMLSection(frontmatter map[string]any, key s\n \n \t// Check if value is a map that we should order alphabetically\n \tif valueMap, ok := value.(map[string]any); ok {\n+\t\t// For the \"on\" section, exclude gh-aw-specific keys that are processed\n+\t\t// separately and must not appear in the compiled GitHub Actions workflow.\n+\t\t// The \"needs\" key (on.needs) controls job dependency wiring and is invalid\n+\t\t// as a top-level on: trigger key in GitHub Actions.\n+\t\tif key == \"on\" {\n+\t\t\tvalueMap = excludeMapKeys(valueMap, \"needs\")\n+\t\t}\n \t\t// Use OrderMapFields for alphabetical sorting (empty priority list = all alphabetical)\n \t\torderedValue := OrderMapFields(valueMap, []string{})\n \t\t// Wrap the ordered value with the key using MapSlice\ndiff --git a/pkg/workflow/on_needs_integration_test.go b/pkg/workflow/on_needs_integration_test.go\nindex f6f8ad0962e..7e5554fb9d0 100644\n--- a/pkg/workflow/on_needs_integration_test.go\n+++ b/pkg/workflow/on_needs_integration_test.go\n@@ -5,6 +5,7 @@ package workflow\n import (\n \t\"os\"\n \t\"path/filepath\"\n+\t\"strings\"\n \t\"testing\"\n \n \t\"github.com/github/gh-aw/pkg/testutil\"\n@@ -52,6 +53,15 @@ Run with on.needs\n \tvar lock map[string]any\n \trequire.NoError(t, yaml.Unmarshal(lockBytes, &lock), \"compiled lock file should be valid YAML\")\n \n+\t// Verify on.needs is NOT emitted into the compiled on: section\n+\tonSection, ok := lock[\"on\"].(map[string]any)\n+\trequire.True(t, ok, \"compiled workflow should contain on section\")\n+\tassert.NotContains(t, onSection, \"needs\", \"on.needs must not appear as a key in the compiled on: section\")\n+\n+\t// Verify on.needs is not in the raw compiled text (even as a comment)\n+\tlockContent := string(lockBytes)\n+\tassert.False(t, containsNeedsInOnSection(lockContent), \"on.needs must not appear in the compiled on: section text\")\n+\n \tjobs, ok := lock[\"jobs\"].(map[string]any)\n \trequire.True(t, ok, \"compiled workflow should contain jobs map\")\n \n@@ -63,3 +73,26 @@ Run with on.needs\n \trequire.True(t, ok, \"compiled workflow should contain activation job\")\n \tassert.Contains(t, activation[\"needs\"], \"secrets_fetcher\", \"activation should depend on on.needs job\")\n }\n+\n+// containsNeedsInOnSection checks whether the \"needs:\" key appears in the \"on:\" section\n+// of a compiled workflow YAML string (as a non-comment, non-job-level line).\n+func containsNeedsInOnSection(yamlContent string) bool {\n+\tinOnSection := false\n+\tfor _, line := range strings.Split(yamlContent, \"\\n\") {\n+\t\ttrimmed := strings.TrimLeft(line, \" \\t\")\n+\t\t// Track when we enter/leave the on: section\n+\t\tif trimmed == \"on:\" || strings.HasPrefix(trimmed, `\"on\":`) {\n+\t\t\tinOnSection = true\n+\t\t\tcontinue\n+\t\t}\n+\t\t// Leave on: section when we hit a top-level key\n+\t\tif inOnSection && len(line) > 0 && line[0] != ' ' && line[0] != '\\t' && !strings.HasPrefix(trimmed, \"#\") {\n+\t\t\tinOnSection = false\n+\t\t}\n+\t\t// Check for needs: inside on: section (as a real key, not a job-level needs)\n+\t\tif inOnSection && strings.HasPrefix(trimmed, \"needs:\") && !strings.HasPrefix(trimmed, \"#\") {\n+\t\t\treturn true\n+\t\t}\n+\t}\n+\treturn false\n+}diff --git a/pkg/workflow/yaml_test.go b/pkg/workflow/yaml_test.go\nindex 651e13ff2a8..07834aa4526 100644\n--- a/pkg/workflow/yaml_test.go\n+++ b/pkg/workflow/yaml_test.go\n@@ -400,6 +400,34 @@ func TestMarshalWithFieldOrder_OrdersNestedEnvWithSecretsRecursively(t *testing.\n \tassertOrder(\"    ALPHA_STEP:\", \"    ZETA_STEP:\")\n }\n \n+func TestExtractTopLevelYAMLSectionExcludesOnNeeds(t *testing.T) {\n+\tcompiler := NewCompiler()\n+\n+\tfrontmatter := map[string]any{\n+\t\t\"on\": map[string]any{\n+\t\t\t\"needs\":             []any{\"custom_job\"},\n+\t\t\t\"workflow_dispatch\": nil,\n+\t\t},\n+\t}\n+\n+\tresult := compiler.extractTopLevelYAMLSection(frontmatter, \"on\")\n+\n+\tif strings.Contains(result, \"needs:\") {\n+\t\tt.Errorf(\"on.needs must not appear in compiled on: section, but found it in:\\n%s\", result)\n+\t}\n+\tif !strings.Contains(result, \"workflow_dispatch\") {\n+\t\tt.Errorf(\"workflow_dispatch should be present in the compiled on: section:\\n%s\", result)\n+\t}\n+\t// Verify the original frontmatter[\"on\"] map is not mutated\n+\tonMap, ok := frontmatter[\"on\"].(map[string]any)\n+\tif !ok {\n+\t\tt.Fatal(\"frontmatter[\\\"on\\\"] should remain a map[string]any\")\n+\t}\n+\tif _, hasNeeds := onMap[\"needs\"]; !hasNeeds {\n+\t\tt.Error(\"extractTopLevelYAMLSection must not mutate the original frontmatter[\\\"on\\\"] map\")\n+\t}\n+}\n+\n func TestExtractTopLevelYAMLSectionWithOrdering(t *testing.T) {\n \tcompiler := NewCompiler()\n```\n\nNote: `excludeMapKeys` (in pkg/workflow/map_helpers.go) creates a new map via `make(map[string]any)` and copies non-excluded keys — it does not mutate the original map. Keep this in mind; do not flag mutation concerns that are factually wrong.\n\nBe harsh: look for edge cases (nil valueMap, empty \"on\" map after exclusion, case sensitivity of \"needs\" key, whether this handles nested on.needs under other trigger types, test brittleness/line-based string parsing test being fragile, missing negative test cases, whether other gh-aw-specific keys besides \"needs\" might leak into on: section, whether excludeMapKeys is O(n) fine here). Output JSONL findings only."}}}
[copilot-sdk-driver] [sdk-driver] error: Execution failed: Error: No model available. Check policy enablement under GitHub Settings > Copilot
{"type":"subagent.completed","timestamp":"2026-08-02T22:59:33.256Z","data":{"agentName":"general-purpose","toolCallId":"toolu_015Bd1Vjnv8MVxkeb6xU7WcU"}}

Generated from PR Code Quality Reviewer · 112.5 AIC · ◷

[github-actions]

Agent job 30771862234 failed.

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

{"type":"tool.execution_complete","timestamp":"2026-08-02T23:21:27.473Z","data":{"toolName":"view","mcpServerName":"","success":true,"result":{"content":"File too large to read at once (30.4 KB). Consider using the grep tool to search within the file, or view with view_range to read specific sections.","detailedContent":"File too large to read at once (30.4 KB). Consider using the grep tool to search within the file, or view with view_range to read specific sections."}}}
{"type":"assistant.message","timestamp":"2026-08-02T23:21:29.821Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-02T23:21:29.823Z","data":{"toolName":"bash","mcpServerName":"","command":"split -l 220 /tmp/gh-aw/agent/pr-diff.patch /tmp/gh-aw/agent/part_ ; ls /tmp/gh-aw/agent/part_*"}}
{"type":"tool.execution_complete","timestamp":"2026-08-02T23:21:29.890Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"/tmp/gh-aw/agent/part_aa\n/tmp/gh-aw/agent/part_ab\n/tmp/gh-aw/agent/part_ac\n/tmp/gh-aw/agent/part_ad\n<shellId: 10 completed with exit code 0>","detailedContent":"/tmp/gh-aw/agent/part_aa\n/tmp/gh-aw/agent/part_ab\n/tmp/gh-aw/agent/part_ac\n/tmp/gh-aw/agent/part_ad\n<shellId: 10 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-02T23:21:41.355Z","data":{"content":"Launching grumpy-coder sub-agent in background while I analyze the diff myself."}}
{"type":"tool.execution_start","timestamp":"2026-08-02T23:21:41.356Z","data":{"toolName":"task","mcpServerName":""}}
{"type":"subagent.started","timestamp":"2026-08-02T23:21:41.365Z","data":{"agentName":"general-purpose","agentDisplayName":"General Purpose Agent","toolCallId":"toolu_018PxHiNm3gZAsNpRm49i1Ru"}}
{"type":"tool.execution_complete","timestamp":"2026-08-02T23:21:41.371Z","data":{"toolName":"task","mcpServerName":"","success":true,"result":{"content":"Agent started in background with agent_id: grumpy-coder-3. You'll be notified when it completes. Tell the user you're waiting and end your response, or continue unrelated work until notified. The agent supports multi-turn conversations — use write_agent to send follow-up messages.","detailedContent":"Prompt to general-purpose agent (grumpy-coder-3):\nYou are a grumpy, highly critical code reviewer doing first-pass issue mining on a PR diff. Read the file /tmp/gh-aw/agent/pr-diff.patch (it's ~30KB, use view_range or bash cat/split if needed) which is a git diff for PR #49866 in github/gh-aw, titled \"Add skill invocation visibility for APM-restored skills\". It adds a new SkillActivation type, an extraction function extractSkillActivationsFromRun in pkg/cli/logs_metrics.go with two phases (explicit agent_output.json parsing, and log-parse fallback via regex over engine log files), and wires it through the audit/logs pipeline.\n\nFiles changed: pkg/cli/audit.go, pkg/cli/audit_report.go, pkg/cli/audit_report_render.go, pkg/cli/logs_metrics.go (main logic, +256 lines), pkg/cli/logs_models.go (new type), pkg/cli/logs_run_processor.go, pkg/cli/logs_skill_activations_test.go (new test file).\n\nFind correctness risks, performance regressions, maintainability debt, and weak engineering decisions ONLY within the changed lines shown in the diff (ignore unchanged context lines). Look specifically for:\n- Logic errors, edge cases, missing error handling (e.g. nil checks, empty file handling, malformed JSON)\n- Performance issues (inefficient regex use in loops, unnecessary allocations, repeated file reads)\n- Security-adjacent concerns (unsafe string interpolation, regex ReDoS, unvalidated inputs used in file paths)\n- Race conditions / shared state issues\n- Deduplication logic correctness (the diff mentions dedup by skill name across files)\n- Precedence logic correctness (agent_output taking precedence over log_parse - is phase 2 actually skipped correctly when phase 1 yields results?)\n- Test coverage gaps in the new test file\n- Unclear naming, magic strings/numbers, missing comments where genuinely needed\n\nOutput STRICTLY as JSONL, one finding per line, each a JSON object with fields: \"file\" (path), \"line\" (best-guess line number in the new file version, integer), \"severity\" (one of \"critical\",\"high\",\"medium\",\"low\"), \"issue\" (short description), \"impact\" (why it matters), \"fix\" (brief suggested fix). Do not output markdown, prose, or any other text — only JSONL lines. If you find no issues, output an empty output (no lines)."}}}
[copilot-sdk-driver] [sdk-driver] error: Execution failed: Error: No model available. Check policy enablement under GitHub Settings > Copilot
{"type":"subagent.completed","timestamp":"2026-08-02T23:21:41.422Z","data":{"agentName":"general-purpose","toolCallId":"toolu_018PxHiNm3gZAsNpRm49i1Ru"}}

Generated from PR Code Quality Reviewer · 52.9 AIC · ◷