Skip to content

Commit bbed3d5

Browse files
committed
fix: simplify boolean and add another test
Signed-off-by: jmeridth <[email protected]>
1 parent 444a846 commit bbed3d5

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

evergreen.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,9 @@ def main(): # pragma: no cover
162162
def is_repo_created_date_before(repo_created_at: str, created_after_date: str):
163163
"""Check if the repository was created before the created_after_date"""
164164
repo_created_at_date = datetime.fromisoformat(repo_created_at).replace(tzinfo=None)
165-
if created_after_date and repo_created_at_date < datetime.strptime(
165+
return created_after_date and repo_created_at_date < datetime.strptime(
166166
created_after_date, "%Y-%m-%d"
167-
):
168-
return True
169-
return False
167+
)
170168

171169

172170
def is_dependabot_security_updates_enabled(owner, repo, access_token):

test_evergreen.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -610,6 +610,15 @@ def test_is_repo_created_date_has_no_time_zone(self):
610610

611611
self.assertTrue(result)
612612

613+
def test_is_created_after_date_is_empty_string(self):
614+
"""Test the repo.created_at date is after created_after_date."""
615+
repo_created_at = "2020-01-01"
616+
created_after_date = ""
617+
618+
result = is_repo_created_date_before(repo_created_at, created_after_date)
619+
620+
self.assertFalse(result)
621+
613622

614623
if __name__ == "__main__":
615624
unittest.main()

0 commit comments

Comments
 (0)