Skip to content

Commit b487f4c

Browse files
Fix qldoc, formatting, and redundant import warnings
1 parent 9b27fa3 commit b487f4c

File tree

10 files changed

+3
-12
lines changed

10 files changed

+3
-12
lines changed

python/ql/lib/semmle/python/Concepts.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -872,7 +872,7 @@ class TemplateConstruction extends DataFlow::Node instanceof TemplateConstructio
872872
DataFlow::Node getSourceArg() { result = super.getSourceArg() }
873873
}
874874

875-
/** Provides classes for modelling template construction APIs. */
875+
/** Provides classes for modeling template construction APIs. */
876876
module TemplateConstruction {
877877
/**
878878
* A data-flow node that constructs a template in a templating engine.
@@ -886,7 +886,6 @@ module TemplateConstruction {
886886
}
887887
}
888888

889-
890889
/** Provides classes for modeling HTTP-related APIs. */
891890
module Http {
892891
/** Gets an HTTP verb, in upper case */

python/ql/lib/semmle/python/frameworks/Airspeed.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55

66
private import python
7-
private import semmle.python.dataflow.new.DataFlow
87
private import semmle.python.ApiGraphs
98
private import semmle.python.Concepts
109

python/ql/lib/semmle/python/frameworks/Chameleon.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55

66
private import python
7-
private import semmle.python.dataflow.new.DataFlow
87
private import semmle.python.ApiGraphs
98
private import semmle.python.Concepts
109

python/ql/lib/semmle/python/frameworks/Chevron.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55

66
private import python
7-
private import semmle.python.dataflow.new.DataFlow
87
private import semmle.python.ApiGraphs
98
private import semmle.python.Concepts
109

python/ql/lib/semmle/python/frameworks/Django.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3000,7 +3000,6 @@ module PrivateDjango {
30003000
// ---------------------------------------------------------------------------
30013001
// Templates
30023002
// ---------------------------------------------------------------------------
3003-
30043003
/** A call to `django.template.Template` */
30053004
private class DjangoTemplateConstruction extends TemplateConstruction::Range, API::CallNode {
30063005
DjangoTemplateConstruction() {
@@ -3009,6 +3008,5 @@ module PrivateDjango {
30093008

30103009
override DataFlow::Node getSourceArg() { result = this.getArg(0) }
30113010
}
3012-
30133011
// TODO: Support `from_string` on instances of `django.template.Engine`.
30143012
}

python/ql/lib/semmle/python/frameworks/Genshi.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55

66
private import python
7-
private import semmle.python.dataflow.new.DataFlow
87
private import semmle.python.ApiGraphs
98
private import semmle.python.Concepts
109

python/ql/lib/semmle/python/frameworks/Jinja2.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55

66
private import python
7-
private import semmle.python.dataflow.new.DataFlow
87
private import semmle.python.ApiGraphs
98
private import semmle.python.Concepts
109
private import semmle.python.frameworks.data.ModelsAsData

python/ql/lib/semmle/python/frameworks/Mako.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55

66
private import python
7-
private import semmle.python.dataflow.new.DataFlow
87
private import semmle.python.ApiGraphs
98
private import semmle.python.Concepts
109

python/ql/lib/semmle/python/frameworks/TRender.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55

66
private import python
7-
private import semmle.python.dataflow.new.DataFlow
87
private import semmle.python.ApiGraphs
98
private import semmle.python.Concepts
109

python/ql/lib/semmle/python/security/dataflow/TemplateInjectionQuery.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,13 @@ import semmle.python.dataflow.new.DataFlow
1111
import semmle.python.dataflow.new.TaintTracking
1212
import TemplateInjectionCustomizations::TemplateInjection
1313

14-
module TemplateInjectionConfig implements DataFlow::ConfigSig {
14+
private module TemplateInjectionConfig implements DataFlow::ConfigSig {
1515
predicate isSource(DataFlow::Node node) { node instanceof Source }
1616

1717
predicate isSink(DataFlow::Node node) { node instanceof Sink }
1818

1919
predicate isBarrierIn(DataFlow::Node node) { node instanceof Sanitizer }
2020
}
2121

22+
/** Global taint-tracking for detecting "template injection" vulnerabilities. */
2223
module TemplateInjectionFlow = TaintTracking::Global<TemplateInjectionConfig>;

0 commit comments

Comments
 (0)