Rust: Make a return node the last node before function exit

github · Nov 7, 2024 · 22835c2 · 22835c2
1 parent 1a000ec
commit 22835c2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll b/rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll
@@ -190,7 +190,7 @@ module Node {
 
   /** A data flow node that represents a value returned by a callable. */
   final class ReturnNode extends ExprNode {
-    ReturnNode() { this.asExpr() instanceof ReturnExpr }
+    ReturnNode() { this.getCfgNode().getASuccessor() instanceof ExitCfgNode }
 
     ReturnKind getKind() { any() }
   }