Merge pull request #22371 from github/redsun82-go-move-extractor-smoke-test-to-integrat

Go: move extractor smoke test into integration tests

Author: redsun82

CODEOWNERS

@@ -11,7 +11,6 @@
 /go/codeql-tools/ @github/codeql-go @github/code-scanning-language-coverage
 /go/downgrades/ @github/codeql-go @github/code-scanning-language-coverage
 /go/extractor/ @github/codeql-go @github/code-scanning-language-coverage
-/go/extractor-smoke-test/ @github/codeql-go @github/code-scanning-language-coverage
 /go/ql/test/extractor-tests/ @github/codeql-go @github/code-scanning-language-coverage
 /java/ @github/codeql-java
 /javascript/ @github/codeql-javascript

go/Makefile

@@ -58,7 +58,6 @@ test: all build/testdb/check-upgrade-path
 #	use GOOS=linux because GOOS=darwin GOARCH=386 is no longer supported
 	env GOOS=linux GOARCH=386 codeql$(EXE) test run -j0 ql/test/query-tests/Security/CWE-681 --search-path .. --check-diff-informed --consistency-queries ql/consistency-queries --compilation-cache=$(cache) --dynamic-join-order-mode=$(rtjo)
 	cd extractor; $(BAZEL) test ...
-	bash extractor-smoke-test/test.sh || (echo "Extractor smoke test FAILED"; exit 1)
 
 .PHONY: build/testdb/check-upgrade-path
 build/testdb/check-upgrade-path : build/testdb/go.dbscheme ql/lib/go.dbscheme

go/extractor-smoke-test/.gitignore

@@ -5,3 +5,12 @@ def test_traced(codeql, go):
 
 def test_autobuild(codeql, go):
     codeql.database.create(source_root="src", extractor_option = ["extract_tests=true"])
+
+def test_autobuild_traced(codeql, go):
+    # Autobuild under build tracing must produce the same database as untraced
+    # autobuild and explicit traced builds, all checked against test.expected.
+    codeql.database.create(
+        source_root="src",
+        extractor_option = ["extract_tests=true"],
+        _env={"CODEQL_EXTRACTOR_GO_BUILD_TRACING": "on"},
+    )