Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Michaelrfairhurst/fix autosar a1 1 2 detect -w flag test workaround #696

Closed
wants to merge 4 commits into from
Closed

Michaelrfairhurst/fix autosar a1 1 2 detect -w flag test workaround #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83790c9
Detect compilations with no warnings when '-w' flag is present.
MichaelRFairhurst Sep 17, 2024
8a1d089
fix formatting
MichaelRFairhurst Sep 17, 2024
e60c4f0
Update test expectations -- codeql run test expects noncompliance.
MichaelRFairhurst Sep 17, 2024
863d8e4
Add newline to EOF
MichaelRFairhurst Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions cpp/autosar/src/rules/A1-1-2/CompilerWarningLevelNotInCompliance.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,17 @@
import cpp
import codingstandards.cpp.autosar

predicate hasResponseFileArgument(Compilation c) { c.getAnArgument().matches("@%") }
class CompilationWithNoWarnings extends Compilation {
CompilationWithNoWarnings() {
getAnArgument() = "-w" or
not getAnArgument().regexpMatch("-W[\\w=-]+")
}
}

predicate hasWarningOption(Compilation c) { c.getAnArgument().regexpMatch("-W[\\w=-]+") }
predicate hasResponseFileArgument(Compilation c) { c.getAnArgument().matches("@%") }

from File f
where
not isExcluded(f, ToolchainPackage::compilerWarningLevelNotInComplianceQuery()) and
exists(Compilation c | f = c.getAFileCompiled() |
not hasResponseFileArgument(c) and
not hasWarningOption(c)
)
exists(CompilationWithNoWarnings c | f = c.getAFileCompiled() | not hasResponseFileArgument(c))
select f, "No warning-level options were used in the compilation of '" + f.getBaseName() + "'."
1 change: 1 addition & 0 deletions cpp/autosar/test/rules/A1-1-2.2/CompilerWarningLevelNotInCompliance.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
| Wcast-function-type.cpp:0:0:0:0 | Wcast-function-type.cpp | No warning-level options were used in the compilation of 'Wcast-function-type.cpp'. |
Empty file added cpp/autosar/test/rules/A1-1-2.2/CompilerWarningLevelNotInCompliance.expected.clang
View file
Open in desktop
Empty file.
Empty file added cpp/autosar/test/rules/A1-1-2.2/CompilerWarningLevelNotInCompliance.expected.gcc
View file
Open in desktop
Empty file.
Empty file added cpp/autosar/test/rules/A1-1-2.2/CompilerWarningLevelNotInCompliance.expected.qcc
View file
Open in desktop
Empty file.
14 changes: 13 additions & 1 deletion cpp/autosar/test/rules/A1-1-2.2/Wcast-function-type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,14 @@
// semmle-extractor-options: --clang -std=c++14 -Wcast-function-type
// COMPLIANT
// COMPLIAN

// NOTE: When tested with `codeql test run`, the test extractor provides `-w`
// which overrides `-Wcast-function-type` and causes this test case to be
// non-compliant.
//
// However, when tested with our compiler matrix tests, this test db is built
// via `codeql database create --command="..."`, and the `-w` flag will NOT be
// used. This means the `-Wcast-function-type` flag is active and the test case
// is compliant.
//
// Therefore, the .expected file for this test expects non-compliance, and the
// .expected.gcc and .expected.clang files expect this test to be compliant.
1 change: 1 addition & 0 deletions cpp/autosar/test/rules/A1-1-2/CompilerWarningLevelNotInCompliance.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
| Wall.cpp:0:0:0:0 | Wall.cpp | No warning-level options were used in the compilation of 'Wall.cpp'. |
Empty file added cpp/autosar/test/rules/A1-1-2/CompilerWarningLevelNotInCompliance.expected.clang
View file
Open in desktop
Empty file.
Empty file added cpp/autosar/test/rules/A1-1-2/CompilerWarningLevelNotInCompliance.expected.gcc
View file
Open in desktop
Empty file.
Empty file added cpp/autosar/test/rules/A1-1-2/CompilerWarningLevelNotInCompliance.expected.qcc
View file
Open in desktop
Empty file.
12 changes: 11 additions & 1 deletion cpp/autosar/test/rules/A1-1-2/Wall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,12 @@
// semmle-extractor-options: --clang -std=c++14 -Wall
// COMPLIANT
// COMPLIANT

// NOTE: When tested with `codeql test run`, the test extractor provides `-w`
// which overrides `-Wall` and causes this test case to be non-compliant.
//
// However, when tested with our compiler matrix tests, this test db is built
// via `codeql database create --command="..."`, and the `-w` flag will NOT be
// used. This means the `-Wall` flag is active and the test case is compliant.
//
// Therefore, the .expected file for this test expects non-compliance, and the
// .expected.gcc and .expected.clang files expect this test to be compliant.
Loading