From ff877964b36c7b12b4af79dbcdfc71520aa90a4d Mon Sep 17 00:00:00 2001 From: Remco Vermeulen Date: Fri, 17 Nov 2023 15:39:21 -0800 Subject: [PATCH 1/3] Use a subshell to wrap the gh command --- .github/workflows/prepare-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prepare-release.yml b/.github/workflows/prepare-release.yml index cca4edb838..7ead5aabc1 100644 --- a/.github/workflows/prepare-release.yml +++ b/.github/workflows/prepare-release.yml @@ -80,7 +80,7 @@ jobs: env: GITHUB_TOKEN: ${{ github.token }} run: | - release_pr=$(gh pr view rc/$RELEASE_VERSION --json title,state,number) + release_pr=$( { gh pr view rc/$RELEASE_VERSION --json title,state,number; } || echo "") if [[ ! -z "$release_pr" ]]; then pr_title=$(echo "$release_pr" | jq -r '.title') pr_state=$(echo "$release_pr" | jq -r '.state') From 901a97e69666d0221fd4ae709ada778a9ffe0b30 Mon Sep 17 00:00:00 2001 From: Remco Vermeulen Date: Fri, 17 Nov 2023 15:39:40 -0800 Subject: [PATCH 2/3] Prevent globbing and word splitting --- .github/workflows/prepare-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prepare-release.yml b/.github/workflows/prepare-release.yml index 7ead5aabc1..ac223c6051 100644 --- a/.github/workflows/prepare-release.yml +++ b/.github/workflows/prepare-release.yml @@ -80,7 +80,7 @@ jobs: env: GITHUB_TOKEN: ${{ github.token }} run: | - release_pr=$( { gh pr view rc/$RELEASE_VERSION --json title,state,number; } || echo "") + release_pr=$( { gh pr view "rc/$RELEASE_VERSION" --json title,state,number; } || echo "") if [[ ! -z "$release_pr" ]]; then pr_title=$(echo "$release_pr" | jq -r '.title') pr_state=$(echo "$release_pr" | jq -r '.state') From 72a99074977b60d281b730c802b705f26b365b23 Mon Sep 17 00:00:00 2001 From: Remco Vermeulen Date: Fri, 17 Nov 2023 15:41:11 -0800 Subject: [PATCH 3/3] Reduce the description that is part of the UI --- .github/workflows/prepare-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/prepare-release.yml b/.github/workflows/prepare-release.yml index ac223c6051..4b29141e7c 100644 --- a/.github/workflows/prepare-release.yml +++ b/.github/workflows/prepare-release.yml @@ -13,7 +13,7 @@ on: required: true hotfix: description: | - Whether this is a hotfix release. + Hotfix release. required: false default: false type: boolean