Repository navigation
Description
Affected rules
A5-2-6
Description
It's not well defined by the standard, but I think it's reasonable to exclude -> and . when considering whether an operand of a logical operator is binary.
Update: We thought the query was incorrectly reporting -> and . as binary operators. However, the problem was a confusion over this example:
foo->bar() && foo->baz() && foo->bang()Where the query is reporting that this should be bracketed like so:
(foo->bar() && foo->baz()) && foo->bang()This is a grey area in the rule itself - technically the title implies we should report this case. However, the rationale states:
Parentheses are required to add clarity in logical expressions making code easier to review versus code based only C++ operator precedence rules.
Which I think argues against asking for the developers to add unnecessary brackets in this case.
Proposed next steps:
- Exclude cases where the nested binary operator is the same as the parent binary operator.
- Refine the wording of the alert to ensure that it's clear where the brackets should be applied.
Example
foo->bar() && foo->baz() && foo->bang()Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
[-]`A5-2-6`: Do not consider `->` and `.` as binary oprators[/-][+]`A5-2-6`: Do not consider `->` and `.` as binary operators[/+]lcartey commentedon Apr 19, 2023
Reviewing the query, the description above is not accurate. The query already only reports
BinaryOperations, which does not includeFieldAccesses (such as->and.). I have investigated whether these could be caused by the use ofoperator->, either independently or in conjunction with templates but cannot reproduce the problem.[-]`A5-2-6`: Do not consider `->` and `.` as binary operators[/-][+]`A5-2-6`: Consider excluding cases with the same binary operator[/+]lcartey commentedon May 26, 2023
Issue body updated: the problem has been identified as related to (a) confusion caused by the alert message about where the brackets should apply and (b) an over-zealous rule.
[-]`A5-2-6`: Consider excluding cases with the same binary operator[/-][+]`A5-2-6`: Exclude cases with the same binary operator[/+]nbusser commentedon Jun 2, 2024
I would like to report a similar over-zealous case when using the same comparison operator:
AUTOSAR C++14 is not really clear for this specific case.
lcartey commentedon Oct 17, 2024
This will be addressed by: #753