Add supplementary query files

Author: jeongsoolee09

cpp/common/src/codingstandards/cpp/exclusions/cpp/Memory1.qll

@@ -3,7 +3,9 @@ import cpp
 import RuleMetadata
 import codingstandards.cpp.exclusions.RuleMetadata
 
-newtype Memory1Query = TPointerArithmeticFormsAnInvalidPointerQuery()
+newtype Memory1Query =
+  TPointerArithmeticFormsAnInvalidPointerQuery() or
+  TPointerArgumentToCstringFunctionIsInvalidQuery()
 
 predicate isMemory1QueryMetadata(Query query, string queryId, string ruleId, string category) {
   query =
@@ -14,6 +16,15 @@ predicate isMemory1QueryMetadata(Query query, string queryId, string ruleId, str
     "cpp/misra/pointer-arithmetic-forms-an-invalid-pointer" and
   ruleId = "RULE-8-7-1" and
   category = "required"
+  or
+  query =
+    // `Query` instance for the `pointerArgumentToCstringFunctionIsInvalid` query
+    Memory1Package::pointerArgumentToCstringFunctionIsInvalidQuery() and
+  queryId =
+    // `@id` for the `pointerArgumentToCstringFunctionIsInvalid` query
+    "cpp/misra/pointer-argument-to-cstring-function-is-invalid" and
+  ruleId = "RULE-8-7-1" and
+  category = "required"
 }
 
 module Memory1Package {
@@ -23,4 +34,11 @@ module Memory1Package {
       // `Query` type for `pointerArithmeticFormsAnInvalidPointer` query
       TQueryCPP(TMemory1PackageQuery(TPointerArithmeticFormsAnInvalidPointerQuery()))
   }
+
+  Query pointerArgumentToCstringFunctionIsInvalidQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `pointerArgumentToCstringFunctionIsInvalid` query
+      TQueryCPP(TMemory1PackageQuery(TPointerArgumentToCstringFunctionIsInvalidQuery()))
+  }
 }

cpp/misra/src/rules/RULE-8-7-1/PointerArgumentToCstringFunctionIsInvalid.ql

@@ -0,0 +1,26 @@
+/**
+ * @id cpp/misra/pointer-argument-to-cstring-function-is-invalid
+ * @name RULE-8-7-1: Pointer and index arguments passed to functions in <cstring> shall not be invalid.
+ * @description Pointer and index arguments passed to functions in <cstring> should result in valid
+ *              reads and/or writes.
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/misra/id/rule-8-7-1
+ *       scope/system
+ *       external/misra/enforcement/undecidable
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.c.cert
+import codingstandards.c.OutOfBounds
+
+from
+  OOB::BufferAccessLibraryFunctionCall fc, string message, Expr bufferArg, string bufferArgStr,
+  Expr sizeOrOtherBufferArg, string otherStr
+where
+  not isExcluded(fc, OutOfBoundsPackage::libraryFunctionArgumentOutOfBoundsQuery()) and
+  OOB::problems(fc, message, bufferArg, bufferArgStr, sizeOrOtherBufferArg, otherStr)
+select fc, message, bufferArg, bufferArgStr, sizeOrOtherBufferArg, otherStr
+

cpp/misra/src/rules/RULE-8-7-1/PointerArithmeticFormsAnInvalidPointer.ql

@@ -3,8 +3,8 @@
  * @name RULE-8-7-1: Pointer arithmetic shall not form an invalid pointer.
  * @description Pointers obtained as result of performing arithmetic should point to an initialized
  *              object, or an element right next to the last element of an array.
- * @kind path-problem
- * @precision very-high
+ * @kind problem
+ * @precision high
  * @problem.severity error
  * @tags external/misra/id/rule-8-7-1
  *       scope/system

cpp/misra/test/rules/RULE-8-7-1/PointerArgumentToCstringFunctionIsInvalid.expected

@@ -0,0 +1 @@
+No expected results have yet been specified

cpp/misra/test/rules/RULE-8-7-1/PointerArgumentToCstringFunctionIsInvalid.qlref

@@ -0,0 +1 @@
+rules/RULE-8-7-1/PointerArgumentToCstringFunctionIsInvalid.ql