Merge pull request #1024 from knewbury01/knewbury01/Lifetime

Add lifetime package

Author: MichaelRFairhurst

.vscode/tasks.json

@@ -259,6 +259,7 @@
                 "Language1",
                 "Language2",
                 "Language3",
+                "Lifetime",
                 "Linkage1",
                 "Linkage2",
                 "Literals",

change_notes/2026-02-03-uninitialized-mem-improve.md

@@ -0,0 +1,2 @@
+- `A8-5-0`, `EXP53-CPP`, `EXP33-C`, `RULE-9-1` - `MemoryNotInitializedBeforeItIsRead.ql`, `DoNotReadUninitializedMemory.ql`, `DoNotReadUninitializedMemory.ql`, `ObjectWithAutoStorageDurationReadBeforeInit.ql`:
+  - The queries listed now find uses of the operator 'new' where there is no value initialization provided. The queries listed now also uses an out of the box library to consider initialization within another function as valid initialization (`InitializationFunctions.qll`). We do not yet track finely track the initialization/use of `p` vs `*p`.

cpp/common/src/codingstandards/cpp/exclusions/cpp/Lifetime.qll

@@ -0,0 +1,44 @@
+//** THIS FILE IS AUTOGENERATED, DO NOT MODIFY DIRECTLY.  **/
+import cpp
+import RuleMetadata
+import codingstandards.cpp.exclusions.RuleMetadata
+
+newtype LifetimeQuery =
+  TValueOfAnObjectMustNotBeReadBeforeItHasBeenSetQuery() or
+  TAutomaticStorageAssignedToObjectGreaterLifetimeQuery()
+
+predicate isLifetimeQueryMetadata(Query query, string queryId, string ruleId, string category) {
+  query =
+    // `Query` instance for the `valueOfAnObjectMustNotBeReadBeforeItHasBeenSet` query
+    LifetimePackage::valueOfAnObjectMustNotBeReadBeforeItHasBeenSetQuery() and
+  queryId =
+    // `@id` for the `valueOfAnObjectMustNotBeReadBeforeItHasBeenSet` query
+    "cpp/misra/value-of-an-object-must-not-be-read-before-it-has-been-set" and
+  ruleId = "RULE-11-6-2" and
+  category = "mandatory"
+  or
+  query =
+    // `Query` instance for the `automaticStorageAssignedToObjectGreaterLifetime` query
+    LifetimePackage::automaticStorageAssignedToObjectGreaterLifetimeQuery() and
+  queryId =
+    // `@id` for the `automaticStorageAssignedToObjectGreaterLifetime` query
+    "cpp/misra/automatic-storage-assigned-to-object-greater-lifetime" and
+  ruleId = "RULE-6-8-3" and
+  category = "required"
+}
+
+module LifetimePackage {
+  Query valueOfAnObjectMustNotBeReadBeforeItHasBeenSetQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `valueOfAnObjectMustNotBeReadBeforeItHasBeenSet` query
+      TQueryCPP(TLifetimePackageQuery(TValueOfAnObjectMustNotBeReadBeforeItHasBeenSetQuery()))
+  }
+
+  Query automaticStorageAssignedToObjectGreaterLifetimeQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `automaticStorageAssignedToObjectGreaterLifetime` query
+      TQueryCPP(TLifetimePackageQuery(TAutomaticStorageAssignedToObjectGreaterLifetimeQuery()))
+  }
+}

cpp/common/src/codingstandards/cpp/exclusions/cpp/RuleMetadata.qll

@@ -45,6 +45,7 @@ import IntegerConversion
 import Invariants
 import Iterators
 import Lambdas
+import Lifetime
 import Linkage1
 import Linkage2
 import Literals
@@ -134,6 +135,7 @@ newtype TCPPQuery =
   TInvariantsPackageQuery(InvariantsQuery q) or
   TIteratorsPackageQuery(IteratorsQuery q) or
   TLambdasPackageQuery(LambdasQuery q) or
+  TLifetimePackageQuery(LifetimeQuery q) or
   TLinkage1PackageQuery(Linkage1Query q) or
   TLinkage2PackageQuery(Linkage2Query q) or
   TLiteralsPackageQuery(LiteralsQuery q) or
@@ -223,6 +225,7 @@ predicate isQueryMetadata(Query query, string queryId, string ruleId, string cat
   isInvariantsQueryMetadata(query, queryId, ruleId, category) or
   isIteratorsQueryMetadata(query, queryId, ruleId, category) or
   isLambdasQueryMetadata(query, queryId, ruleId, category) or
+  isLifetimeQueryMetadata(query, queryId, ruleId, category) or
   isLinkage1QueryMetadata(query, queryId, ruleId, category) or
   isLinkage2QueryMetadata(query, queryId, ruleId, category) or
   isLiteralsQueryMetadata(query, queryId, ruleId, category) or

cpp/common/src/codingstandards/cpp/lifetimes/CppObjects.qll

@@ -246,7 +246,7 @@ class AggregateLiteralObjectIdentity extends AggregateLiteral, ObjectIdentityBas
 }
 
 /**
- * An object identified by a call to `malloc`.
+ * An object identified by a call to `malloc` or allcoated with a `new` or `new[]` expression.
  *
  * Note: the malloc expression returns an address to this object, not the object itself. Therefore,
  * `getAnAccess()` returns cases where this malloc result is dereferenced, and not the malloc call
@@ -262,6 +262,8 @@ class AggregateLiteralObjectIdentity extends AggregateLiteral, ObjectIdentityBas
 class AllocatedObjectIdentity extends AllocationExpr, ObjectIdentityBase {
   AllocatedObjectIdentity() {
     this.(FunctionCall).getTarget().(AllocationFunction).requiresDealloc()
+    or
+    this = any(NewOrNewArrayExpr new | not exists(new.getPlacementPointer()))
   }
 
   override StorageDuration getStorageDuration() { result.isAllocated() }