clean up outputs for 'noopMode'

Author: GrantBirki

__tests__/main.test.js

@@ -119,14 +119,14 @@ test('successfully runs the action', async () => {
   expect(setOutputMock).toHaveBeenCalledWith('triggered', 'true')
   expect(setOutputMock).toHaveBeenCalledWith('comment_id', 123)
   expect(setOutputMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(setOutputMock).toHaveBeenCalledWith('noop', 'false')
+  expect(setOutputMock).toHaveBeenCalledWith('noop', false)
   expect(setOutputMock).toHaveBeenCalledWith('continue', 'true')
   expect(saveStateMock).toHaveBeenCalledWith('isPost', 'true')
   expect(saveStateMock).toHaveBeenCalledWith('actionsToken', 'faketoken')
   expect(saveStateMock).toHaveBeenCalledWith('environment', 'production')
   expect(saveStateMock).toHaveBeenCalledWith('comment_id', 123)
   expect(saveStateMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(saveStateMock).toHaveBeenCalledWith('noop', 'false')
+  expect(saveStateMock).toHaveBeenCalledWith('noop', false)
   expect(setOutputMock).toHaveBeenCalledWith('type', 'deploy')
   expect(saveStateMock).toHaveBeenCalledWith('deployment_id', 123)
   expect(debugMock).toHaveBeenCalledWith('production_environment: true')
@@ -144,14 +144,14 @@ test('successfully runs the action on a deployment to development', async () =>
   expect(setOutputMock).toHaveBeenCalledWith('triggered', 'true')
   expect(setOutputMock).toHaveBeenCalledWith('comment_id', 123)
   expect(setOutputMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(setOutputMock).toHaveBeenCalledWith('noop', 'false')
+  expect(setOutputMock).toHaveBeenCalledWith('noop', false)
   expect(setOutputMock).toHaveBeenCalledWith('continue', 'true')
   expect(saveStateMock).toHaveBeenCalledWith('isPost', 'true')
   expect(saveStateMock).toHaveBeenCalledWith('actionsToken', 'faketoken')
   expect(saveStateMock).toHaveBeenCalledWith('environment', 'development')
   expect(saveStateMock).toHaveBeenCalledWith('comment_id', 123)
   expect(saveStateMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(saveStateMock).toHaveBeenCalledWith('noop', 'false')
+  expect(saveStateMock).toHaveBeenCalledWith('noop', false)
   expect(setOutputMock).toHaveBeenCalledWith('type', 'deploy')
   expect(saveStateMock).toHaveBeenCalledWith('deployment_id', 123)
   expect(debugMock).toHaveBeenCalledWith('production_environment: false')
@@ -174,15 +174,15 @@ test('successfully runs the action in noop mode', async () => {
   expect(setOutputMock).toHaveBeenCalledWith('triggered', 'true')
   expect(setOutputMock).toHaveBeenCalledWith('comment_id', 123)
   expect(setOutputMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(setOutputMock).toHaveBeenCalledWith('noop', 'true')
+  expect(setOutputMock).toHaveBeenCalledWith('noop', true)
   expect(setOutputMock).toHaveBeenCalledWith('continue', 'true')
   expect(setOutputMock).toHaveBeenCalledWith('type', 'deploy')
   expect(saveStateMock).toHaveBeenCalledWith('isPost', 'true')
   expect(saveStateMock).toHaveBeenCalledWith('actionsToken', 'faketoken')
   expect(saveStateMock).toHaveBeenCalledWith('environment', 'production')
   expect(saveStateMock).toHaveBeenCalledWith('comment_id', 123)
   expect(saveStateMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(saveStateMock).toHaveBeenCalledWith('noop', 'true')
+  expect(saveStateMock).toHaveBeenCalledWith('noop', true)
 })
 
 test('runs the action in lock mode and fails due to bad permissions', async () => {
@@ -568,15 +568,15 @@ test('successfully runs the action with required contexts', async () => {
   expect(setOutputMock).toHaveBeenCalledWith('triggered', 'true')
   expect(setOutputMock).toHaveBeenCalledWith('comment_id', 123)
   expect(setOutputMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(setOutputMock).toHaveBeenCalledWith('noop', 'false')
+  expect(setOutputMock).toHaveBeenCalledWith('noop', false)
   expect(setOutputMock).toHaveBeenCalledWith('continue', 'true')
   expect(setOutputMock).toHaveBeenCalledWith('type', 'deploy')
   expect(saveStateMock).toHaveBeenCalledWith('isPost', 'true')
   expect(saveStateMock).toHaveBeenCalledWith('actionsToken', 'faketoken')
   expect(saveStateMock).toHaveBeenCalledWith('environment', 'production')
   expect(saveStateMock).toHaveBeenCalledWith('comment_id', 123)
   expect(saveStateMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(saveStateMock).toHaveBeenCalledWith('noop', 'false')
+  expect(saveStateMock).toHaveBeenCalledWith('noop', false)
 })
 
 test('detects an out of date branch and exits', async () => {
@@ -607,14 +607,14 @@ test('detects an out of date branch and exits', async () => {
   expect(setOutputMock).toHaveBeenCalledWith('triggered', 'true')
   expect(setOutputMock).toHaveBeenCalledWith('comment_id', 123)
   expect(setOutputMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(setOutputMock).toHaveBeenCalledWith('noop', 'false')
+  expect(setOutputMock).toHaveBeenCalledWith('noop', false)
   expect(setOutputMock).toHaveBeenCalledWith('type', 'deploy')
   expect(saveStateMock).toHaveBeenCalledWith('isPost', 'true')
   expect(saveStateMock).toHaveBeenCalledWith('actionsToken', 'faketoken')
   expect(saveStateMock).toHaveBeenCalledWith('environment', 'production')
   expect(saveStateMock).toHaveBeenCalledWith('comment_id', 123)
   expect(saveStateMock).toHaveBeenCalledWith('ref', 'test-ref')
-  expect(saveStateMock).toHaveBeenCalledWith('noop', 'false')
+  expect(saveStateMock).toHaveBeenCalledWith('noop', false)
   expect(saveStateMock).toHaveBeenCalledWith('bypass', 'true')
 })
 

dist/index.js

@@ -485,19 +485,17 @@ export async function run() {
     })
 
     // Set outputs for noopMode
-    var noop
     if (precheckResults.noopMode) {
-      noop = 'true'
-      core.setOutput('noop', noop)
+      core.setOutput('noop', precheckResults.noopMode)
       core.setOutput('continue', 'true')
-      core.saveState('noop', noop)
+      core.saveState('noop', precheckResults.noopMode)
       core.info('noop mode detected')
-      // If noop mode is enabled, return
+
+      // If noop mode is enabled, return here
       return 'success - noop'
     } else {
-      noop = 'false'
-      core.setOutput('noop', noop)
-      core.saveState('noop', noop)
+      core.setOutput('noop', precheckResults.noopMode)
+      core.saveState('noop', precheckResults.noopMode)
     }
 
     // Get required_contexts for the deployment