feat(routing): Prefix convertter as test-only

It was annotated initially as such, but the annotation was droppped.
Add the annotation back again and use the Prefix associated method
try_from_tuple() in gRPC as this was causing a panic when feeding
bad prefixes.

Signed-off-by: Fredi Raspall <[email protected]>

Author: Fredi-raspall

mgmt/src/grpc/converter.rs

@@ -492,13 +492,17 @@ pub fn convert_expose_from_grpc(expose: &gateway_config::Expose) -> Result<VpcEx
                     // Parse CIDR into IP and netmask
                     let (ip_str, netmask) = parse_cidr(cidr)?;
                     // Add as an include rule
-                    vpc_expose = vpc_expose.ip(Prefix::from((ip_str.as_str(), netmask)));
+                    vpc_expose = vpc_expose.ip(Prefix::try_from_tuple((ip_str.as_str(), netmask))
+                        .map_err(|e| e.to_string())?);
                 }
                 gateway_config::config::peering_i_ps::Rule::Not(not) => {
                     // Parse CIDR into IP and netmask for exclude rule
                     let (ip_str, netmask) = parse_cidr(not)?;
                     // Add as an exclude rule
-                    vpc_expose = vpc_expose.not(Prefix::from((ip_str.as_str(), netmask)));
+                    vpc_expose = vpc_expose.not(
+                        Prefix::try_from_tuple((ip_str.as_str(), netmask))
+                            .map_err(|e| e.to_string())?,
+                    );
                 }
             }
         } else {
@@ -514,13 +518,19 @@ pub fn convert_expose_from_grpc(expose: &gateway_config::Expose) -> Result<VpcEx
                     // Parse CIDR into IP and netmask
                     let (ip_str, netmask) = parse_cidr(cidr)?;
                     // Add as an include rule for AS
-                    vpc_expose = vpc_expose.as_range(Prefix::from((ip_str.as_str(), netmask)));
+                    vpc_expose = vpc_expose.as_range(
+                        Prefix::try_from_tuple((ip_str.as_str(), netmask))
+                            .map_err(|e| e.to_string())?,
+                    );
                 }
                 gateway_config::config::peering_as::Rule::Not(ip_exclude) => {
                     // Parse CIDR into IP and netmask for exclude rule
                     let (ip_str, netmask) = parse_cidr(ip_exclude)?;
                     // Add as an exclude rule for AS
-                    vpc_expose = vpc_expose.not_as(Prefix::from((ip_str.as_str(), netmask)));
+                    vpc_expose = vpc_expose.not_as(
+                        Prefix::try_from_tuple((ip_str.as_str(), netmask))
+                            .map_err(|e| e.to_string())?,
+                    );
                 }
             }
         } else {

routing/src/prefix.rs

@@ -171,6 +171,7 @@ impl From<Ipv6Prefix> for Prefix {
 }
 
 /// Only for testing. Will panic with badly formed address strings
+#[cfg(test)]
 impl From<(&str, u8)> for Prefix {
     fn from(tuple: (&str, u8)) -> Self {
         let a = IpAddr::from_str(tuple.0).expect("Bad address");