Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalizeContent breaks classes next to .table #610

Open
splitbrain opened this issue Jul 17, 2024 · 0 comments
Open

normalizeContent breaks classes next to .table #610

splitbrain opened this issue Jul 17, 2024 · 0 comments
Labels
bug

Comments

@splitbrain
Copy link

Description

The handling for .table -> .table-responsive drops all other classes:

dokuwiki-template-bootstrap3/Template.php

Line 1550 in c113bae

$elm->class = 'table-responsive';

Steps to reproduce

Original HTML:

<div class="table other class">

Expected behavior:

<div class="table-responsive other class">

Actual behavior:

<div class="table-responsive">

Versions

  • Bootstrap3 Template: 2024-02-06
  • DokuWiki: master
@splitbrain splitbrain added the bug label Jul 17, 2024
splitbrain added a commit to cosmocode/dokuwiki-plugin-structgantt that referenced this issue Jul 17, 2024
@splitbrain
workaround for bootstrap3 bug
905e932 
The bootstrap3 template runs a "normalizeContent" function over all
DokuWiki content HTML to rewrite it into bootstrap styling.

When encountering an element with the class .table it will replace all
classes of this element with .table-responsive, throwing away all other
classes, breaking any set styles:

giterlizzi/dokuwiki-template-bootstrap3#610

This "fixes" the problem by moving the .table style to its own element,
thus keeping the scope classes intact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@splitbrain