Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading 1 top margin is reduced after update. How much? #607

Closed
suedunham opened this issue Feb 8, 2024 · 1 comment
Closed

Heading 1 top margin is reduced after update. How much? #607

suedunham opened this issue Feb 8, 2024 · 1 comment
Labels

Comments

@suedunham
Copy link

Description

After installing the 2024-02-06 version, The top margin of the heading 1 element at the top of a page has been reduced so that it displays higher on the page. This isn't bad per se, but it does muck up some formatting I had up there, and I'd like to know what accounts for the change.

Steps to reproduce

  1. Screencap a page with a Heading 1 element in a wiki with the previous version of bootstrap3.
  2. Update bootstrap3.
  3. Compare page with screencap.

Expected behavior: I expected no change in the spacing.

Actual behavior: The top margin of the Heading 1 element is reduced.

Versions

  • [Bootstrap3 Template] stable/20240206
  • [DokuWiki] 2024-02-06 "Kaos"
  • [PHP] 7.4.33
  • [Browser] Chrome 121.0.6167.140 (Official Build) (64-bit)

Screenshots or Logs

These screencaps were made in a customized template with additional css formatting. This formatting serves to highlight the effect, so I've gone ahead with it. I have confirmed that an unmodified bootstrap3 template exhibits the same behavior.

Before
bs3_margin_before

After
bs3_margin_after

Note

I'm OK with the change, but I'd like to know what the change was. I assume that a bootstrap3 margin class can be added, where need be. What is prompting this is more page content I've placed above the heading that is now too close.

bs3_margin_icons

@suedunham suedunham added the bug label Feb 8, 2024
giterlizzi added a commit that referenced this issue Oct 8, 2024
@giterlizzi
Copy link
Owner

FIXED in master.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants