-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap3 not compatible with current tagfilter-plugin #600
Comments
Concerning the tagfilter plugin: I thought it should work for any template. Sorry, couldn't reproduce your issue with "Jack Jackrum" and Chrome Browser.
|
When I double the "{{tagfilter..."-line to
I get "everything" twice, but then it displays the tagged pages as intended. ONE FURTHER REMARK: If I change in configuration "plugin»pagelist»style" in pagelist to simple list, it seems to work as intended, too. |
Thank You for your detailed explanation. |
Quick solution: edit tagfilter's lib/plugins/tagfilter/script.js Line 118, remove the class from the div so that I have made a Pull Request to the tagfilter plugin: lisps/tagfilter#33 |
1.) Yes, all others do not work One question of mine: Could you now experience/reproduce the behaviour/mistake by yourself? Later: I applied your "quick solution" to a copied wiki and it seems to work. Thanks again! |
I can tell you the cause. I myself had made a PR to the tagfilter plugin that introduced support for including whole pages with the include plugin.
|
I think the ticket can be closed when my tagfilter PR gets accepted there. |
Description
Updated tagfilter does not filter the tags in bootstrap, but displays all tagged pages.
Steps to reproduce
Install and configure tagfilter
Expected behavior: I expect that only tagged entries are shown which I wanted to be shown by choosing the desired tag with tagfilter.
Actual behavior: All entries of all tagged pages are displayed. With dokuwiki-template everything works as intended. You might also have a look at the thread at issues at tagfilter: [https://github.com/lisps/tagfilter/issues/29] There is a work-around to replace code in tagfilter/script.js at line 116 to the old code.
Versions
Screenshots or Logs
[Paste your logs or attach the screenshot]
Sample page or snippet
[Paste your sample DokuWiki page or snippet using MarkDown code syntax]
BTW: I saw that I judged it to be a bug; I do not know whether this is a bug (or whether I am just stupid, Do not ask my wife) but do not know how to undo this classification ;-)
The text was updated successfully, but these errors were encountered: