Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant message if only one network #3604

Closed
marsrobertson opened this issue Aug 16, 2024 · 3 comments · Fixed by #3720
Closed

Redundant message if only one network #3604

marsrobertson opened this issue Aug 16, 2024 · 3 comments · Fixed by #3720
Assignees

Comments

@marsrobertson
Copy link

marsrobertson commented Aug 16, 2024

  1. Add grant on Optimism and Arbitrum
  2. Remove Optimism
  3. Checkout

EDIT / UPDATE: even simpler repro steps:

  1. Add grant on Arbitrum
  2. Checkout

(previously I was thinking that adding multiple networks sets multiple_networks = true but possible to repro with single network only)


This message is redundant / confusing:

Checkout all your carts across different networks or select the cart you wish to checkout now.

image
Copy link

linear bot commented Aug 16, 2024

@Ronexlemon
Copy link
Contributor

can i be assign?

@eben619
Copy link
Contributor

eben619 commented Oct 29, 2024

@marsrobertson @MasterHW I'm not sure if this is the fix you are looking for? But does this address the issue?
This is a cart with contributions on more than one network.

Screenshot 2024-10-29 115422

So it rightly displays the message on the modal at checkout.

Screenshot 2024-10-29 115524

The changes i've made:

Screenshot 2024-10-29 115615

Conditional rendering of the message on the modal such that it does not display if the networks being chaecked out in the cart are not more than 1. Even if there are multiple projects in the cart but are on the same network.

Screenshot 2024-10-29 115645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants