Fix double click on header to expand window (#650)

mattia · web-flow · commit bed14b69c2ba · 2020-02-10T09:26:13.000-08:00
In the `hitTest` of the toolbar item view we need to continue the loop iteration when we find a `NSTextField` but it not enabled and selectable Fixes #556
diff --git a/GitUp/Application/ToolbarItemWrapperView.m b/GitUp/Application/ToolbarItemWrapperView.m
@@ -27,6 +27,9 @@ - (NSView*)hitTest:(NSPoint)point {
       if (field.enabled && field.selectable) {
         return hit;
       }
+
+      // We recognised the view but it is not enabled and selectable, so we need to break this loop iteration
+      continue;
     }
 
     if ([child isKindOfClass:[NSControl class]]) {

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,9 @@ - (NSView*)hitTest:(NSPoint)point {`
`27`	`27`	`if (field.enabled && field.selectable) {`
`28`	`28`	`return hit;`
`29`	`29`	`}`
	`30`	`+`
	`31`	`+ // We recognised the view but it is not enabled and selectable, so we need to break this loop iteration`
	`32`	`+ continue;`
`30`	`33`	`}`
`31`	`34`
`32`	`35`	`if ([child isKindOfClass:[NSControl class]]) {`