Detect Java in Gradle projects regardless of build script DSL#87
Open
andrew wants to merge 1 commit into
Open
Conversation
The default extension scan stopped at depth 4, which misses app/src/main/java/<pkg>/ in the layout that gradle init produces, so **/*.java found nothing and the ecosystem gate then filtered out Gradle itself. At the same time *.kts in Kotlin's detect.files matched settings.gradle.kts at the root and reported the project as Kotlin. Replace the depth bound with a 10000-file cap (ScanDepth still applies when set explicitly), drop Gradle build script patterns from the Java and Kotlin language definitions, and add testdata to skipDirs so fixture source does not leak into the host project's language list. Fixes #84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh
gradle initJava project was reported as Kotlin (Kotlin DSL) or as nothing at all (Groovy DSL).Two things were going wrong. The extension scan in
loadFileExtsstopped at directory depth 4, soapp/src/main/java/org/example/App.javawas never reached and**/*.javafound nothing; with no JVM language detected the ecosystem gate then filtered out Gradle even thoughsettings.gradlewas sitting at the root. Separately, Kotlin'sdetect.filesincluded*.kts, which globbedsettings.gradle.ktsand claimed the project as Kotlin.This replaces the depth-4 default with a 10000-file cap so deep package paths are reached while the walk stays bounded on large trees (
-scan-depthstill applies when set explicitly). Gradle build script patterns are dropped from the Java and Kotlin language definitions since a Gradle build script says nothing about which JVM language the source is in.testdatais added toskipDirsso the new.javafixtures do not leak into the host project's language list.Fixes #84.