Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Official" Dark Mode for Git GUI #3433

Closed
1 task done
Sashank999 opened this issue Sep 21, 2021 · 10 comments
Closed
1 task done

"Official" Dark Mode for Git GUI #3433

Sashank999 opened this issue Sep 21, 2021 · 10 comments

Comments

@Sashank999
Copy link

  • I was not able to find an open or closed issue matching what I'm seeing.

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
$ git --version --build-options

git version 2.33.0.windows.2
cpu: x86_64
built from commit: 8735530946cced809cc6cc4c2ca3b078cdb3dfc8
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
$ cmd.exe /c ver

Microsoft Windows [Version 10.0.19043.1237]
  • What options did you set as part of the installation? Or did you choose the
    defaults?
$ type "C:\Program Files\Git\etc\install-options.txt"

Editor Option: Notepad++
Custom Editor Path:
Default Branch Option:
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: WinSSL
CRLF Option: CRLFAlways
Bash Terminal Option: ConHost
Git Pull Behavior Option: Merge
Use Credential Manager: Core
Performance Tweaks FSCache: Enabled
Enable Symlinks: Disabled
Enable Pseudo Console Support: Disabled
Enable FSMonitor: Disabled
  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

None.

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other
I usually run Git GUI itself.
But when I don't find the Git CLI command in Git GUI's options, I will use Git Bash from Git GUI `Repository` menu bar.
It isn't actually an issue. But rather a suggestion (or maybe an info gathering, if this is already implemented).

Is there dark mode for Git GUI ? No, I am not asking for ways to edit those .tcl files.
I tried that. Got myself comfortable with the whole page. But still, the menu bar and the window title bar remain white. And that frustates me a bit.

I have searched in Github Issues and Google Groups for the keyword dark but got no results I hoped so I'm posting this.

I'm a JS developer. But, I know a little bit of TCL and Tk and happily customised the About page like this. So, I think I can help. Just give me the Ok and I will go ahead.

image

@PhilipOakley
Copy link

The git-gui is now maintained by Pratyush Yadav and there are already discussions about dark theme on his page/repo https://github.com/prati0100/git-gui/issues/

It's worth discussing it over there. Git for Windows picks up the latest git-gui from there.

@Sashank999
Copy link
Author

Okay. I will discuss it there.
Issue prati0100/git-gui#64 .

@Sashank999
Copy link
Author

Discussion happening in Git Mailing List here: https://marc.info/?l=git&m=163266898221849&w=2 .

@birgersp
Copy link

birgersp commented Dec 13, 2021

The git-gui is now maintained by Pratyush Yadav and there are already discussions about dark theme on his page/repo https://github.com/prati0100/git-gui/issues/

It's worth discussing it over there. Git for Windows picks up the latest git-gui from there.

@PhilipOakley

Shouldn't the installer for git for windows have some dark ttk themes packed with it? Wouldn't that be something that needs to be implemented here (in this repo)?

@hehuahuang

This comment has been minimized.

@dscho
Copy link
Member

dscho commented Dec 20, 2021

Shouldn't the installer for git for windows have some dark ttk themes packed with it?

@birgersp I don't know. Do you? Did you find out how Tcl/Tk handles dark themes? If so, can you open a Pull Request to add one?

@birgersp
Copy link

I don't. Not yet. Btw we were discussing it a little on the git-gui repo

prati0100/git-gui#64

@Sashank999
Copy link
Author

Sashank999 commented Dec 24, 2021

@dscho I have already created a way to make Tk theming in Git GUI dark on Windows. I didn't try it on Linux. Only the Title Bar is left. You can check the mailing list: https://marc.info/?l=git&m=164010323505120&w=2 .

It is not configurable. I will work on making it configurable after I find how to make the title bar black on all Windows versions starting from atleast Windows 7.

BTW, can you please link where the source for git-gui.exe is ? It is there in the standard Windows installation but I can't find its source code.

@rimrul
Copy link
Member

rimrul commented Dec 24, 2021

BTW, can you please link where the source for git-gui.exe is ? It is there in the standard Windows installation but I can't find its source code.

https://github.com/git-for-windows/MINGW-packages/blob/main/mingw-w64-git/git-wrapper.c

@dscho
Copy link
Member

dscho commented Jan 9, 2022

I will work on making it configurable

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants