Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically close the latest milestone upon release #7

Open
dscho opened this issue Dec 12, 2022 · 2 comments
Open

Automatically close the latest milestone upon release #7

dscho opened this issue Dec 12, 2022 · 2 comments

Comments

@dscho
Copy link
Member

dscho commented Dec 12, 2022

When a release creates a tag that points to the PR branch of a still-open "Rebase to "-class PR, we know that the branch should be pushed and the milestone should be closed out and a new "Next release" milestone should be opened.

Totally automatable.
@dscho
Copy link
Member Author

dscho commented Feb 23, 2024

#66 took care of pushing the main branch.

dscho added a commit to dscho/gfw-helper-github-app that referenced this issue Feb 23, 2024
@dscho
WIP: Automatically close Git for Windows' milestones after a release
43fe8b7 
This is a work in progress! The idea is that as part of closing a `[New
git release]` ticket that is associated with a Git for Windows release,
we will close the current milestone and open the next one. The current
work-in-progress script was used to successfully close the v2.44.0
milestone and open the `Next release` one. So what's missing? This:

- The current script needs to be replaced by a proper route in
  `index.js`

- More validations are needed, so that we do not close, say, a milestone
  that does not even have any issues assigned to it. Or a milestone that
  is for another version.

- Tests.

This will address
git-for-windows#7.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho mentioned this issue Feb 23, 2024
Draft
@dscho
Copy link
Member Author

dscho commented Jul 15, 2024

The main branch is now pushed, as of #66. This part is technically a bit different from closing the latest milestone and opening a new one because the main branch also needs to be pushed for -rc versions while the milestone needs to stay open for those.

@dscho dscho changed the title Automatically push main and close the latest milestone upon release Automatically close the latest milestone upon release Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dscho