release 2.1.13 does not expose git.* properties to the pom

[roytmana]

neither in filtered resources or other places git.* properties are resolved. had to revert to build 2.1.12

[TheSnoozer]

Hi,
the version 2.1.13 works fine on my side.
Can you post your current configuration?

Thanks,

[roytmana]

I am running Maven 3.2.5

<plugin>
        <!-- https://github.com/ktoso/maven-git-commit-id-plugin -->
        <groupId>pl.project13.maven</groupId>
        <artifactId>git-commit-id-plugin</artifactId>
        <version>2.1.13</version>
        <executions>
          <execution>
            <goals>
              <goal>revision</goal>
            </goals>
          </execution>
        </executions>
        <configuration>
          <dateFormat>yyyy-MM-dd HH:mm:ss z</dateFormat>
          <verbose>true</verbose>
          <dotGitDirectory>${project.basedir}/../.git</dotGitDirectory>
          <generateGitPropertiesFile>true</generateGitPropertiesFile>
          <generateGitPropertiesFilename>target/classes/version.properties</generateGitPropertiesFilename>
          <failOnNoGitDirectory>false</failOnNoGitDirectory>
          <skip>false</skip>
          <excludeProperties>
            <excludeProperty>git.remote.*</excludeProperty>
          </excludeProperties>
          <abbrevLength>8</abbrevLength>
          <gitDescribe>
            <skip>false</skip>
            <always>false</always>
            <abbrev>8</abbrev>
            <dirty>-dirty</dirty>
            <forceLongFormat>false</forceLongFormat>
          </gitDescribe>
        </configuration>
      </plugin>

[TheSnoozer]

I can reproduce the behavior and I think is intential.
If you add the option to the config it should work fine:

<configuration>
  ...
  <injectAllReactorProjects>true</injectAllReactorProjects>
  ...
</configuration>

I just realized that someone else had a similar problem:
#159

[TheSnoozer]

Hi @roytmana,
I just wanted to check if the suggested configuration option fixed your problem.

Thanks,

[roytmana]

yes it does thank you but I am wondering if it should not be default as the props do not get exposed even with a simple single module project breaking plugin's backward compatibility

[TheSnoozer]

Well the problem get's complicated when you have a multi-pom project with different git-projects.

The issue is related to:
#177
#159
#108
and was fixed with
#157

I somehow agree that it breaks plugins backward compatibility but overwriting properties that the plugin is not supposed to overwrite is a no go.
However, this should be added to the readme (as already discussed in the other issues).

[TheSnoozer]

Hi,
the <injectAllReactorProjects>-Property was added to the README (PR #187).
I also outline why we need to set it to false and therefore somehow break backwards compatibility.

If you feel that your issue is not yet resolved, please reopen the issue and share your concerns.

Thanks for reporting.