Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create docker images for compilation on github actions #16

Open
gisogrimm opened this issue Oct 15, 2020 · 2 comments
Open

create docker images for compilation on github actions #16

gisogrimm opened this issue Oct 15, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@gisogrimm
Copy link
Owner

the github actions for ov-client use the default github runners. It would be much better to have specialized docker images with the required tools preinstalled

@viktorpergjoka
Copy link

Do you mean to have as a result something like this:
FROM ovimage
.....
RUN ...
ENTRYPOINT [...]

where ovimage(or whatever name) is something which has all the necessary packages/tools installed so that you can derive from it?

If I look at your docker images, they are just doing some make. So if you build the image and run it via docker run they are exiting immediately after the make command.
Maybe a docker image which starts the client would benefit more?

@gisogrimm
Copy link
Owner Author

We need the dockerimages for building (and packaging, and maybe separate ones for a deployment test of the packages), but not to deploy the the ov-client.
The specialized docker images would be needed mostly to have the correct build environment (and more build environments than github supports with its standard runners out of the box).

@gisogrimm gisogrimm added the enhancement New feature or request label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants