Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @toast-ui/calendar v.2.1.3 #48

Open
KevinKrueger opened this issue Feb 24, 2024 · 24 comments
Open

Upgrade to @toast-ui/calendar v.2.1.3 #48

KevinKrueger opened this issue Feb 24, 2024 · 24 comments
Assignees
Labels
display/ui Display or UI issue - not necessarily a bug. status: needs information status: needs testing Most of the work is done, but needs testing. type: feature New feature or request
Milestone

Comments

@KevinKrueger
Copy link
Collaborator

No description provided.

@KevinKrueger KevinKrueger changed the title Update to @toast-ui/calendar v.2.1.3 Upgrade to @toast-ui/calendar v.2.1.3 Feb 24, 2024
@gismofx
Copy link
Owner

gismofx commented Feb 24, 2024

Thanks! Should be simple to do :).. unless...Are there any new features or API changes on the toast calendar side?

@gismofx gismofx self-assigned this Feb 24, 2024
@KevinKrueger
Copy link
Collaborator Author

Not that is would know.

It would be important to me that this also works well for WASM without server-side.

@KevinKrueger
Copy link
Collaborator Author

Of course a 1.0.0 version would also be cool :)

@KevinKrueger
Copy link
Collaborator Author

I use MudBlazor and I noticed that when I press Edit in the popup for an appointment, it reloads the page.

@KevinKrueger
Copy link
Collaborator Author

It would be great if we could get Syncfusion, Devexpress and Telerik to drop their jaws. They have stupid license models.

@gismofx
Copy link
Owner

gismofx commented Feb 24, 2024

I use MudBlazor and I noticed that when I press Edit in the popup for an appointment, it reloads the page.

Can you upload a self-contained project that reproduces this error? I can take a look. I also use MudBlazor. Also, please open a new issue for this.

@gismofx
Copy link
Owner

gismofx commented Feb 24, 2024

Not that is would know.

It would be important to me that this also works well for WASM without server-side.

Should work just fine with WASM too.

@KevinKrueger
Copy link
Collaborator Author

Okay, i created a new Empty site and use your test code and it works now XD

@KevinKrueger
Copy link
Collaborator Author

I have already gone through it with the debugger. Nothing conspicuous.

@gismofx gismofx added the type: feature New feature or request label Feb 24, 2024
@gismofx
Copy link
Owner

gismofx commented Feb 24, 2024

Ref V2 Migration guide:
https://github.com/nhn/tui.calendar/blob/main/docs/en/guide/migration-guide-v2.md

I'll make branch for V2. Looks like there are some nice changes/improvements, but will take a little work to update everything. It should be minimal changes to the C# Side.

@KevinKrueger
Copy link
Collaborator Author

Thank you from the bottom of my heart <3
You're saving my ass in the world of not having a proper solution for Blazor.

I am available for extensive testing at any time.

@gismofx
Copy link
Owner

gismofx commented Feb 24, 2024

Thank you from the bottom of my heart <3 You're saving my ass in the world of not having a proper solution for Blazor.

Of course! It's the least I can do for the open source community.

I am available for extensive testing at any time.

This will be helpful! Thanks

@gismofx
Copy link
Owner

gismofx commented Feb 25, 2024

I've begun the conversion. NPM Packages are updated, updated options classes, and the project builds and the test project starts. No runtime errors, but there are display/rendering issues. Not sure where they are coming from. I'll share the branch tomorrow. Could be a CSS issue. More to come.

@KevinKrueger
Copy link
Collaborator Author

You are a machine!

@KevinKrueger
Copy link
Collaborator Author

Am I mistaken or have they now added a toolbar to the calendar or is it just something they developed themselves?

@KevinKrueger
Copy link
Collaborator Author

I have comitted my changes (Pull-Request "Update & Create Schedule") which somehow disturbed me in the development.
#53

@gismofx
Copy link
Owner

gismofx commented Feb 25, 2024

@KevinKrueger I pushed up DevV2 branch. Have a look. I think a few of the changes in your commit are covered in this branch. Maybe you can re-apply your changes on this branch.
Month view looks like this and I don't know why.
image

@KevinKrueger
Copy link
Collaborator Author

KevinKrueger commented Feb 25, 2024

@gismofx Cooooool :) . Looks like a css problem.

I think it would be easier to accept my pull request and make a merge in V2.
// TODO: V2 is marked

@KevinKrueger
Copy link
Collaborator Author

#55 You need to merge it (has 1 conflict) @gismofx

@gismofx
Copy link
Owner

gismofx commented Feb 25, 2024

Merged. Have a look. Maybe you can dig into the display issue?

@KevinKrueger
Copy link
Collaborator Author

I would like to open a better communication channel. What do you think of Slack? Or do you have another suggestion for better communication?

@KevinKrueger
Copy link
Collaborator Author

The first problem I had was that it was suddenly called TUIEvent instead of TUISchedule.
The second problem is that pulling the length of the appointments no longer works.
The third problem is then logically the wrong display of the month view

@KevinKrueger
Copy link
Collaborator Author

And my changes are not there.

@gismofx
Copy link
Owner

gismofx commented Feb 25, 2024

I sent you a discord link to your email in your profile. I believe a lot of your changes were absorbed within the changes I made. Overall, it's about the same.

@KevinKrueger KevinKrueger added this to the v.1.0.0 milestone Feb 25, 2024
@KevinKrueger KevinKrueger added display/ui Display or UI issue - not necessarily a bug. status: needs information status: needs testing Most of the work is done, but needs testing. labels Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
display/ui Display or UI issue - not necessarily a bug. status: needs information status: needs testing Most of the work is done, but needs testing. type: feature New feature or request
Projects
Status: In progress
Development

No branches or pull requests

2 participants