Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-compose (Dockerfile) broken on main #125

Open
shai-ikko opened this issue Jan 29, 2025 · 0 comments · May be fixed by #126
Open

docker-compose (Dockerfile) broken on main #125

shai-ikko opened this issue Jan 29, 2025 · 0 comments · May be fixed by #126

Comments

@shai-ikko
Copy link

shai-ikko commented Jan 29, 2025 •
edited
Loading

I want to try out setting up a slicer-package-manager, and the docker-compose is not working.

This may be a duplicate issue for #79, but it seems that issue is more about including docker-compose in CI.
Also the closed #73 may be related, but probably not, as this is about main.

What seems actually broken is the Dockerfile -- it refers to files MANIFEST.in and setup.cfg which no longer exist. Also, the base docker girder-3.1.0-py3 is a bit ancient.

I'll have some fix suggestions soon.
shai-ikko added a commit to shai-ikko/slicer_package_manager that referenced this issue Jan 29, 2025
@shai-ikko
BUG: Fix Dockerfile to make docker-compose work
4ad95d9 
Remove references to non-existent MANIFEST.in and setup.cfg.
Include now-required pyproject.toml instead.

This version of pyproject.toml also defines "tests" as an
included package, so include that in the docker as well.

While at it, update base girder docker image.

Refs girder#125
@shai-ikko shai-ikko linked a pull request Jan 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Fix docker compose shai-ikko/slicer_package_manager
1 participant
@shai-ikko