Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default-feil er ikke på liste av feil i gramchecker #110

Open
ilm024 opened this issue Feb 5, 2025 · 10 comments
Open

Default-feil er ikke på liste av feil i gramchecker #110

ilm024 opened this issue Feb 5, 2025 · 10 comments
Assignees
@dylanhand @lynnda-hill

Comments

@ilm024
Copy link
Contributor

ilm024 commented Feb 5, 2025

Feil som er "defaults" dukker ikke opp på listen over feil.

Dette er veldig irriterende, da man ikke kan slå av slike feil.

Image
@snomos
Copy link
Member

snomos commented Feb 5, 2025

Dette kan eg ikkje svara på, det er meir eit spørsmål for @unhammer 🙂

@snomos snomos assigned unhammer and lynnda-hill and unassigned lynnda-hill and snomos Feb 5, 2025
@ilm024 ilm024 mentioned this issue Feb 6, 2025
Open
@unhammer
Copy link
Contributor

unhammer commented Feb 7, 2025

This is a job for divvun-gramcheck-web.

The extension (or its backend) must read errors.xml and for each //defaults/default, grab all the patterns from ./ids/re@v, and if the default of that @type is ticked, exclude errors that match that pattern.

@ilm024
Copy link
Contributor Author

ilm024 commented Feb 12, 2025

Hvem gjør divvun-gramcheck-web? @lynnda-hill?

@snomos
Copy link
Member

snomos commented Feb 12, 2025

Det er @bbqsrc et co som har andsvaret for den koden.

@ilm024 ilm024 assigned bbqsrc and unassigned unhammer Feb 12, 2025
@bbqsrc bbqsrc assigned dylanhand and unassigned bbqsrc Feb 12, 2025
@bbqsrc
Copy link
Member

bbqsrc commented Feb 12, 2025

@dylanhand work out where the list is even coming from right now. I would guess it is hardcoded somewhere. Then point me where that is and I can suggest next steps.

@ilm024
Copy link
Contributor Author

ilm024 commented Feb 12, 2025

lang-smj/tools/grammarcheckers/errors.source.xml

@bbqsrc
Copy link
Member

bbqsrc commented Feb 12, 2025

Not the .xml file. The list that is present in the UI right now is from somewhere hardcoded in the add-in.

@unhammer
Copy link
Contributor

unhammer commented Feb 12, 2025 •
edited
Loading

Note: lang-smj/tools/grammarcheckers/errors.source.xml gets compiled into errors.xml  – this file is included in the zcheck package which is just a zip file.

$ unzip -l /usr/share/voikko/4/smj.zcheck |grep rs
    27372  2025-02-12 03:15   errors.xml

I think this is divvun/divvun-api#17

@dylanhand
Copy link

@bbqsrc the error list UI for the Google Docs plugin is here:
https://github.com/divvun/divvun-gramcheck-web/blob/658fe23bb210a8d26d47777084306822af3b88ee/google/preferences.html#L17-L22

It gets errorTags from divvun-api via this call:
https://github.com/divvun/divvun-gramcheck-web/blob/658fe23bb210a8d26d47777084306822af3b88ee/google/grammarcheck.ts#L212-L223

The url for the call is ${apiUrl}preferences/grammar/${selectedLanguage}.

MS Office is effectively the same.

@snomos
Copy link
Member

snomos commented Feb 12, 2025

This call:

curl -s -X GET -H 'Content-Type: application/json' \ 
     'https://api-giellalt.uit.no/preferences/grammar/se'

returns a 404:

<html>
<head><title>404 Not Found</title></head>
<body>
<center><h1>404 Not Found</h1></center>
<hr><center>nginx/1.24.0 (Ubuntu)</center>
</body>
</html>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylanhand dylanhand

@lynnda-hill lynnda-hill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@unhammer @bbqsrc @dylanhand @snomos @lynnda-hill @ilm024