Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster-aws rolls control plane nodes unnecessarily because helm.sh/chart label is included in hashes #2721

Closed
Tracked by #2737
AndiDog opened this issue Aug 14, 2023 · 2 comments
Closed
Tracked by #2737

cluster-aws rolls control plane nodes unnecessarily because helm.sh/chart label is included in hashes #2721

AndiDog opened this issue Aug 14, 2023 · 2 comments
Assignees
@bdehri
Labels
area/kaas Mission: Cloud Native Platform - Self-driving Kubernetes as a Service goal/capa-internal-ga kind/bug provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix topic/capi

Comments

@AndiDog
Copy link

AndiDog commented Aug 14, 2023

Found while testing the opposite (#2217) 😆

Bumping the cluster-aws app version means we get a new label value such as helm.sh/chart: cluster-aws-0.37.0-37886655f76432958ad0e95a672c3c3f66de1a09. That label is included in {{- define "labels.common" -}}.

The controlplane-awsmachinetemplate-spec function includes those labels, gets hashed, leads to a new name suffix of AWSMachineTemplate/<cluster>-control-plane-<hash>, and therefore makes KubeadmControlPlane roll out new nodes because the template reference changed.

We should exclude or overwrite (e.g. include "the-spec" | mustRegexReplaceAll "helm.sh/chart: \S+" "" | sha1sum – untested pseudocode example!) such values when hashing.
@AndiDog AndiDog added area/kaas Mission: Cloud Native Platform - Self-driving Kubernetes as a Service kind/bug provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix topic/capi labels Aug 14, 2023
@alex-dabija alex-dabija mentioned this issue Aug 21, 2023
Closed
@bdehri bdehri self-assigned this Sep 18, 2023
@bdehri bdehri closed this as completed Oct 2, 2023
@bdehri bdehri reopened this Oct 23, 2023
@T-Kukawka
Copy link
Contributor

discussion: https://gigantic.slack.com/archives/C02HLSDH3DZ/p1697884170867609

@T-Kukawka
Copy link
Contributor

waiting for release

@bdehri bdehri closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdehri bdehri

Labels
area/kaas Mission: Cloud Native Platform - Self-driving Kubernetes as a Service goal/capa-internal-ga kind/bug provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix topic/capi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AndiDog @T-Kukawka @bdehri