Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust columns for kubectl gs get releases #1489

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Adjust columns for kubectl gs get releases #1489

merged 1 commit into from
Nov 15, 2024

Conversation

njuettner
Copy link
Member

@njuettner njuettner commented Nov 15, 2024

What does this PR do?

Towards: giantswarm/roadmap#3721

Before:

VERSION                 STATUS   AGE   KUBERNETES   CONTAINER LINUX   COREDNS   CALICO
cloud-director-27.0.0   ACTIVE   44h   1.27.16      n/a                         n/a

After:

VERSION                 STATUS   AGE   KUBERNETES   FLATCAR    CILIUM   COREDNS   OBSERVABILITY BUNDLE   SECURITY BUNDLE
cloud-director-27.0.0   ACTIVE   44h   1.27.16      3815.2.5   0.25.1   1.21.0    1.5.3                  1.8.0

@njuettner njuettner requested a review from a team as a code owner November 15, 2024 09:35
@njuettner njuettner requested a review from a team November 15, 2024 09:35
Copy link
Member

@marians marians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just one question: why the renaming of the column from "Container Linux" to "Flatcar"? As far as I can see on https://www.flatcar.org/ it's still called Flatcar Container Linux.

@AverageMarcus
Copy link
Member

AverageMarcus commented Nov 15, 2024

I don't think we never refer to it as "container linux", at least not that I've seen. We always say "Flatcar" in our releases and when talking to customers so it should help with consistency.

@marians
Copy link
Member

marians commented Nov 15, 2024

All right

@njuettner njuettner merged commit 462ffb5 into main Nov 15, 2024
3 checks passed
@njuettner njuettner deleted the releases branch November 15, 2024 14:23
@Gacko
Copy link
Member

Gacko commented Nov 15, 2024

Out of curiosity, maybe there's an UX reason for it: Why don't we use the CRD native possibility of displaying fields in just a normal kubectl get? As far as I can tell we're already doing this for some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants