Improved incorrect connector error message #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a note to Dex error page indicating that the authenticted user is not included in the required group(s).
The note explains that a correct connector needs to be used and and that the --cluster-admin flag in kubectl gs it meant to be used by GS staff in case the user logged in via kubectl gs.
Other error pages/messages remain uinchanged.
Note: In case of an authentication failure some connectors (e.g. Azure AD) terminate the flow before they redirect back to Dex and present their own error page/message. These error messages cannot be modified.
Checklist