-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong movie, same title #54
Comments
Thanks for the feedback - the list matching is definitely the trickiest part. Can you send which specific lists you're using which cause the problem? Will see if i can make it more robust. |
Wow, super quick response! An easy list to test is https://letterboxd.com/bfi/list/sight-and-sounds-greatest-films-of-all-time It contains the original Suspiria, but not the 2018 remake, but the remake always shows in the collections in Jellyfin (though I have both in my library and confirmed that both contain the correct IMDB id in their metadata). |
Hmmm strange. I've tried it with both the 1977 and 2018 version in my library. Seems to pick the correct (1977) one. Make sure your config is something like: ...
letterboxd:
enabled: true
imdb_id_filter: true
clear_collection: true
list_ids:
- "bfi/list/sight-and-sounds-greatest-films-of-all-time" If it stil isn't working let me know.Might need to send some debug logs to try and reproduce your issue. |
Hm, odd. I definitely don't have "clear_collection" configured, and my list doesnt have the list id's in quotations. Do you think those two options would effect this? imdb_id_filter is indeed set to true, as is "enabled". |
|
Hm, I suspect that'll be fine without the clear_collection part (i've been removing the incorrect movies manually, plus I have been adding movies of my own to some of these lists so I'd prefer to avoid clearing my custom entries), but I can try it if you think it'd help. Either way, this isn't the end of the world for me and I might just try to live with it for now. How would I find the debug logs you mentioned earlier? |
#55 might have helped. |
Well, it didn't solve The Suspiria Problem, but it did vastly improve matching in general, a lot of mismatches that usually occur didn't occur this time, for instance Little Women didn't show up in my Sleazy New York list today. |
Nice, thanks for the feedback - I'll keep iterating on it. |
I appreciate your time and effort, this is a hugely useful tool you've created, thanks again for your continued help! |
Hey, first off, this script is FANTASTIC, and I've used it a lot. That said, I do tend to find it mixes things up a lot based on title. I have "imdb_id_filter: true" set in my config and it seems to check that, but for example, a lot of lists contain SUSPIRIA (1977) but the lists all have the remake from 2018.
Is there something I can set differently, or is this just how it is?
The text was updated successfully, but these errors were encountered: