Skip to content

Commit 3297e9f

Browse files
authored
Review checklist: suggest checking insertions expected to be new. (#7245)
Suggest checking that PRs assert that insertions into sets or maps expected to be adding new values didn't actually just replace some existing value. Bug #7048 and its several duplicates would have been caught sooner if the insertion of the new spill temporary into the `spilled_composites` table had asserted that there was no existing spill variable for that expression.
1 parent d6ca412 commit 3297e9f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

docs/review-checklist.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ satisfying way to address in a more robust way.
3434
- [ ] If your change iterates over a collection, did you ensure the
3535
order of iteration was deterministic? Using `HashMap` and
3636
`HashSet` is fine, as long as you don't iterate over it.
37+
- [ ] If you insert elements into a set or map that you expect are not
38+
already present, did you make an assertion about `insert`'s
39+
return value?
3740

3841
### WGSL Extensions
3942

0 commit comments

Comments
 (0)