Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Check Error Message Format #2751

Closed
c-git opened this issue Dec 27, 2024 · 4 comments
Closed

Link Check Error Message Format #2751

c-git opened this issue Dec 27, 2024 · 4 comments

Comments

@c-git
Copy link
Contributor

c-git commented Dec 27, 2024

Bug Report

Environment

Zola version: 0.19.2

Expected Desired Behavior

Bug report feels strong. It's more that it works as intended but I'm wondering if the current behaviour is desirable. I'd want to be able to click links in error reports and use that as a way to test the links but the colon separator gets included in the link and thus the link doesn't work. Can we include parentheses around the link or a space before the colon?

Current Behavior

Clicking link in error messages might include the colon (:) which results in an invalid link.

Step to reproduce

To reproduce you need to include a link that gets reported as a broken link for example a link that has bot protection and gives a 403.

Example from the github action failure on my site below. It's parsed fine by GitHub Markdown


  1. Broken link in /home/runner/work/c-git.github.io/c-git.github.io/content/rust/areweyet.md to https://wiki.mozilla.org/Areweyet: Client error status code (403 Forbidden) received

But in the GitHub action the clickable link includes the colon.

screenshot of incorrect link

@Keats
Copy link
Collaborator

Keats commented Dec 29, 2024

Let's add the space before the colon

@c-git
Copy link
Contributor Author

c-git commented Dec 29, 2024

Ok I'll try to do a PR.

@c-git
Copy link
Contributor Author

c-git commented Dec 29, 2024

PR completed #2754

@c-git
Copy link
Contributor Author

c-git commented Jan 3, 2025

PR merged

@c-git c-git closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants