Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null given to $fromEmail on Conversations #6

Closed
clarg18 opened this issue Oct 1, 2022 · 1 comment · Fixed by #8
Closed

Null given to $fromEmail on Conversations #6

clarg18 opened this issue Oct 1, 2022 · 1 comment · Fixed by #8

Comments

@clarg18
Copy link
Contributor

clarg18 commented Oct 1, 2022

>>> $fresh->getTicketById(59408); TypeError: Gets\Freshservice\Entities\Conversation::setFromEmail(): Argument #1 ($fromEmail) must be of type string, null given, called in /var/www/html/vendor/getsno/freshservice-api/src/Entities/Conversation.php on line 147

@clarg18
Copy link
Contributor Author

clarg18 commented Oct 1, 2022

    public function setFromEmail(string $fromEmail): self
    {
        $this->fromEmail = $fromEmail;

        return $this;
    }

Type set as string but this can be null for private and public notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant