[Technical] Consider adding a database index on Upper(slug) in Organization model

[floels]

Problem Statement

When reading through the code of the Organization model, I saw this old TODO:

sentry/src/sentry/models/organization.py

Lines 215 to 219 in 6bdd7dd

	class Meta:
	app_label = "sentry"
	db_table = "sentry_organization"
	# TODO: Once we're on a version of Django that supports functional indexes,
	# include index on `upper((slug::text))` here.

Since Sentry is now running on Django 5.1, which supports functional indexes, and I don't see the index on Upper(slug) created anywhere in the meantime, I was wondering whether it'd be worth creating this database index to improve the performances in production.

If not, we might want to remove the TODO to clean up the code.

Solution Brainstorm

We could add the index as suggested by the TODO by declaring it at the same place:

class Meta:
    app_label = "sentry"
    db_table = "sentry_organization"
    indexes = [
        models.Index(
            models.functions.Upper("slug"),
            name="organization_slug_upper_idx",
        )
    ]

which would result in a migration file in the likes of:

class Migration(CheckedMigration):
   (...)

    operations = [
        migrations.AddIndex(
            model_name="organization",
            index=models.Index(
                django.db.models.functions.text.Upper("slug"), name="organization_slug_upper_idx"
            ),
        ),
    ]

Product Area

Other

[getsantry]

Assigning to @getsentry/support for routing ⏲️

[getsantry]

Routing to @getsentry/product-owners-other for triage ⏲️