Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event detail -> Screenshots - show a carousel so we can quickly cycle through the screenshots #79076

Closed
bruno-garcia opened this issue Oct 13, 2024 · 8 comments

Comments

@bruno-garcia
Copy link
Member

Problem Statement

When trying to understand how the UI connects to the issue, through looking at screenshots. It would be ideal to be able to quickly cycle through the screenshots.

In the current beta experience, screenshots (which require URL hacking since clicking on Attachments open Tags) show a list.
And one needs to hit Preview one by one as the images stack on top of each other.

Image

Link to example: https://sentry.sentry.io/issues/5987813063/attachments/?attachmentFilter=screenshot&node=error-cfa4cebfdec847f4910ba5dde06201fd&project=5905698&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=1h&stream_index=0

Solution Brainstorm

Relates to:

Product Area

Unknown

@getsantry
Copy link
Contributor

getsantry bot commented Oct 13, 2024

Routing to @getsentry/product-owners-issues for triage ⏲️

@jangjodi
Copy link
Member

Thanks for suggestion! I will add this to our backlog

@UrbanNuke
Copy link

UrbanNuke commented Nov 14, 2024

Any news? Our self-hosted sentry a little bit shocked by it

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 14, 2024
@jangjodi
Copy link
Member

Hi UrbanNuke, unfortunately we have no updates on this

@bruno-garcia
Copy link
Member Author

Looks like we gate the preview by isMobile:

https://github.com/getsentry/sentry/blob/ec05e95588181966ded878090b1241e3b3fb2775/static/app/views/issueDetails/groupEventAttachments/groupEventAttachmentsFilter.tsx#L51C15-L51C31

We have other platforms that are not mobile, such as Unity (can be desktop, web, console) as well as Nintendo which can have screenshots.

Could we always show this, or only show it if we see an attachment with name containing screenshot?
Screenshots are convention based, if name is screenshot.(jpg|png) we show the preview in the issue details.

@bruno-garcia
Copy link
Member Author

This is used by: https://github.com/getsentry/sentry/blob/master/static/app/utils/platform.tsx#L8C21-L8C39

And defined on:


https://github.com/getsentry/sentry/blob/master/static/app/data/platformCategories.tsx#L37

This approach is not ideal because the outcome of saying something "is mobile" isn't super clear. We'll add Nintendo Switch there to get the screenshots, but this could have negative side effects.

We should instead have a has_screenshot support list.

@bruno-garcia
Copy link
Member Author

Talked to @scttcper on Slack about this, the idea is to remove this filter to simplify things and have the "screenshot" filter show up on all platforms.

@bruno-garcia
Copy link
Member Author

@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

4 participants