Migration Hard Stops inforcement

[mhkarimi1383]

Problem Statement

Hi

today I was upgrading a Sentry Self Hosted instance, But I was doing a wrong path,

I was expecting a meaning full error instead of a random error before running migration

Solution Brainstorm

Like what we have in GitLab, It should check before running migration and raise a meaningful error and don't start at all

Product Area

Unknown

[getsantry]

Assigning to @getsentry/support for routing ⏲️

[linear-code]

ENG-8607

[mhkarimi1383]

This is the random error that was irrelevant to the problem

It would be great if it can detect and raise a meaningful error like GitLab

GitLab also has a upgrade path website that will generate upgrade path between two versions with required notes

Running migrations for default                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              
Operations to perform:                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      
  Apply all migrations: ai_monitoring, auth, contenttypes, explore, feedback, flags, hybridcloud, insights, investigations, nodestore, notifications, releases, seer, sentry, sessions, sites, social_auth, workflow_engine                                                                                                                                                                                                                                                                                                                                                                                                                                 
Traceback (most recent call last):                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          
  File "/.venv/bin/sentry", line 4, in <module>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             
    raise SystemExit(main())                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                
                     ~~~~^^                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 
  File "/usr/src/sentry/src/sentry/runner/main.py", line 146, in main                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       
    func(**kwargs)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          
    ~~~~^^^^^^^^^^                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          
  File "/.venv/lib/python3.13/site-packages/click/core.py", line 1442, in __call__                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          
    return self.main(*args, **kwargs)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       
           ~~~~~~~~~^^^^^^^^^^^^^^^^^                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       
  File "/.venv/lib/python3.13/site-packages/click/core.py", line 1363, in main                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              
    rv = self.invoke(ctx)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   
  File "/.venv/lib/python3.13/site-packages/click/core.py", line 1830, in invoke                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            
    return _process_result(sub_ctx.command.invoke(sub_ctx))                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^File "/.venv/lib/python3.13/site-packages/click/core.py", line 1226, in invoke                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    [0/1932]
    return ctx.invoke(self.callback, **ctx.params)                                                                                                             
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                             
  File "/.venv/lib/python3.13/site-packages/click/core.py", line 794, in invoke                                                                                
    return callback(*args, **kwargs)                                                                                                                           
  File "/.venv/lib/python3.13/site-packages/click/decorators.py", line 34, in new_func                                                                         
    return f(get_current_context(), *args, **kwargs)                                                                                                           
  File "/usr/src/sentry/src/sentry/runner/decorators.py", line 34, in inner                                                                                    
    return ctx.invoke(f, *args, **kwargs)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^                                                                                                                      
  File "/.venv/lib/python3.13/site-packages/click/core.py", line 794, in invoke 
    return callback(*args, **kwargs)                                                                                                                           
  File "/usr/src/sentry/src/sentry/runner/commands/upgrade.py", line 168, in upgrade
    _upgrade(                                             
    ~~~~~~~~^                                                                                                                                                  
        not noinput,                              
        ^^^^^^^^^^^^                                                                           
    ...<5 lines>...                                                                            
        create_kafka_topics,                                                                   
        ^^^^^^^^^^^^^^^^^^^^                                                                   
    )                                                                                          
    ^                                                                                                                                                                                         
  File "/usr/src/sentry/src/sentry/runner/commands/upgrade.py", line 83, in _upgrade                                                                           
    dj_call_command(                                                                                                                                           
    ~~~~~~~~~~~~~~~^                                                                                                                                           
        "migrate",                                                                                                                                             
        ^^^^^^^^^^                                                                                                                                             
    ...<3 lines>...                                                                                                                                            
        verbosity=verbosity,                                                                                                                                   
        ^^^^^^^^^^^^^^^^^^^^                                                                                                                                   
    )                                                                                                                                                          
    ^                                                                                                                                                          
  File "/.venv/lib/python3.13/site-packages/django/core/management/__init__.py", line 194, in call_command
    return command.execute(*args, **defaults)                                                                                                                  
           ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^                                                                                                                  
  File "/.venv/lib/python3.13/site-packages/django/core/management/base.py", line 464, in execute
    output = self.handle(*args, **options)                                                                                                                     
  File "/.venv/lib/python3.13/site-packages/django/core/management/base.py", line 111, in wrapper
    res = handle_func(*args, **kwargs)                                                                                                                         
  File "/.venv/lib/python3.13/site-packages/django/core/management/commands/migrate.py", line 299, in handle
    pre_migrate_apps = pre_migrate_state.apps                                                                                                                  
                       ^^^^^^^^^^^^^^^^^^^^^^                                                                                                                  
  File "/.venv/lib/python3.13/site-packages/django/utils/functional.py", line 47, in __get__
    res = instance.__dict__[self.name] = self.func(instance)                                                                                                   
                                         ~~~~~~~~~^^^^^^^^^^                                                                                                   
  File "/.venv/lib/python3.13/site-packages/django/db/migrations/state.py", line 589, in apps
    return StateApps(self.real_apps, self.models)                                                                                                              
  File "/.venv/lib/python3.13/site-packages/django/db/migrations/state.py", line 660, in __init__
    raise ValueError("\n".join(error.msg for error in errors))                                                                                                 
ValueError: The field feedback.Feedback.environment was declared with a lazy reference to 'sentry.environment', but app 'sentry' isn't installed.
The field flags.FlagWebHookSigningSecretModel.organization was declared with a lazy reference to 'sentry.organization', but app 'sentry' isn't installed.
The field insights.InsightsStarredSegment.organization was declared with a lazy reference to 'sentry.organization', but app 'sentry' isn't installed.
The field insights.InsightsStarredSegment.project was declared with a lazy reference to 'sentry.project', but app 'sentry' isn't installed.
The field social_auth.UserSocialAuth.user was declared with a lazy reference to 'sentry.user', but app 'sentry' isn't installed.