✅ Add tests for new PD summary titles

Author: leeandher

tests/sentry/integrations/pagerduty/test_notification.py

@@ -15,6 +15,7 @@
 from sentry.testutils.helpers.notifications import TEST_ISSUE_OCCURRENCE
 from sentry.testutils.silo import assume_test_silo_mode
 from sentry.testutils.skips import requires_snuba
+from sentry.types.rules import RuleFuture
 
 pytestmark = [requires_snuba]
 
@@ -35,6 +36,7 @@ class PagerDutyNotifyActionTest(RuleTestCase, PerformanceIssueTestCase):
     rule_cls = PagerDutyNotifyServiceAction
 
     def setUp(self):
+        self.project_rule = self.create_project_rule(name="Check #project-channel")
         with assume_test_silo_mode(SiloMode.CONTROL):
             self.integration, org_integration = self.create_provider_integration_for(
                 self.organization,
@@ -66,12 +68,21 @@ def test_applies_correctly(self, mock_record):
         )
 
         rule = self.get_rule(
-            data={"account": self.integration.id, "service": str(self.service["id"])}
+            data={
+                "account": self.integration.id,
+                "service": str(self.service["id"]),
+                "name": "Test Alert",
+            }
         )
 
         notification_uuid = "123e4567-e89b-12d3-a456-426614174000"
 
-        results = list(rule.after(event=event, notification_uuid=notification_uuid))
+        results = list(
+            rule.after(
+                event=event,
+                notification_uuid=notification_uuid,
+            )
+        )
         assert len(results) == 1
 
         responses.add(
@@ -83,11 +94,12 @@ def test_applies_correctly(self, mock_record):
         )
 
         # Trigger rule callback
-        results[0].callback(event, futures=[])
+        rule_future = RuleFuture(rule=self.project_rule, kwargs=results[0].kwargs)
+        results[0].callback(event, futures=[rule_future])
         data = orjson.loads(responses.calls[0].request.body)
 
         assert data["event_action"] == "trigger"
-        assert data["payload"]["summary"] == event.message
+        assert data["payload"]["summary"] == f"[{self.project_rule.label}]: {event.message}"
         assert data["payload"]["custom_details"]["message"] == event.message
         assert event.group is not None
         assert data["links"][0]["href"] == event.group.get_absolute_url(
@@ -97,7 +109,7 @@ def test_applies_correctly(self, mock_record):
         mock_record.assert_called_with(
             "alert.sent",
             provider="pagerduty",
-            alert_id="",
+            alert_id=self.project_rule.id,
             alert_type="issue_alert",
             organization_id=self.organization.id,
             project_id=event.project_id,
@@ -111,7 +123,7 @@ def test_applies_correctly(self, mock_record):
             project_id=event.project_id,
             group_id=event.group_id,
             notification_uuid=notification_uuid,
-            alert_id=None,
+            alert_id=self.project_rule.id,
         )
 
     @responses.activate
@@ -130,13 +142,14 @@ def test_applies_correctly_performance_issue(self):
         )
 
         # Trigger rule callback
-        results[0].callback(event, futures=[])
+        rule_future = RuleFuture(rule=self.project_rule, kwargs=results[0].kwargs)
+        results[0].callback(event, futures=[rule_future])
         data = orjson.loads(responses.calls[0].request.body)
 
         perf_issue_title = "N+1 Query"
 
         assert data["event_action"] == "trigger"
-        assert data["payload"]["summary"] == perf_issue_title
+        assert data["payload"]["summary"] == f"[{self.project_rule.label}]: {perf_issue_title}"
         assert data["payload"]["custom_details"]["title"] == perf_issue_title
 
     @responses.activate
@@ -165,11 +178,15 @@ def test_applies_correctly_generic_issue(self):
         )
 
         # Trigger rule callback
-        results[0].callback(group_event, futures=[])
+        rule_future = RuleFuture(rule=self.project_rule, kwargs=results[0].kwargs)
+        results[0].callback(group_event, futures=[rule_future])
         data = orjson.loads(responses.calls[0].request.body)
 
         assert data["event_action"] == "trigger"
-        assert data["payload"]["summary"] == group_event.occurrence.issue_title
+        assert (
+            data["payload"]["summary"]
+            == f"[{self.project_rule.label}]: {group_event.occurrence.issue_title}"
+        )
         assert data["payload"]["custom_details"]["title"] == group_event.occurrence.issue_title
 
     def test_render_label_without_severity(self):