[DO NOT LAND] task(preprod): Roll out preprod to early adopters

NicoHinderling · NicoHinderling · commit 16d0f5d9d6f5 · 2025-10-23T18:48:55.000-07:00
diff --git a/src/sentry/preprod/api/endpoints/organization_preprod_artifact_assemble.py b/src/sentry/preprod/api/endpoints/organization_preprod_artifact_assemble.py
@@ -9,7 +9,7 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import analytics, features
+from sentry import analytics
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
@@ -19,6 +19,7 @@
 from sentry.models.orgauthtoken import is_org_auth_token_auth, update_org_auth_token_last_used
 from sentry.models.project import Project
 from sentry.preprod.analytics import PreprodArtifactApiAssembleEvent
+from sentry.preprod.permissions import has_preprod_access
 from sentry.preprod.tasks import assemble_preprod_artifact, create_preprod_artifact
 from sentry.preprod.url_utils import get_preprod_artifact_url
 from sentry.preprod.vcs.status_checks.size.tasks import create_preprod_status_check_task
@@ -116,9 +117,7 @@ def post(self, request: Request, project: Project) -> Response:
             )
         )
 
-        if not settings.IS_DEV and not features.has(
-            "organizations:preprod-frontend-routes", project.organization, actor=request.user
-        ):
+        if not settings.IS_DEV and not has_preprod_access(project.organization, request.user):
             return Response({"error": "Feature not enabled"}, status=403)
 
         with sentry_sdk.start_span(op="preprod_artifact.assemble"):
diff --git a/src/sentry/preprod/api/endpoints/project_preprod_artifact_delete.py b/src/sentry/preprod/api/endpoints/project_preprod_artifact_delete.py
@@ -6,7 +6,7 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import analytics, features
+from sentry import analytics
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
@@ -15,6 +15,7 @@
 from sentry.preprod.analytics import PreprodArtifactApiDeleteEvent
 from sentry.preprod.api.bases.preprod_artifact_endpoint import PreprodArtifactEndpoint
 from sentry.preprod.models import PreprodArtifact, PreprodArtifactSizeMetrics
+from sentry.preprod.permissions import has_preprod_access
 
 logger = logging.getLogger(__name__)
 
@@ -35,9 +36,7 @@ def delete(
     ) -> Response:
         """Delete a preprod artifact and all associated data"""
 
-        if not features.has(
-            "organizations:preprod-frontend-routes", project.organization, actor=request.user
-        ):
+        if not has_preprod_access(project.organization, request.user):
             return Response({"error": "Feature not enabled"}, status=403)
 
         analytics.record(
diff --git a/src/sentry/preprod/api/endpoints/project_preprod_build_details.py b/src/sentry/preprod/api/endpoints/project_preprod_build_details.py
@@ -5,7 +5,7 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import analytics, features
+from sentry import analytics
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
@@ -16,6 +16,7 @@
     transform_preprod_artifact_to_build_details,
 )
 from sentry.preprod.models import PreprodArtifact
+from sentry.preprod.permissions import has_preprod_access
 
 logger = logging.getLogger(__name__)
 
@@ -57,9 +58,7 @@ def get(
             )
         )
 
-        if not features.has(
-            "organizations:preprod-frontend-routes", project.organization, actor=request.user
-        ):
+        if not has_preprod_access(project.organization, request.user):
             return Response({"error": "Feature not enabled"}, status=403)
 
         if head_artifact.state == PreprodArtifact.ArtifactState.FAILED:
diff --git a/src/sentry/preprod/api/endpoints/project_preprod_list_builds.py b/src/sentry/preprod/api/endpoints/project_preprod_list_builds.py
@@ -7,7 +7,7 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import analytics, features
+from sentry import analytics
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
@@ -20,6 +20,7 @@
 )
 from sentry.preprod.api.validators import PreprodListBuildsValidator
 from sentry.preprod.models import PreprodArtifact
+from sentry.preprod.permissions import has_preprod_access
 from sentry.preprod.utils import parse_release_version
 
 logger = logging.getLogger(__name__)
@@ -63,9 +64,7 @@ def get(self, request: Request, project: Project) -> Response:
             )
         )
 
-        if not features.has(
-            "organizations:preprod-frontend-routes", project.organization, actor=request.user
-        ):
+        if not has_preprod_access(project.organization, request.user):
             return Response({"error": "Feature not enabled"}, status=403)
 
         validator = PreprodListBuildsValidator(data=request.GET)
diff --git a/src/sentry/preprod/api/endpoints/size_analysis/project_preprod_size_analysis_compare.py b/src/sentry/preprod/api/endpoints/size_analysis/project_preprod_size_analysis_compare.py
@@ -7,7 +7,7 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import analytics, features
+from sentry import analytics
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
@@ -33,6 +33,7 @@
     PreprodArtifactSizeComparison,
     PreprodArtifactSizeMetrics,
 )
+from sentry.preprod.permissions import has_preprod_access
 from sentry.preprod.size_analysis.tasks import manual_size_analysis_comparison
 from sentry.preprod.size_analysis.utils import build_size_metrics_map, can_compare_size_metrics
 
@@ -82,9 +83,7 @@ def get(
             )
         )
 
-        if not features.has(
-            "organizations:preprod-frontend-routes", project.organization, actor=request.user
-        ):
+        if not has_preprod_access(project.organization, request.user):
             return Response({"error": "Feature not enabled"}, status=403)
 
         logger.info(
@@ -268,9 +267,7 @@ def post(
             )
         )
 
-        if not features.has(
-            "organizations:preprod-frontend-routes", project.organization, actor=request.user
-        ):
+        if not has_preprod_access(project.organization, request.user):
             return Response({"error": "Feature not enabled"}, status=403)
 
         logger.info(
diff --git a/src/sentry/preprod/api/endpoints/size_analysis/project_preprod_size_analysis_compare_download.py b/src/sentry/preprod/api/endpoints/size_analysis/project_preprod_size_analysis_compare_download.py
@@ -6,7 +6,7 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import analytics, features
+from sentry import analytics
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
@@ -15,6 +15,7 @@
 from sentry.models.project import Project
 from sentry.preprod.analytics import PreprodArtifactApiSizeAnalysisCompareDownloadEvent
 from sentry.preprod.models import PreprodArtifactSizeComparison
+from sentry.preprod.permissions import has_preprod_access
 
 logger = logging.getLogger(__name__)
 
@@ -54,9 +55,7 @@ def get(
             )
         )
 
-        if not features.has(
-            "organizations:preprod-frontend-routes", project.organization, actor=request.user
-        ):
+        if not has_preprod_access(project.organization, request.user):
             return Response({"error": "Feature not enabled"}, status=403)
 
         logger.info(
diff --git a/src/sentry/preprod/api/endpoints/size_analysis/project_preprod_size_analysis_download.py b/src/sentry/preprod/api/endpoints/size_analysis/project_preprod_size_analysis_download.py
@@ -7,14 +7,15 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import analytics, features
+from sentry import analytics
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
 from sentry.models.project import Project
 from sentry.preprod.analytics import PreprodArtifactApiSizeAnalysisDownloadEvent
 from sentry.preprod.api.bases.preprod_artifact_endpoint import PreprodArtifactEndpoint
 from sentry.preprod.models import PreprodArtifact, PreprodArtifactSizeMetrics
+from sentry.preprod.permissions import has_preprod_access
 from sentry.preprod.size_analysis.download import (
     SizeAnalysisError,
     get_size_analysis_error_response,
@@ -61,9 +62,7 @@ def get(
             )
         )
 
-        if not settings.IS_DEV and not features.has(
-            "organizations:preprod-frontend-routes", project.organization, actor=request.user
-        ):
+        if not settings.IS_DEV and not has_preprod_access(project.organization, request.user):
             return Response({"error": "Feature not enabled"}, status=403)
 
         try:
diff --git a/src/sentry/preprod/permissions.py b/src/sentry/preprod/permissions.py
@@ -0,0 +1,19 @@
+"""
+Permission helpers for preprod features.
+"""
+
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
+from sentry import features
+
+if TYPE_CHECKING:
+    from sentry.models.organization import Organization
+    from sentry.users.models.user import RpcUser, User
+
+
+def has_preprod_access(organization: Organization, user: User | RpcUser | None = None) -> bool:
+    if organization.flags.early_adopter:
+        return True
+    return features.has("organizations:preprod-frontend-routes", organization, actor=user)
diff --git a/static/app/utils/usePreprodAccess.tsx b/static/app/utils/usePreprodAccess.tsx
@@ -0,0 +1,12 @@
+import useOrganization from 'sentry/utils/useOrganization';
+
+export function usePreprodAccess(): boolean {
+  const organization = useOrganization({allowNull: true});
+  if (!organization) {
+    return false;
+  }
+  return (
+    organization.isEarlyAdopter ||
+    organization.features?.includes('preprod-frontend-routes')
+  );
+}
diff --git a/static/app/views/preprod/index.tsx b/static/app/views/preprod/index.tsx
@@ -1,33 +1,32 @@
 import {Outlet} from 'react-router-dom';
 
-import Feature from 'sentry/components/acl/feature';
 import {Alert} from 'sentry/components/core/alert';
 import * as Layout from 'sentry/components/layouts/thirds';
 import NoProjectMessage from 'sentry/components/noProjectMessage';
 import {t} from 'sentry/locale';
 import useOrganization from 'sentry/utils/useOrganization';
+import {usePreprodAccess} from 'sentry/utils/usePreprodAccess';
 
 function PreprodContainer() {
   const organization = useOrganization();
+  const hasPreprodAccess = usePreprodAccess();
+
+  if (!hasPreprodAccess) {
+    return (
+      <Layout.Page withPadding>
+        <Alert.Container>
+          <Alert type="warning" showIcon={false}>
+            {t("You don't have access to this feature")}
+          </Alert>
+        </Alert.Container>
+      </Layout.Page>
+    );
+  }
 
   return (
-    <Feature
-      features={['organizations:preprod-frontend-routes']}
-      organization={organization}
-      renderDisabled={() => (
-        <Layout.Page withPadding>
-          <Alert.Container>
-            <Alert type="warning" showIcon={false}>
-              {t("You don't have access to this feature")}
-            </Alert>
-          </Alert.Container>
-        </Layout.Page>
-      )}
-    >
-      <NoProjectMessage organization={organization}>
-        <Outlet />
-      </NoProjectMessage>
-    </Feature>
+    <NoProjectMessage organization={organization}>
+      <Outlet />
+    </NoProjectMessage>
   );
 }
 
diff --git a/static/app/views/releases/detail/header/releaseHeader.tsx b/static/app/views/releases/detail/header/releaseHeader.tsx
@@ -101,8 +101,12 @@ function ReleaseHeader({
     to: `builds/`,
   };
 
+  const hasPreprodAccess =
+    organization.isEarlyAdopter ||
+    organization.features?.includes('preprod-frontend-routes');
+
   if (
-    organization.features?.includes('preprod-frontend-routes') &&
+    hasPreprodAccess &&
     (numberOfMobileBuilds || MOBILE_PLATFORMS.includes(project.platform))
   ) {
     tabs.push(buildsTab);
diff --git a/tests/sentry/preprod/test_permissions.py b/tests/sentry/preprod/test_permissions.py
@@ -0,0 +1,50 @@
+from sentry.preprod.permissions import has_preprod_access
+from sentry.testutils.cases import TestCase
+from sentry.testutils.helpers import Feature
+
+
+class HasPreprodAccessTest(TestCase):
+    def setUp(self):
+        super().setUp()
+        self.organization = self.create_organization()
+        self.user = self.create_user()
+
+    def test_early_adopter_flag_grants_access(self):
+        """Test that early_adopter flag grants access regardless of feature flag"""
+        self.organization.flags.early_adopter = True
+        self.organization.save()
+
+        # Access is granted even without the feature flag
+        assert has_preprod_access(self.organization, self.user)
+
+    def test_feature_flag_grants_access(self):
+        """Test that feature flag grants access even without early_adopter"""
+        self.organization.flags.early_adopter = False
+        self.organization.save()
+
+        with Feature({"organizations:preprod-frontend-routes": True}):
+            assert has_preprod_access(self.organization, self.user)
+
+    def test_no_access_without_either(self):
+        """Test that access is denied without feature flag or early_adopter"""
+        self.organization.flags.early_adopter = False
+        self.organization.save()
+
+        with Feature({"organizations:preprod-frontend-routes": False}):
+            assert not has_preprod_access(self.organization, self.user)
+
+    def test_early_adopter_takes_precedence(self):
+        """Test that early_adopter grants access even if feature flag is disabled"""
+        self.organization.flags.early_adopter = True
+        self.organization.save()
+
+        with Feature({"organizations:preprod-frontend-routes": False}):
+            # Access is still granted due to early_adopter
+            assert has_preprod_access(self.organization, self.user)
+
+    def test_works_without_user(self):
+        """Test that the function works without a user parameter"""
+        self.organization.flags.early_adopter = True
+        self.organization.save()
+
+        assert has_preprod_access(self.organization)
