-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Android smoke test #1865
Conversation
use older macos
Something is really broken here. The tests pass in CI but if you look at the logs you'll see
and they are still timing out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the fail-condition needs to be reworked. The tests should not fail and the step still succeeds.
@lucas-zimerman could u give this another stab plz? |
Sorry I didn't receive the notifications for this PR :( |
re-requested @bitsandfoxes review since CI looks happy |
It looks like CI is lying and in fact not happy at all. 😞
|
There is some odd thing with the game activity name changing, I will fix it on a follow up commit EDIT: tests are passing on another repo: Failed smoke test |
@bitsandfoxes tests are now fixed and ready to go! |
Thanks for tackling this! Some of the Android tests seem to pass amazingly easy and uncomplicated. But some still seem to fail and CI remains green: https://github.com/getsentry/sentry-unity/actions/runs/12055483401/job/33617302524 |
This is quite scary since it'll give us false confidence |
@lucas-zimerman is this something u can help fix? |
Superseded by #1936 |
Here are the main fixes implemented on the PR:
NOTE: Ideally we should use cache the emulators, but things were too flaky when caching the emulator that I opted to not cache it for the moment.
Close #1811
#skip-changelog.