target fields copied to coroutine

Author: alexander-alderman-webb

sentry_sdk/integrations/asyncio.py

@@ -30,6 +30,17 @@ def get_name(coro):
     )
 
 
+def _wrap_coroutine(wrapped):
+    # type: Coroutine[Any, Any, Any] -> Coroutine[Any, Any, Any]
+    # Only __name__ and __qualname__ are copied from function to coroutine in CPython
+    return functools.partial(
+        functools.update_wrapper,
+        wrapped=wrapped,
+        assigned=("__name__", "__qualname__"),
+        updated=(),
+    )
+
+
 def patch_asyncio():
     # type: () -> None
     orig_task_factory = None
@@ -40,7 +51,7 @@ def patch_asyncio():
         def _sentry_task_factory(loop, coro, **kwargs):
             # type: (asyncio.AbstractEventLoop, Coroutine[Any, Any, Any], Any) -> asyncio.Future[Any]
 
-            @functools.wraps(coro)
+            @_wrap_coroutine(coro)
             async def _task_with_sentry_span_creation():
                 # type: () -> Any
                 result = None

tests/integrations/asyncio/test_asyncio.py

@@ -67,7 +67,16 @@ async def test_create_task(
 
     with sentry_sdk.start_transaction(name="test_transaction_for_create_task"):
         with sentry_sdk.start_span(op="root", name="not so important"):
-            tasks = [asyncio.create_task(foo()), asyncio.create_task(bar())]
+            foo_task = asyncio.create_task(foo())
+            bar_task = asyncio.create_task(bar())
+
+            if hasattr(foo_task.get_coro(), "__name__"):
+                assert foo_task.get_coro().__name__ == "foo"
+            if hasattr(bar_task.get_coro(), "__name__"):
+                assert bar_task.get_coro().__name__ == "bar"
+
+            tasks = [foo_task, bar_task]
+
             await asyncio.wait(tasks, return_when=asyncio.FIRST_EXCEPTION)
 
     sentry_sdk.flush()