Commit 8fae8a6
authored
fix(starlette): Use
### Description
When host routing, we don't have a route and instead fall back to the
request path for the transaction name. This should be given transaction
source `url` (for raw URLs) instead of the current value of `route` (for
parameterized routes).
This matters for #7183, where the mis-categorized transaction source
would lead to bad data in `http.route`. (Bug found by Cursor in
#7183 (comment)
when reviewing that PR).url transaction source for host routing (#7266)1 parent 05b284e commit 8fae8a6
2 files changed
Lines changed: 36 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
843 | 843 | | |
844 | 844 | | |
845 | 845 | | |
846 | | - | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
847 | 849 | | |
848 | 850 | | |
849 | | - | |
| 851 | + | |
850 | 852 | | |
851 | 853 | | |
852 | 854 | | |
853 | 855 | | |
854 | 856 | | |
855 | | - | |
| 857 | + | |
856 | 858 | | |
857 | | - | |
858 | | - | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
859 | 862 | | |
860 | | - | |
| 863 | + | |
861 | 864 | | |
862 | 865 | | |
863 | 866 | | |
| |||
872 | 875 | | |
873 | 876 | | |
874 | 877 | | |
875 | | - | |
| 878 | + | |
876 | 879 | | |
877 | 880 | | |
878 | 881 | | |
| |||
891 | 894 | | |
892 | 895 | | |
893 | 896 | | |
894 | | - | |
895 | | - | |
| 897 | + | |
896 | 898 | | |
897 | 899 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1051 | 1051 | | |
1052 | 1052 | | |
1053 | 1053 | | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
1054 | 1079 | | |
1055 | 1080 | | |
1056 | 1081 | | |
| |||
0 commit comments