Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build using Windows Visual Studio 2022 - sentry-cli 0.7.15 #1094

Open
2 tasks
sseyod opened this issue Nov 30, 2024 · 2 comments
Open
2 tasks

Cannot build using Windows Visual Studio 2022 - sentry-cli 0.7.15 #1094

sseyod opened this issue Nov 30, 2024 · 2 comments

Comments

@sseyod
Copy link

sseyod commented Nov 30, 2024

Description

Cannot build using Windows Visual Studio 2022.

When does the problem happen

  • [ x] During build
  • During run-time
  • When capturing a hard crash

Environment

  • OS: Windows 11 Home 64-bit
  • Compiler: MSVC 2022
  • CMake version and config: 3.31.1

Steps To Reproduce

Get latest zip of sentry-cli (0.7.15)
Unzip

From Visual Studio Power Shell, in the unzipped folder as follows:

cmake -DBUILD_SHARED_LIBS=OFF -DSENTRY_BACKEND=breakpad -DSENTRY_BUILD_RUNTIMESTATIC=ON -DCMAKE_GENERATOR_PLATFORM=x64 -B build

The command fails, as cmake is unable to find cmake/utils.cmake

If I comment-out all of the following lines in CMakeLIsts.txt, the cmake command works:

include(cmake/utils.cmake)
if (WIN32 AND SENTRY_BUILD_SHARED_LIBS)
    sentry_add_version_resource(sentry "Client Library")
endif()
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 30, 2024
@JoshuaMoelans JoshuaMoelans moved this from Needs Discussion to In Investigation in Mobile & Cross Platform SDK Dec 4, 2024
@supervacuus supervacuus self-assigned this Dec 5, 2024
@supervacuus
Copy link
Collaborator

Hi, it is not clear what went wrong here, but this path is well-tested. You're mentioning sentry-cli at multiple points. While having sentry-cli around when developing native applications that you want to monitor with Sentry is undoubtedly helpful, it is entirely unrelated to building the Native SDK (which this repository hosts). You may have mixed up your downloads.

I have created a test repository that only contains a workflow to build Native SDK 0.7.15 from our provided release zip with the parameters you provided: https://github.com/supervacuus/native-build-test/actions/runs/12177788941. As you can see, the build runs end to end, and you can even download the install artifacts.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 3 Dec 5, 2024
@kahest kahest moved this from In Investigation to Needs More Information in Mobile & Cross Platform SDK Dec 5, 2024
@getsantry getsantry bot moved this to Waiting for: Community in GitHub Issues with 👀 3 Dec 5, 2024
@getsantry
Copy link

getsantry bot commented Jan 1, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Community
Status: Needs More Information
Development

No branches or pull requests

3 participants