From 99a37750a981e8bf467bba56dd31021342087bc4 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Mon, 3 Feb 2025 13:50:46 +0100 Subject: [PATCH 1/2] test: Only run flaky test detection for chromium This streamlines this a bit and should be good enough here. --- .github/workflows/flaky-test-detector.yml | 2 ++ .../browser-integration-tests/scripts/detectFlakyTests.ts | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/flaky-test-detector.yml b/.github/workflows/flaky-test-detector.yml index a232e1e735b1..c24f306c98ea 100644 --- a/.github/workflows/flaky-test-detector.yml +++ b/.github/workflows/flaky-test-detector.yml @@ -51,6 +51,8 @@ jobs: - name: Install Playwright uses: ./.github/actions/install-playwright + with: + browsers: 'chromium' - name: Determine changed tests uses: dorny/paths-filter@v3.0.1 diff --git a/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts b/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts index 6fa8e8ddd416..75db0283c296 100644 --- a/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts +++ b/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts @@ -46,7 +46,7 @@ ${changedPaths.join('\n')} try { await new Promise((resolve, reject) => { const cp = childProcess.spawn( - `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`, + `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount} --project=chromium`, { shell: true, cwd, stdio: 'inherit' }, ); From 3b511f10188c381260013ffaa56eb4b7500d2f5a Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Mon, 3 Feb 2025 16:33:19 +0100 Subject: [PATCH 2/2] fix linting --- .../browser-integration-tests/scripts/detectFlakyTests.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts b/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts index 75db0283c296..1105346562c9 100644 --- a/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts +++ b/dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts @@ -46,7 +46,9 @@ ${changedPaths.join('\n')} try { await new Promise((resolve, reject) => { const cp = childProcess.spawn( - `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount} --project=chromium`, + `npx playwright test ${ + testPaths.length ? testPaths.join(' ') : './suites' + } --repeat-each ${repeatEachCount} --project=chromium`, { shell: true, cwd, stdio: 'inherit' }, );