Skip to content

suggestion: make __SENTRY_ORCHESTRION__.bundler a Set<string> #22920

Description

@isaacs

The bundler banners set g.bundler??=[], and then use that as a list of all the modules that got bundled. The Bun build plugin sets g.bundler=true. When it's an array of module names, we also have logic to ensure it stays unique.

It seems like it'd be easiest to make this a Set<string> instead of string[]. And, even if Bun doesn't actually need it to be a list of items, making it a Set would also be truthy, so it might be worth doing just to ensure it's always the same type, rather than having one bundler be a weird divergent case.

cc @JPeer264 @timfish Feel free to assign to me if you agree, or close if you don't ;)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions