Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] User Feedback Annotations #69786

Open
12 tasks
c298lee opened this issue Apr 26, 2024 · 5 comments · Fixed by getsentry/sentry-javascript#15424
Open
12 tasks

[Epic] User Feedback Annotations #69786

c298lee opened this issue Apr 26, 2024 · 5 comments · Fixed by getsentry/sentry-javascript#15424

Comments

@c298lee
Copy link
Contributor

c298lee commented Apr 26, 2024

The goal of the project is to close a large feature request, sentry users want to allow their customers to create an mark-up screen shots to better illustrate their feedback problems.

Basically, we want to solve for the cases in getsentry/sentry-javascript#9460

Design File

Hackweek example: getsentry/sentry-javascript#11175

Annotations

Not doing

  • Discuss/implement a 'select' mode where existing annotations (shapes, text, freeforms) can be re-selected, so that colors and position can be adjusted.
  • Implement an undo/redo stack AND/OR a 'reset' button to remove some/all annotations
@getsantry
Copy link
Contributor

getsantry bot commented Apr 26, 2024

Routing to @getsentry/product-owners-user-feedback for triage ⏲️

@ryan953
Copy link
Member

ryan953 commented May 22, 2024

closing, duplicate of #63749

@ryan953 ryan953 closed this as completed May 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
@ryan953 ryan953 reopened this Jan 21, 2025
@ryan953
Copy link
Member

ryan953 commented Jan 21, 2025

Re-opened! The other one, #63749 is more about the previous round of basic Screenshot features.

This will be geared towards the renewed effort of annotating/drawing on top of those screenshots.

@c298lee
Copy link
Contributor Author

c298lee commented Jan 24, 2025

Proposal:
We won't be implementing undo, redo, selection, eraser etc because it would require rearchitecting all the current cropping and pen tool annotation work, and would take quite a bit of effort to do.

Our user feedback widget is a way to allow people to easily give feedback and highlight their issue. Creating an image editor tool will have diminishing returns.

Instead, I propose just creating a reset button that resets the image to the original uncropped and unannotated screenshot, in place a full undo/eraser situation. A simple pen tool with the ability to change the pen colour and line width should be sufficient to highlight things on the screenshot as well as block out any PII, and should be sufficient for most cases.

For people who want to be more creative with their feedback, we will add functionality to allow people to add their own attachments to their feedback. This way, if a user wants to add some complicated annotations and visuals to explain their feedback, they can use their own image editing tools and add it as an attachment. Additionally, this feature has been requested by several customers too. To reduce the scope further, we'll start with what was described above, and keep the upload for later.

@c298lee
Copy link
Contributor Author

c298lee commented Feb 20, 2025

We decided to pivot to a new direction: highlight and hide boxes. This will be released on a beta branch and tested out internally before GA

Image

@ryan953 ryan953 assigned ryan953 and unassigned c298lee Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants