Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up SvelteKit isSubRequest check #15244

Closed
Lms24 opened this issue Jan 31, 2025 · 0 comments · Fixed by #15251
Closed

Clean up SvelteKit isSubRequest check #15244

Lms24 opened this issue Jan 31, 2025 · 0 comments · Fixed by #15251
Assignees
@Lms24

Comments

@Lms24
Copy link
Member

Lms24 commented Jan 31, 2025

Description

After dropping SvelteKit 1.x support, we can now clean up the fallback logic for determining if our sentryHandle function is invoked on a sub request or a regular request
@Lms24 Lms24 mentioned this issue Jan 31, 2025
Merged
@Lms24 Lms24 self-assigned this Jan 31, 2025
@Lms24 Lms24 closed this as completed in 76854e8 Feb 4, 2025
Zen-cronic pushed a commit to Zen-cronic/sentry-javascript that referenced this issue Feb 5, 2025
@Lms24 @Zen-cronic
ref(sveltekit): Clean up sub-request check (getsentry#15251)
9c2ed9e 
Removes a no longer necessary fallback check that we only needed in
SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the
`event.isSubRequest` flag to identify sub vs. actual requests in our
request handler.

fixes getsentry#15244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(sveltekit): Clean up sub-request check getsentry/sentry-javascript
1 participant
@Lms24