Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to @fastify/otel instrumentation #15130

Open
andreiborza opened this issue Jan 22, 2025 · 4 comments
Open

Migrate to @fastify/otel instrumentation #15130

andreiborza opened this issue Jan 22, 2025 · 4 comments

Comments

@andreiborza
Copy link
Member

andreiborza commented Jan 22, 2025

Description

Fastify has taken ownership over the fastify Otel instrumentation and migrated the integration out of the opentelemetry-js-contrib repo into their own repo.

Once open-telemetry/opentelemetry-js-contrib#2652 lands, the current instrumentation, which we are using, will be disabled by default and removed completely by March 25, 2025.

Solution Brainstorm

Migrating to @fastify/otel is inevitable, but if integration proves difficult we have to specifically enable the integration,

@mydea
Copy link
Member

mydea commented Jan 22, 2025

is there something that speaks against just switching out the instrumentation right now?

@mydea mydea changed the title Replace fastify otel integration Migrate to @fastify/otel instrumentation Jan 22, 2025
@mydea
Copy link
Member

mydea commented Jan 22, 2025

hmm, this only supports fastify 5+ 😬

@mydea
Copy link
Member

mydea commented Jan 22, 2025

See: fastify/otel#10

@mydea
Copy link
Member

mydea commented Jan 22, 2025

After talking about this some more, our idea is to:

  1. Switch to use @fastify/otel instead of @opentelemetry/instrumentation-fastify
  2. Vendor the current state of @opentelemetry/instrumentation-fastify into the node package (note: We'll need to also inline some of the types accordingly). Limiting the range this applies to to >=3<=4.

We can use this blueprint for other similar situations too, in the future! This way, we continue to support fastify 3+, but can stay on the latest version of the official instrumentation and get improvements from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants