Drizzle expression imports broken with latest sentry profiling version

[livingforjesus]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

8.50.0

Framework Version

No response

Link to Sentry event

No response

Reproduction Example/SDK Setup

https://github.com/livingforjesus/sentry-issue-repro

To reproduce just:

• Replace process.env.DSN with a valid sentry dsn
• Run pnpm i
• Start via pnpm start.

Steps to Reproduce

We were on sentry v8.48.0 and tried upgrading to sentry v8.50.0. However upgrading sentry-profiling-node causes something weird to happen during our build process that makes certain drizzle expressions not to be exported. The expressions not exported are located in drizzle-orm/expressions/index.ts or something like that(in drizzle codebase). These throw an error whenever we try to access. Other functions from drizzle are exported and work normally

Note:

• We use esm
• We're using vite-node to execute the code
• Everything works file until you upgrade sentry-profiling-node(sentry itself upgrades file) from v8.48.0 to v8.49.0

Expected Result

Everything works normally, I'm able to start api and operate as normal

Actual Result

TypeError: (0 , __vite_ssr_import_0__.isNotNull) is not a function
    at PgTable.<anonymous> (/Users/visiononyeaku/Desktop/Work/repro-sentry/src/schema.ts:14:47)
    at extractTablesRelationalConfig (file:///Users/visiononyeaku/Desktop/Work/repro-sentry/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected][email protected][email protected]/node_modules/src/relations.ts:463:61)
    at construct (file:///Users/visiononyeaku/Desktop/Work/repro-sentry/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected][email protected][email protected]/node_modules/src/postgres-js/driver.ts:48:24)
    at drizzle (file:///Users/visiononyeaku/Desktop/Work/repro-sentry/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected][email protected][email protected]/node_modules/src/postgres-js/driver.ts:110:10)
    at /Users/visiononyeaku/Desktop/Work/repro-sentry/src/db.ts:4:16
    at ViteNodeRunner.runModule (file:///Users/visiononyeaku/Desktop/Work/repro-sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite-node/dist/client.mjs:399:5)
    at ViteNodeRunner.directRequest (file:///Users/visiononyeaku/Desktop/Work/repro-sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite-node/dist/client.mjs:381:5)
    at ViteNodeRunner.cachedRequest (file:///Users/visiononyeaku/Desktop/Work/repro-sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite-node/dist/client.mjs:206:14)
    at ViteNodeRunner.dependencyRequest (file:///Users/visiononyeaku/Desktop/Work/repro-sentry/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite-node/dist/client.mjs:259:12)
    at /Users/visiononyeaku/Desktop/Work/repro-sentry/src/index.ts:4:1

Node.js v20.14.0

[andreiborza]

Hi @livingforjesus, thanks for filing this. We are currently working on some improvements for sentry profiling that might be related.

Could you please provide a sample repo we can use to test with?

[livingforjesus]

Yes @andreiborza . I provided this repo:
https://github.com/livingforjesus/sentry-issue-repro

[andreiborza]

Ahh, sorry I overlooked that. Taking a look.

[andreiborza]

Not sure what exactly is happening, but it might be that one of the recent otel bumps broke this. You can work around this by setting the following in your Sentry.init:

registerEsmLoaderHooks: {
   onlyIncludeInstrumentedModules: true,
}

This way import-in-the-middle only wraps over packages Sentry needs for instrumentation. We had a similar issue with hapi before, see the troubleshooting section here: https://docs.sentry.io/platforms/javascript/guides/hapi/install/esm/#troubleshooting-instrumentation

Let me know if this works for you.

[Lms24]

I think this is essentially a duplicate of #12912 (ignore the Astro part). Moreover, in v9, onlyIncludeInstrumentedModules will default to true (#14332).

IIRC the TLDR here is that the drizzle package has a very special way of specifying exports which import-in-the-middle can't really handle correctly. Hence, excluding it from being wrapped is probably the best option for now. Let us know of this works for you, then we'll close this issue.

[livingforjesus]

Ok lemme try that

[livingforjesus]

Yes works